From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Fix 32b overflow check in gen8_ppgtt_alloc_page_directories Date: Wed, 6 May 2015 12:14:51 +0200 Message-ID: <20150506101451.GQ30184@phenom.ffwll.local> References: <20150430104745.GA25329@mwanda> <1430406411-30953-1-git-send-email-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTP id E606D8A065 for ; Wed, 6 May 2015 03:12:32 -0700 (PDT) Received: by wgin8 with SMTP id n8so6094467wgi.0 for ; Wed, 06 May 2015 03:12:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1430406411-30953-1-git-send-email-michel.thierry@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMzAsIDIwMTUgYXQgMDQ6MDY6NTFQTSArMDEwMCwgTWljaGVsIFRoaWVycnkg d3JvdGU6Cj4gVGhlIHBhdGNoIDY5ODc2YmVkN2UwMDhmNWZlMDE1MzhhMmQ0N2MwOWYyODYyMTI5 ZDA6ICJkcm0vaTkxNS9nZW44Ogo+IHBhZ2UgZGlyZWN0b3JpZXMgcmV3b3JrIGFsbG9jYXRpb24i IGFkZGVkIGFuIG92ZXJmbG93IHdhcm5pbmcsIGJ1dCB0aGUKPiBtYXNrIGhhZCBhbiBleHRyYSAw LiBVc2UgdHlwby1wcm9uZSBvcHRpb24gc3VnZ2VzdGVkIGJ5IERhdmUgaW5zdGVhZCwKCkkgaW5z ZXJ0ZWQgdGhlICJsZXNzIiBhYm92ZSB3aGlsZSBhcHBseWluZy4KCj4gdG8gY2hlY2sgZm9yIChz dGFydCArIGxlbmd0aCkgPj0gMHgxMDAwMDAwMDBVTEwuCj4gCj4gVGhpcyBjaGVjayB3aWxsIGJl IHVubmVjZXNzYXJ5IGFmdGVyIGdlbjhfYWxsb2NfdmFfcmFuZ2UgaGFuZGxlcyBtb3JlCj4gdGhh biA0IFBEUHMgKDQ4YiBhZGRyZXNzaW5nKS4KPiAKPiB2MjogUmVhbGx5IGNoZWNrIGZvciAzMmIg b3ZlcmZsb3cgKFZpbGxlKQo+IAo+IFJlcG9ydGVkLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2Fy cGVudGVyQG9yYWNsZS5jb20+Cj4gQ2M6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRl bC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+Cj4gU2lnbmVkLW9mZi1ieTogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVs LmNvbT4KClF1ZXVlZCBmb3IgLW5leHQsIHRoYW5rcyBmb3IgdGhlIHBhdGNoLgotRGFuaWVsCj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIHwgNCArKy0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBpbmRleCA2ZmFlNmJkLi4zNDUwY2I1IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBAQCAtNzU2LDggKzc1Niw4IEBAIHN0YXRp YyBpbnQgZ2VuOF9wcGd0dF9hbGxvY19wYWdlX2RpcmVjdG9yaWVzKHN0cnVjdCBpOTE1X2h3X3Bw Z3R0ICpwcGd0dCwKPiAgCj4gIAlXQVJOX09OKCFiaXRtYXBfZW1wdHkobmV3X3BkcywgR0VOOF9M RUdBQ1lfUERQRVMpKTsKPiAgCj4gLQkvKiBGSVhNRTogUFBHVFQgY29udGFpbmVyX29mIHdvbid0 IHdvcmsgZm9yIDY0YiAqLwo+IC0JV0FSTl9PTigoc3RhcnQgKyBsZW5ndGgpID4gMHg4MDAwMDAw MDBVTEwpOwo+ICsJLyogRklYTUU6IHVwcGVyIGJvdW5kIG11c3Qgbm90IG92ZXJmbG93IDMyIGJp dHMgICovCj4gKwlXQVJOX09OKChzdGFydCArIGxlbmd0aCkgPj0gKDFVTEwgPDwgMzIpKTsKPiAg Cj4gIAlnZW44X2Zvcl9lYWNoX3BkcGUocGQsIHBkcCwgc3RhcnQsIGxlbmd0aCwgdGVtcCwgcGRw ZSkgewo+ICAJCWlmIChwZCkKPiAtLSAKPiAyLjEuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK