From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915/audio: do not mess with audio registers if port is invalid Date: Wed, 6 May 2015 13:11:56 +0200 Message-ID: <20150506111156.GX30184@phenom.ffwll.local> References: <1430749249-15565-1-git-send-email-jani.nikula@intel.com> <1430749249-15565-2-git-send-email-jani.nikula@intel.com> <55485628.7070009@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 50C286E649 for ; Wed, 6 May 2015 04:09:37 -0700 (PDT) Received: by widdi4 with SMTP id di4so17889791wid.0 for ; Wed, 06 May 2015 04:09:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55485628.7070009@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sivakumar Thulasimani Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXkgMDUsIDIwMTUgYXQgMTE6MDM6MjhBTSArMDUzMCwgU2l2YWt1bWFyIFRodWxh c2ltYW5pIHdyb3RlOgo+IFJldmlld2VkLWJ5OiBTaXZha3VtYXIgVGh1bGFzaW1hbmkgPHNpdmFr dW1hci50aHVsYXNpbWFuaUBpbnRlbC5jb20+Cj4gCj4gT24gNS80LzIwMTUgNzo1MCBQTSwgSmFu aSBOaWt1bGEgd3JvdGU6Cj4gPldlIHNob3VsZCBubyBsb25nZXIgZW50ZXIgdGhlIGNvZGVjIGVu YWJsZS9kaXNhYmxlIGZ1bmN0aW9ucyBpbiBxdWVzdGlvbgo+ID53aXRoIHBvcnQgQSBhbnl3YXks IGJ1dCB0byBlcnIgb24gdGhlIHNhZmUgc2lkZSwga2VlcCB0aGUgd2FybmluZ3MuIEp1c3QKPiA+ YmFpbCBvdXQgZWFybHkgd2l0aG91dCBtZXNzaW5nIHdpdGggdGhlIHJlZ2lzdGVycy4KPiA+Cj4g PlNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgpRdWV1 ZWQgZm9yIC1uZXh0LCB0aGFua3MgZm9yIHRoZSBwYXRjaC4KLURhbmllbAoKPiA+LS0tCj4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYyB8IDIwICsrKysrKysrLS0tLS0tLS0t LS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0p Cj4gPgo+ID5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPiA+aW5kZXggZjcyZTkzYTQ1ZTEx Li5jNDMxMjE3N2IwZWUgMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2F1ZGlvLmMKPiA+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYwo+ID5A QCAtMjY5LDYgKzI2OSw5IEBAIHN0YXRpYyB2b2lkIGlsa19hdWRpb19jb2RlY19kaXNhYmxlKHN0 cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ID4gIAlEUk1fREVCVUdfS01TKCJEaXNhYmxl IGF1ZGlvIGNvZGVjIG9uIHBvcnQgJWMsIHBpcGUgJWNcbiIsCj4gPiAgCQkgICAgICBwb3J0X25h bWUocG9ydCksIHBpcGVfbmFtZShwaXBlKSk7Cj4gPisJaWYgKFdBUk5fT04ocG9ydCA9PSBQT1JU X0EpKQo+ID4rCQlyZXR1cm47Cj4gPisKPiA+ICAJaWYgKEhBU19QQ0hfSUJYKGRldl9wcml2LT5k ZXYpKSB7Cj4gPiAgCQlhdWRfY29uZmlnID0gSUJYX0FVRF9DRkcocGlwZSk7Cj4gPiAgCQlhdWRf Y250cmxfc3QyID0gSUJYX0FVRF9DTlRMX1NUMjsKPiA+QEAgLTI5MCwxMiArMjkzLDcgQEAgc3Rh dGljIHZvaWQgaWxrX2F1ZGlvX2NvZGVjX2Rpc2FibGUoc3RydWN0IGludGVsX2VuY29kZXIgKmVu Y29kZXIpCj4gPiAgCQl0bXAgfD0gQVVEX0NPTkZJR19OX1ZBTFVFX0lOREVYOwo+ID4gIAlJOTE1 X1dSSVRFKGF1ZF9jb25maWcsIHRtcCk7Cj4gPi0JaWYgKFdBUk5fT04oIXBvcnQpKSB7Cj4gPi0J CWVsZHYgPSBJQlhfRUxEX1ZBTElEKFBPUlRfQikgfCBJQlhfRUxEX1ZBTElEKFBPUlRfQykgfAo+ ID4tCQkJSUJYX0VMRF9WQUxJRChQT1JUX0QpOwo+ID4tCX0gZWxzZSB7Cj4gPi0JCWVsZHYgPSBJ QlhfRUxEX1ZBTElEKHBvcnQpOwo+ID4tCX0KPiA+KwllbGR2ID0gSUJYX0VMRF9WQUxJRChwb3J0 KTsKPiA+ICAJLyogSW52YWxpZGF0ZSBFTEQgKi8KPiA+ICAJdG1wID0gSTkxNV9SRUFEKGF1ZF9j bnRybF9zdDIpOwo+ID5AQCAtMzI1LDYgKzMyMyw5IEBAIHN0YXRpYyB2b2lkIGlsa19hdWRpb19j b2RlY19lbmFibGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ICAJRFJNX0RF QlVHX0tNUygiRW5hYmxlIGF1ZGlvIGNvZGVjIG9uIHBvcnQgJWMsIHBpcGUgJWMsICV1IGJ5dGVz IEVMRFxuIiwKPiA+ICAJCSAgICAgIHBvcnRfbmFtZShwb3J0KSwgcGlwZV9uYW1lKHBpcGUpLCBk cm1fZWxkX3NpemUoZWxkKSk7Cj4gPisJaWYgKFdBUk5fT04ocG9ydCA9PSBQT1JUX0EpKQo+ID4r CQlyZXR1cm47Cj4gPisKPiA+ICAJLyoKPiA+ICAJICogRklYTUU6IFdlJ3JlIHN1cHBvc2VkIHRv IHdhaXQgZm9yIHZibGFuayBoZXJlLCBidXQgd2UgaGF2ZSB2YmxhbmtzCj4gPiAgCSAqIGRpc2Fi bGVkIGR1cmluZyB0aGUgbW9kZSBzZXQuIFRoZSBwcm9wZXIgZml4IHdvdWxkIGJlIHRvIHB1c2gg dGhlCj4gPkBAIC0zNDksMTIgKzM1MCw3IEBAIHN0YXRpYyB2b2lkIGlsa19hdWRpb19jb2RlY19l bmFibGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ICAJCWF1ZF9jbnRybF9z dDIgPSBDUFRfQVVEX0NOVFJMX1NUMjsKPiA+ICAJfQo+ID4tCWlmIChXQVJOX09OKCFwb3J0KSkg ewo+ID4tCQllbGR2ID0gSUJYX0VMRF9WQUxJRChQT1JUX0IpIHwgSUJYX0VMRF9WQUxJRChQT1JU X0MpIHwKPiA+LQkJCUlCWF9FTERfVkFMSUQoUE9SVF9EKTsKPiA+LQl9IGVsc2Ugewo+ID4tCQll bGR2ID0gSUJYX0VMRF9WQUxJRChwb3J0KTsKPiA+LQl9Cj4gPisJZWxkdiA9IElCWF9FTERfVkFM SUQocG9ydCk7Cj4gPiAgCS8qIEludmFsaWRhdGUgRUxEICovCj4gPiAgCXRtcCA9IEk5MTVfUkVB RChhdWRfY250cmxfc3QyKTsKPiAKPiAtLSAKPiByZWdhcmRzLAo+IFNpdmFrdW1hcgo+IAo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFu aWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Js b2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK