Received: from eggs.gnu.org ([2001:4830:134:3::10]:37211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrp6d-0001nX-So for qemu-devel@nongnu.org; Mon, 11 May 2015 10:54:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yrp6a-0008Bt-Fm for qemu-devel@nongnu.org; Mon, 11 May 2015 10:54:55 -0400 Date: Mon, 11 May 2015 15:54:37 +0100 From: Stefan Hajnoczi Message-ID: <20150511145437.GJ16270@stefanha-thinkpad.redhat.com> References: <1430746944-27347-1-git-send-email-den@openvz.org> <1430746944-27347-3-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gBdJBemW82xJqIAr" Content-Disposition: inline In-Reply-To: <1430746944-27347-3-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to page List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Paolo Bonzini , Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org --gBdJBemW82xJqIAr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 04, 2015 at 04:42:24PM +0300, Denis V. Lunev wrote: > @@ -726,7 +727,8 @@ static void raw_refresh_limits(BlockDriverState *bs, = Error **errp) > =20 > raw_probe_alignment(bs, s->fd, errp); > bs->bl.min_mem_alignment =3D s->buf_align; > - bs->bl.opt_mem_alignment =3D s->buf_align; > + if (bs->bl.min_mem_alignment > bs->bl.opt_mem_alignment) > + bs->bl.opt_mem_alignment =3D bs->bl.min_mem_alignment; QEMU coding style uses {} even when the if statement body is only one line. --gBdJBemW82xJqIAr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVUMKtAAoJEJykq7OBq3PIi4gH/3JOXe8gOPiSiTP64OwjgTng llI3zxbBPW1m0QomNCOAP/s/rYDfxPbyH3VgFEdEOzi3RQawlATl4qKkGv1sxZLn 3YdahouGmmN3QedYWNaxT2You/xCrqbTZESjr97k4oJMNp3qGX+3IrQgzfFx21cK oZELxR444UhMDxZLP25cXMhy4UnqqLI3jvdceUu+NpRpP6D7p+PDc5dv3XR+MNES cZBV7HUnBX1F+tAW9X6kdq8bNjfHblmBmGw8KpB05bKpvRVLtcVMshutb834rgQU vPfdwx3gYzBhcclK44Htp/51fYGkdPfJBPJXVglDeVLoCxvIZwFG1xrDYvKcHWg= =aRwq -----END PGP SIGNATURE----- --gBdJBemW82xJqIAr--