From: Daniel Vetter Subject: Re: [PATCH] drm/atomic: add drm_atomic_get_existing_*_state helpers Date: Wed, 13 May 2015 11:08:21 +0200 Message-ID: <20150513090821.GX15256@phenom.ffwll.local> References: <1431506245-30920-1-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 255E66E1D7 for ; Wed, 13 May 2015 02:06:01 -0700 (PDT) Received: by widdi4 with SMTP id di4so47039986wid.0 for ; Wed, 13 May 2015 02:06:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1431506245-30920-1-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMTMsIDIwMTUgYXQgMTA6Mzc6MjVBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhlcmUgYXJlIGNhc2VzIHdoZXJlIHdlIHdhbnQgdG8gdGVzdCBpZiBhIGdp dmVuIG9iamVjdCBpcwo+IHBhcnQgb2YgdGhlIHN0YXRlLCBidXQgZG9uJ3Qgd2FudCB0byBhZGQg dGhlbSBpZiB0aGV5J3JlIG5vdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3Jz dCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKWWVhaCBtYWtlcyBzZW5zZSB0 byB3cmFwIHRoZXNlLiBBcHBsaWVkIHRvIHRvcGljL2RybS1taXNjLCB0aGFua3MuCi1EYW5pZWwK Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgfCAxOCArKysrKysrLS0tLS0t LS0tCj4gIGluY2x1ZGUvZHJtL2RybV9hdG9taWMuaCAgICAgfCA1MCArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDU4IGluc2Vy dGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2F0b21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IDg4 MjU5MDU3Zjg3Yi4uNDczNjRmMjQ0ZGMwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTI2 MywxMyArMjYzLDEyIEBAIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqCj4gIGRybV9hdG9taWNfZ2V0 X2NydGNfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAJCQkgIHN0cnVj dCBkcm1fY3J0YyAqY3J0YykKPiAgewo+IC0JaW50IHJldCwgaW5kZXg7Cj4gKwlpbnQgcmV0LCBp bmRleCA9IGRybV9jcnRjX2luZGV4KGNydGMpOwo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpj cnRjX3N0YXRlOwo+ICAKPiAtCWluZGV4ID0gZHJtX2NydGNfaW5kZXgoY3J0Yyk7Cj4gLQo+IC0J aWYgKHN0YXRlLT5jcnRjX3N0YXRlc1tpbmRleF0pCj4gLQkJcmV0dXJuIHN0YXRlLT5jcnRjX3N0 YXRlc1tpbmRleF07Cj4gKwljcnRjX3N0YXRlID0gZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY3J0 Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gKwlpZiAoY3J0Y19zdGF0ZSkKPiArCQlyZXR1cm4gY3J0 Y19zdGF0ZTsKPiAgCj4gIAlyZXQgPSBkcm1fbW9kZXNldF9sb2NrKCZjcnRjLT5tdXRleCwgc3Rh dGUtPmFjcXVpcmVfY3R4KTsKPiAgCWlmIChyZXQpCj4gQEAgLTM5NywxMyArMzk2LDEyIEBAIHN0 cnVjdCBkcm1fcGxhbmVfc3RhdGUgKgo+ICBkcm1fYXRvbWljX2dldF9wbGFuZV9zdGF0ZShzdHJ1 Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIAkJCSAgc3RydWN0IGRybV9wbGFuZSAqcGxh bmUpCj4gIHsKPiAtCWludCByZXQsIGluZGV4Owo+ICsJaW50IHJldCwgaW5kZXggPSBkcm1fcGxh bmVfaW5kZXgocGxhbmUpOwo+ICAJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGU7 Cj4gIAo+IC0JaW5kZXggPSBkcm1fcGxhbmVfaW5kZXgocGxhbmUpOwo+IC0KPiAtCWlmIChzdGF0 ZS0+cGxhbmVfc3RhdGVzW2luZGV4XSkKPiAtCQlyZXR1cm4gc3RhdGUtPnBsYW5lX3N0YXRlc1tp bmRleF07Cj4gKwlwbGFuZV9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX3BsYW5lX3N0 YXRlKHN0YXRlLCBwbGFuZSk7Cj4gKwlpZiAocGxhbmVfc3RhdGUpCj4gKwkJcmV0dXJuIHBsYW5l X3N0YXRlOwo+ICAKPiAgCXJldCA9IGRybV9tb2Rlc2V0X2xvY2soJnBsYW5lLT5tdXRleCwgc3Rh dGUtPmFjcXVpcmVfY3R4KTsKPiAgCWlmIChyZXQpCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJt L2RybV9hdG9taWMuaCBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IGluZGV4IDk1M2FmNmJk NzQzMC4uNjQ0NTk3MDUzNWVjIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMu aAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IEBAIC01OSw2ICs1OSw1NiBAQCBp bnQgZHJtX2F0b21pY19jb25uZWN0b3Jfc2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uZWN0b3IsCj4gIAkJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKnN0YXRlLCBzdHJ1 Y3QgZHJtX3Byb3BlcnR5ICpwcm9wZXJ0eSwKPiAgCQl1aW50NjRfdCB2YWwpOwo+ICAKPiArLyoq Cj4gKyAqIGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUgLSBnZXQgY3J0YyBzdGF0 ZSwgaWYgaXQgZXhpc3RzCj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QK PiArICogQGNydGM6IGNydGMgdG8gZ3JhYgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIHJldHVy bnMgdGhlIGNydGMgc3RhdGUgZm9yIHRoZSBnaXZlbiBjcnRjLCBvciBOVUxMCj4gKyAqIGlmIHRo ZSBjcnRjIGlzIG5vdCBwYXJ0IG9mIHRoZSBnbG9iYWwgYXRvbWljIHN0YXRlLgo+ICsgKi8KPiAr c3RhdGljIGlubGluZSBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2dldF9l eGlzdGluZ19jcnRjX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJ CSAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiArewo+ICsJcmV0dXJuIHN0YXRlLT5jcnRjX3N0 YXRlc1tkcm1fY3J0Y19pbmRleChjcnRjKV07Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBkcm1fYXRv bWljX2dldF9leGlzdGluZ19wbGFuZV9zdGF0ZSAtIGdldCBwbGFuZSBzdGF0ZSwgaWYgaXQgZXhp c3RzCj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QKPiArICogQHBsYW5l OiBwbGFuZSB0byBncmFiCj4gKyAqCj4gKyAqIFRoaXMgZnVuY3Rpb24gcmV0dXJucyB0aGUgcGxh bmUgc3RhdGUgZm9yIHRoZSBnaXZlbiBwbGFuZSwgb3IgTlVMTAo+ICsgKiBpZiB0aGUgcGxhbmUg aXMgbm90IHBhcnQgb2YgdGhlIGdsb2JhbCBhdG9taWMgc3RhdGUuCj4gKyAqLwo+ICtzdGF0aWMg aW5saW5lIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2dldF9leGlzdGlu Z19wbGFuZV9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gKwkJCQkgICAg c3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4gK3sKPiArCXJldHVybiBzdGF0ZS0+cGxhbmVfc3Rh dGVzW2RybV9wbGFuZV9pbmRleChwbGFuZSldOwo+ICt9Cj4gKwo+ICsvKioKPiArICogZHJtX2F0 b21pY19nZXRfZXhpc3RpbmdfY29ubmVjdG9yX3N0YXRlIC0gZ2V0IGNvbm5lY3RvciBzdGF0ZSwg aWYgaXQgZXhpc3RzCj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QKPiAr ICogQGNvbm5lY3RvcjogY29ubmVjdG9yIHRvIGdyYWIKPiArICoKPiArICogVGhpcyBmdW5jdGlv biByZXR1cm5zIHRoZSBjb25uZWN0b3Igc3RhdGUgZm9yIHRoZSBnaXZlbiBjb25uZWN0b3IsCj4g KyAqIG9yIE5VTEwgaWYgdGhlIGNvbm5lY3RvciBpcyBub3QgcGFydCBvZiB0aGUgZ2xvYmFsIGF0 b21pYyBzdGF0ZS4KPiArICovCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9jb25uZWN0b3Jf c3RhdGUgKgo+ICtkcm1fYXRvbWljX2dldF9leGlzdGluZ19jb25uZWN0b3Jfc3RhdGUoc3RydWN0 IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICsJCQkJCXN0cnVjdCBkcm1fY29ubmVjdG9yICpj b25uZWN0b3IpCj4gK3sKPiArCWludCBpbmRleCA9IGRybV9jb25uZWN0b3JfaW5kZXgoY29ubmVj dG9yKTsKPiArCj4gKwlpZiAoaW5kZXggPj0gc3RhdGUtPm51bV9jb25uZWN0b3IpCj4gKwkJcmV0 dXJuIE5VTEw7Cj4gKwo+ICsJcmV0dXJuIHN0YXRlLT5jb25uZWN0b3Jfc3RhdGVzW2luZGV4XTsK PiArfQo+ICsKPiAgaW50IF9fbXVzdF9jaGVjawo+ICBkcm1fYXRvbWljX3NldF9jcnRjX2Zvcl9w bGFuZShzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSwKPiAgCQkJICAgICAgc3Ry dWN0IGRybV9jcnRjICpjcnRjKTsKPiAtLSAKPiAyLjEuMAo+IAo+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0 d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK