From: Damien Lespiau Subject: Re: [PATCH] drm/i915/skl: Handle eDP from generic crtc_compute_clock vfunc Date: Wed, 13 May 2015 18:25:32 +0100 Message-ID: <20150513172532.GA31875@strange.amr.corp.intel.com> References: <1431535244-8311-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20150513165617.GE10669@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C025F6E6BC for ; Wed, 13 May 2015 10:25:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150513165617.GE10669@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Ander Conselvan de Oliveira , Intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMTMsIDIwMTUgYXQgMDU6NTY6MTdQTSArMDEwMCwgRGFtaWVuIExlc3BpYXUg d3JvdGU6Cj4gT24gV2VkLCBNYXkgMTMsIDIwMTUgYXQgMDU6NDA6NDRQTSArMDEwMCwgVHZydGtv IFVyc3VsaW4gd3JvdGU6Cj4gPiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A aW50ZWwuY29tPgo+ID4gCj4gPiBTaW5jZSBjb21taXQgNDk3OGNjOTNkOWFjMjQwYjQzNWNlNjA0 MzFhZWYyNDIzOWI0YzI3MCBzdGFydGVkIGNsZWFyaW5nCj4gPiBkcGxsIHN0YXRlIGFuZCByZWNv bXB1dGluZyBpdCB2aWEgY3J0Y19jb21wdXRlX2Nsb2NrIChhbmQgcHJvYmFibHkgc29tZQo+ID4g b3RoZXIgY29tbWl0IHdoaWNoIHRyaWdnZXJlZCBwaXBlIGNvbmZpZyBjaGVja2luZyksIG1vZGVz ZXR0aW5nIGlzIG5vdwo+ID4gY29uc3RhbnRseSB0cmlnZ2VyaW5nIHdhcm5pbmdzIGFib3V0IGRw bGxfaHdfc3RhdGUuY3RybDEgbWlzbWF0Y2guCj4gPiAKPiA+IFJlYXNvbiBpcyBjcnRjX2NvbXB1 dGVfY2xvY2sgY2FsbHMgc2tsX2RkaV9wbGxfc2VsZWN0IHdoaWNoIGRvZXMgbm90IGRvCj4gPiBh bnl0aGluZyBmb3IgZURQLCBsZWF2aW5nIHRoZSBjdHJsMSBzdGF0ZSBhdCB0aGUgZGVmYXVsdCBv ZiB6ZXJvLgo+ID4gCj4gPiBUaGlzIHBvdGVudGlhbGx5IGhhY2t5IGZpeCBtYWtlcyBza2xfZGRp X3BsbF9zZWxlY3QgY2FsbAo+ID4gc2tsX2VkcF9zZXRfcGxsX2NvbmZpZyB3aGljaCBmaXhlcyB0 aGUgcHJvYmxlbSBmb3IgbWUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gPiBDYzogRGFtaWVuIExlc3BpYXUgPGRhbWll bi5sZXNwaWF1QGludGVsLmNvbT4KPiA+IENjOiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEg PGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+Cj4gPiBDYzogTWFhcnRlbiBM YW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzD pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4gTm9wISAoYXQgbGVhc3QgSSBy ZWFsbHkgZG9uJ3QgdGhpbmsgc28pLgo+IAo+IEFzIGRpc2N1c3NlZCBvbiBJUkMsIG9uIERESSBw bGF0Zm9ybXMsIHRoZSAoZSlEUCBjb21wdXRlX2NvbmZpZygpIGRvZXMKPiB0aGUgcHJpdmF0ZSBE UExMIHNlbGVjdGlvbiwgYW5kIHRoZSBkZGlfcGxsX3NlbGVjdCgpIGRvZXMgdGhlIHRoZSBzYW1l Cj4gZm9yIHNoYXJlZCBEUExMcyAoSSdtIG5vdCBzYXlpbmcgdGhhdCB0aGUgZW5kIHJlc3VsdCB3 ZSB3YW50LCBqdXN0IGhvdwo+IGl0IHdvcmtzIHRvZGF5KS4gVGhhdCBzcGxpdCBjb21lcyBmcm9t IHRoZSBpbnRyb2R1Y3Rpb24gb2Ygc2hhcmVkX2RwbGwKPiBpbiB0aGUgRERJIFBMTCBzZWxlY3Rp b24gbGFzdCBzdW1tZXIuCj4gCj4gQW55d2F5LCB0aGlzIG1lYW5zIHRoYXQsIGZvciBTS0wsIGRw bGxfaHdfc3RhdGUgaXMgdG91Y2hlZCBieSB0aGUKPiBlbmNvZGVyJ3MgY29tcHV0ZV9jb25maWco KSBmb3IgKGUpRFAuCj4gCj4gSSB0aGluayB3ZSBjb3VsZCBqdXN0IHJlbW92ZSB0aGUgbWVtc2V0 KCkgaW4gNDk3OGNjOTMgKG1heWJlPyksIG9yIHRyeQo+IHRvIHVuaWZ5IGEgYml0IGJldHRlciBh bmQgb25seSBoYXZlIG9uZSBwbGFjZSB3aGVyZSB3ZSBkbyBQTEwgc2VsZWN0aW9uCj4gKHdoaWNo IEkgYXNzdW1lIGlzIHBhcnQgb2YgdGhlIGJpZ2dlciBhdG9taWMgcGxhbikuIE5vdAo+IHNrbF9l ZHBfc2V0X3BsbF9jb25maWcoKSBpbiBib3RoIGNvbXB1dGVfY29uZmlnKCkgYW5kIGRkaV9wbGxf c2VsZWN0KCkKPiB0aG91Z2guCgpUbyBiZSBtb3JlIHByZWNpc2U6Cgpjb21taXQgNDk3OGNjOTNk OWFjMjQwYjQzNWNlNjA0MzFhZWYyNDIzOWI0YzI3MApBdXRob3I6IEFuZGVyIENvbnNlbHZhbiBk ZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KRGF0ZTog ICBUdWUgQXByIDIxIDE3OjEzOjIxIDIwMTUgKzAzMDAKCiAgICBkcm0vaTkxNTogUHJlc2VydmUg c2hhcmVkIERQTEwgaW5mb3JtYXRpb24gaW4gbmV3IHBpcGVfY29uZmlnCiAgICAKICAgIFdoZW4g YSBuZXcgcGlwZV9jb25maWcgaXMgY2FsY3VsYXRlZCwgdGhlIGZpZWxkcyByZWxhdGVkIHRvIHNo YXJlZCBkcGxscwogICAgYXJlIHJlc2V0LCB1bmRlciB0aGUgYXNzdW1wdGlvbiB0aGF0IHRoZXkg d2lsbCBiZSByZWNhbGN1bGF0ZWQgYXMgcGFydAogICAgb2YgdGhlIG1vZGVzZXQsIHdoaWNoIGlz IHRydWUgd2l0aCB0aGUgY3VycmVudCBzdGF0ZSBvZiB0aGUgY29kZS4KICAgIAogICAgQXMgd2Ug Y29udmVydCB0byBhdG9taWMsIGhvd2V2ZXIsIGl0IHdpbGwgYmUgcG9zc2libGUgdG8gY2FsY3Vs YXRlIGEgbmV3CiAgICBwaXBlX2NvbmZpZyBhbmQgc2tpcCB0aGUgbW9kZXNldC4gSW4gdGhhdCBj YXNlLCBhZnRlciB0aGUgc3RhdGUgc3dhcCB3ZQogICAgc3RpbGwgd2FudCB0aGUgc2hhcmVkIGRw bGxzIHRvIGJlIHByZXNlcnZlZC4KCkV4Y2VwdCB0aGF0IGRwbGxfaHdfc3RhdGUgaXMgbm90IGp1 c3QgZm9yIHNoYXJlZCBEUExMcy4gU28gbWF5YmUgZHBsbF9od19zdGF0ZQpzaG91bGRuJ3QgYmUg cHJlc2VydmVkIChpbiBjbGVhcl9pbnRlbF9jcnRjX3N0YXRlKCkgaW4gdGhlIGNhc2Ugd2hlcmUK c2hhcmVkX2RwbGwgaXMgRFBMTF9JRF9QUklWQVRFPwoKTm90ZSB0aGF0IGRkaV9wbGxfc2VsIGlz IGFsc28gYSBmaWVsZCBzZXQgYnkgdGhlIERESSBQTEwgc2VsZWN0aW9uIGNvZGUgeW91IG1heQp3 YW50IHRvIHByZXNlcnZlIGluIGNsZWFyX2ludGVsX2NydGNfc3RhdGUoKS4KCi0tIApEYW1pZW4K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK