From: Daniel Vetter Subject: Re: [PATCH 3/3] drm/i915/bios: be more explicit about discarding iomem address space Date: Mon, 18 May 2015 10:00:35 +0200 Message-ID: <20150518080034.GG15256@phenom.ffwll.local> References: <1431520445-24998-1-git-send-email-jani.nikula@intel.com> <1431520445-24998-3-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTP id B78CC6E41C for ; Mon, 18 May 2015 00:58:09 -0700 (PDT) Received: by wicmx19 with SMTP id mx19so68122803wic.0 for ; Mon, 18 May 2015 00:58:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1431520445-24998-3-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMTMsIDIwMTUgYXQgMDM6MzQ6MDVQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gQWRkIG9uZSBleHBsaWNpdCBkaXNjYXJkIG9mIF9faW9tZW0gYWRkcmVzcyBzcGFjZSBx dWFsaWZpZXIgaW4KPiB2YWxpZGF0ZV92YnQoKSwgYW5kIHJlc3BlY3QgaXQgb3RoZXJ3aXNlLiBU aGlzIGFkZHMgY2xhcml0eSBpbiB0aGUgY29kZSwKPiBhbmQgcmVkdWNlcyB0aGUgc3BhcnNlIHdh cm5pbmdzIGZyb20gdGhlIG1vZHVsZSB0byBqdXN0IG9uZS4KPiAKPiBRdW90aW5nIERhbmllbCwg IlRoZSB2YnQgcmVhbGx5IGlzIHBsYWluIG9sZCBtZW1vcnkuIEV4Y2VwdCB0aGF0IGl0J3MKPiBy ZXNlcnZlZCBpbiB0aGUgZTgyMCB0YWJsZSBhcyBzb21ldGhpbmcgc3BlY2lhbCBhbmQgaGVuY2Ug dHJlYXRlZCBhcyBpbwo+IHJhbmdlIGJ5IHRoZSBrZXJuZWwuIEJ1dCBpdCBpcyBtZW1vcnksIGhl bmNlIGNhc3RpbmcgYXdheSB0aGUgX19pb21lbSBpcwo+IGltbyB0aGUgcmlnaHQgYXBwcm9hY2gu Igo+IAo+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ CgpNZXJnZWQgZW50aXJlIHNlcmllcywgdGhhbmtzLgotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCAyMSArKysrKysrKysrKysrKy0tLS0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IGluZGV4IDZlMDE4YmE1MzAzNS4uMTk4ZmMzYzMyOTFi IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IEBAIC0xMTk5LDE1ICsxMTk5LDIy IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZG1pX3N5c3RlbV9pZCBpbnRlbF9ub19vcHJlZ2lvbl92 YnRbXSA9IHsKPiAgCXsgfQo+ICB9Owo+ICAKPiAtc3RhdGljIGNvbnN0IHN0cnVjdCBiZGJfaGVh ZGVyICp2YWxpZGF0ZV92YnQoY29uc3Qgdm9pZCAqYmFzZSwgc2l6ZV90IHNpemUsCj4gLQkJCQkJ ICAgICBjb25zdCB2b2lkICpfdmJ0LAo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGJkYl9oZWFkZXIg KnZhbGlkYXRlX3ZidChjb25zdCB2b2lkIF9faW9tZW0gKl9iYXNlLAo+ICsJCQkJCSAgICAgc2l6 ZV90IHNpemUsCj4gKwkJCQkJICAgICBjb25zdCB2b2lkIF9faW9tZW0gKl92YnQsCj4gIAkJCQkJ ICAgICBjb25zdCBjaGFyICpzb3VyY2UpCj4gIHsKPiAtCWNvbnN0IHN0cnVjdCB2YnRfaGVhZGVy ICp2YnQgPSBfdmJ0Owo+IC0Jc2l6ZV90IG9mZnNldDsKPiArCS8qCj4gKwkgKiBUaGlzIGlzIHRo ZSBvbmUgcGxhY2Ugd2hlcmUgd2UgZXhwbGljaXRseSBkaXNjYXJkIHRoZSBhZGRyZXNzIHNwYWNl Cj4gKwkgKiAoX19pb21lbSkgb2YgdGhlIEJJT1MvVkJULiAoQW5kIHRoaXMgd2lsbCBjYXVzZSBh IHNwYXJzZSBjb21wbGFpbnQuKQo+ICsJICogRnJvbSBub3cgb24gZXZlcnl0aGluZyBpcyBiYXNl ZCBvbiAnYmFzZScsIGFuZCB0cmVhdGVkIGFzIHJlZ3VsYXIKPiArCSAqIG1lbW9yeS4KPiArCSAq Lwo+ICsJY29uc3Qgdm9pZCAqYmFzZSA9IChjb25zdCB2b2lkICopIF9iYXNlOwo+ICsJc2l6ZV90 IG9mZnNldCA9IF92YnQgLSBfYmFzZTsKPiArCWNvbnN0IHN0cnVjdCB2YnRfaGVhZGVyICp2YnQg PSBiYXNlICsgb2Zmc2V0Owo+ICAJY29uc3Qgc3RydWN0IGJkYl9oZWFkZXIgKmJkYjsKPiAgCj4g LQlvZmZzZXQgPSBfdmJ0IC0gYmFzZTsKPiAgCWlmIChvZmZzZXQgKyBzaXplb2Yoc3RydWN0IHZi dF9oZWFkZXIpID4gc2l6ZSkgewo+ICAJCURSTV9ERUJVR19EUklWRVIoIlZCVCBoZWFkZXIgaW5j b21wbGV0ZVxuIik7Cj4gIAkJcmV0dXJuIE5VTEw7Cj4gQEAgLTEyMzUsMTQgKzEyNDIsMTQgQEAg c3RhdGljIGNvbnN0IHN0cnVjdCBiZGJfaGVhZGVyICp2YWxpZGF0ZV92YnQoY29uc3Qgdm9pZCAq YmFzZSwgc2l6ZV90IHNpemUsCj4gIAlyZXR1cm4gYmRiOwo+ICB9Cj4gIAo+IC1zdGF0aWMgY29u c3Qgc3RydWN0IGJkYl9oZWFkZXIgKmZpbmRfdmJ0KHZvaWQgKmJpb3MsIHNpemVfdCBzaXplKQo+ ICtzdGF0aWMgY29uc3Qgc3RydWN0IGJkYl9oZWFkZXIgKmZpbmRfdmJ0KHZvaWQgX19pb21lbSAq Ymlvcywgc2l6ZV90IHNpemUpCj4gIHsKPiAgCWNvbnN0IHN0cnVjdCBiZGJfaGVhZGVyICpiZGIg PSBOVUxMOwo+ICAJc2l6ZV90IGk7Cj4gIAo+ICAJLyogU2NvdXIgbWVtb3J5IGxvb2tpbmcgZm9y IHRoZSBWQlQgc2lnbmF0dXJlLiAqLwo+ICAJZm9yIChpID0gMDsgaSArIDQgPCBzaXplOyBpKysp IHsKPiAtCQlpZiAobWVtY21wKGJpb3MgKyBpLCAiJFZCVCIsIDQpID09IDApIHsKPiArCQlpZiAo aW9yZWFkMzIoYmlvcyArIGkpID09ICooKGNvbnN0IHUzMiAqKSAiJFZCVCIpKSB7Cj4gIAkJCWJk YiA9IHZhbGlkYXRlX3ZidChiaW9zLCBzaXplLCBiaW9zICsgaSwgIlBDSSBST00iKTsKPiAgCQkJ YnJlYWs7Cj4gIAkJfQo+IC0tIAo+IDIuMS40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=