Received: from eggs.gnu.org ([2001:4830:134:3::10]:52757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv38f-0002jy-Nf for qemu-devel@nongnu.org; Wed, 20 May 2015 08:30:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv38Y-0002jn-MF for qemu-devel@nongnu.org; Wed, 20 May 2015 08:30:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv38Y-0002je-Gv for qemu-devel@nongnu.org; Wed, 20 May 2015 08:30:14 -0400 Date: Wed, 20 May 2015 09:30:11 -0300 From: Eduardo Habkost Message-ID: <20150520123011.GD28075@thinpad.lan.raisama.net> References: <555C5A29.8090106@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555C5A29.8090106@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Michal Privoznik , qemu-devel@nongnu.org, rth@twiddle.net On Wed, May 20, 2015 at 11:55:53AM +0200, Paolo Bonzini wrote: > On 20/05/2015 11:15, Michal Privoznik wrote: > > When going through code I realized, that the pc_init1() has this two > > arguments @pci_enabled and @kvmclock_enabled which despite used as > > booleans are of int type. > > > > Signed-off-by: Michal Privoznik > > Eduardo, do your patches to the PC machine types subsume this change? Yes, it replaces the int function arguments with bool globals. (Globals that will be eventually moved to PCMachineClass with the other 8 PC compat globals we have). -- Eduardo