From: Daniel Vetter Subject: Re: [PATCH] drm/i915/skl: don't fail colorkey + scaler request Date: Fri, 22 May 2015 08:29:28 +0200 Message-ID: <20150522062928.GR15256@phenom.ffwll.local> References: <1431991124-9034-1-git-send-email-chandra.konduru@intel.com> <20150521163644.GN18908@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTP id CE72F6E3B3 for ; Thu, 21 May 2015 23:27:02 -0700 (PDT) Received: by wghq2 with SMTP id q2so8037086wgh.1 for ; Thu, 21 May 2015 23:27:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150521163644.GN18908@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: bin.a.xu@intel.com, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMjEsIDIwMTUgYXQgMDc6MzY6NDRQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIE1vbiwgTWF5IDE4LCAyMDE1IGF0IDA0OjE4OjQ0UE0gLTA3MDAsIENoYW5k cmEgS29uZHVydSB3cm90ZToKPiA+IFRoZXJlIGlzIGEgbXBsYXllciB2aWRlbyBmYWlsdXJlIHJl cG9ydGVkIHdpdGggeHYuCj4gPiBUaGlzIGlzIGJlY2F1c2UgdGhlcmUgaXMgYSByZXF1ZXN0IHRv IGRvIGJvdGggcGxhbmUgc2NhbGluZwo+ID4gYW5kIGNvbG9ya2V5LiBCZWNhdXNlIHNrbCBodyBk b2Vzbid0IHN1cHBvcnQgcGxhbmUgc2NhbGluZwo+ID4gYW5kIGNvbG9ya2V5IGF0IHRoZSBzYW1l IHRpbWUsIHJlcXVlc3QgaXMgZmFpbGVkIHdoaWNoIGlzIGV4cGVjdGVkCj4gPiBiZWhhdmlvci4K PiA+IAo+ID4gVG8gbWFrZSB4diBvcGVyYXRlLCB0aGlzIHBhdGNoIGFsbG93cyBjb2xvcmtleSBj b250aW51ZSB0byB3b3JrCj4gPiB3aXRob3V0IHVzaW5nIHNjYWxlci4gVGhlbiBiZWhhdmlvciB3 b3VsZCBiZSBzaW1pbGFyIHRvIHBsYXRmb3Jtcwo+ID4gd2l0aG91dCBwbGFuZSBzY2FsZXIgc3Vw cG9ydC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQ2hhbmRyYSBLb25kdXJ1IDxjaGFuZHJhLmtv bmR1cnVAaW50ZWwuY29tPgo+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5v cmcvc2hvd19idWcuY2dpP2lkPTkwNDQ5Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgfCAgIDE0ICsrKysrKysrKy0tLS0tCj4gPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgICAzMSArKysrKysrKysrKysrKysrKysrKystLS0t LS0tLS0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlv bnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXgg N2FiNzVjMC4uZmM1Y2VmMCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gPiBAQCAtNDUwNSw5ICs0NTA1LDEwIEBAIHNrbF91cGRhdGVfc2NhbGVyX3VzZXJzKAo+ ID4gIAl9Cj4gPiAgCj4gPiAgCS8qIGNoZWNrIGNvbG9ya2V5ICovCj4gPiAtCWlmIChpbnRlbF9w bGFuZSAmJiBpbnRlbF9wbGFuZS0+Y2tleS5mbGFncyAhPSBJOTE1X1NFVF9DT0xPUktFWV9OT05F KSB7Cj4gPiAtCQlEUk1fREVCVUdfS01TKCJQTEFORTolZCBzY2FsaW5nIHdpdGggY29sb3Iga2V5 IG5vdCBhbGxvd2VkIiwKPiA+IC0JCQlpbnRlbF9wbGFuZS0+YmFzZS5iYXNlLmlkKTsKPiA+ICsJ aWYgKFdBUk5fT04oaW50ZWxfcGxhbmUgJiYKPiA+ICsJCWludGVsX3BsYW5lLT5ja2V5LmZsYWdz ICE9IEk5MTVfU0VUX0NPTE9SS0VZX05PTkUpKSB7Cj4gPiArCQlEUk1fREVCVUdfS01TKCJQTEFO RTolZCBzY2FsaW5nICV1eCV1LT4ldXgldSBub3QgYWxsb3dlZCB3aXRoIGNvbG9ya2V5IiwKPiA+ ICsJCQlpbnRlbF9wbGFuZS0+YmFzZS5iYXNlLmlkLCBzcmNfdywgc3JjX2gsIGRzdF93LCBkc3Rf aCk7Cj4gPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICAJfQo+ID4gIAo+ID4gQEAgLTEzMDQ5LDgg KzEzMDUwLDExIEBAIGludGVsX2NoZWNrX3ByaW1hcnlfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAq cGxhbmUsCj4gPiAgCQlpbnRlbF9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUtPmJhc2Uuc3Rh dGUsIGludGVsX2NydGMpIDogTlVMTDsKPiA+ICAKPiA+ICAJaWYgKElOVEVMX0lORk8oZGV2KS0+ Z2VuID49IDkpIHsKPiA+IC0JCW1pbl9zY2FsZSA9IDE7Cj4gPiAtCQltYXhfc2NhbGUgPSBza2xf bWF4X3NjYWxlKGludGVsX2NydGMsIGNydGNfc3RhdGUpOwo+ID4gKwkJLyogdXNlIHNjYWxlciB3 aGVuIGNvbG9ya2V5IGlzIG5vdCByZXF1aXJlZCAqLwo+ID4gKwkJaWYgKHRvX2ludGVsX3BsYW5l KHBsYW5lKS0+Y2tleS5mbGFncyA9PSBJOTE1X1NFVF9DT0xPUktFWV9OT05FKSB7Cj4gPiArCQkJ bWluX3NjYWxlID0gMTsKPiA+ICsJCQltYXhfc2NhbGUgPSBza2xfbWF4X3NjYWxlKGludGVsX2Ny dGMsIGNydGNfc3RhdGUpOwo+ID4gKwkJfQo+ID4gIAkJY2FuX3Bvc2l0aW9uID0gdHJ1ZTsKPiA+ ICAJfQo+ID4gIAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nw cml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+IGluZGV4IDE2 ZDBlNDguLjkwMDRlNDcgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9zcHJpdGUuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMK PiA+IEBAIC03NzUsNyArNzc1LDcgQEAgaW50ZWxfY2hlY2tfc3ByaXRlX3BsYW5lKHN0cnVjdCBk cm1fcGxhbmUgKnBsYW5lLAo+ID4gIAlzdHJ1Y3QgZHJtX3JlY3QgKmRzdCA9ICZzdGF0ZS0+ZHN0 Owo+ID4gIAljb25zdCBzdHJ1Y3QgZHJtX3JlY3QgKmNsaXAgPSAmc3RhdGUtPmNsaXA7Cj4gPiAg CWludCBoc2NhbGUsIHZzY2FsZTsKPiA+IC0JaW50IG1heF9zY2FsZSwgbWluX3NjYWxlOwo+ID4g KwlpbnQgbWF4X3NjYWxlLCBtaW5fc2NhbGUsIGNhbl9zY2FsZTsKPiAKPiBjYW5fc2NhbGUgb3Vn aHQgdG8gYmUgYm9vbC4gT3RoZXJ3aXNlIHRoaXMgbG9va3MgZ29vZC4KPiBTbyB3aXRoIHRoYXQg YmlrZXNoZWQgZG9uZSB0aGlzIGdldHM6CgpEb25lLiBBc2lkZSwgaW50ZWxfY2hlY2tfc3ByaXRl X3BsYW5lIGlzIGEgZ2lhbnQgZnVuY3Rpb24sIHNvbWUgZXh0cmFjdGlvbgpvZiBzdWItcGFydHMg YW5kIGhlbHBlcnMgKGxpa2UgY29tcHV0aW5nIGNhbl9zY2FsZSBhbmQgc3R1ZmYpIHdvdWxkIGJl Cmdvb2QuIEEgbG90IG9mIHRoZSBiaWcgbG9jYWwgdmFyaWFibGUgbGlzdCBjb3VsZCBlLmcuIGJl IG1vdmVkIGludG8KaW50ZWxfcGxhbmVfc3RhdGUgKGxpa2UgdGhlIGR5bmFtaWMgY2FuX3NjYWxl KSBhbmQgdGhlbiB3ZSBqdXN0IG5lZWQgdG8KcGFzcyBhcm91bmQgdGhlIHN0YXRlIHBvaW50ZXIg dG8gdGhlIHZhcmlvdXMgc3ViZnVuY3Rpb25zLgoKPiBSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClF1ZXVlZCBmb3IgLW5leHQsIHRo YW5rcyBmb3IgdGhlIHBhdGNoLgotRGFuaWVsCgo+IAo+IFBzLiBQbGVhc2UgdXNlIG15IEBsaW51 eC5pbnRlbC5jb20gYWRkcmVzcyB3aGVuIGNjOmluZyBtZSBvbiBwYXRjaGVzLgo+IEkgdHJ5IHRv IHNob3ZlbCBhbGwgcGF0Y2ggdHJhZmZpYyB0aHJvdWdoIHRoYXQgYW5kIHVzZSB0aGUgQGludGVs LmNvbQo+IGFkZHJlc3MgZm9yIG90aGVyIHN0dWZmLgo+IAo+ID4gIAlpbnQgcGl4ZWxfc2l6ZTsK PiA+ICAJaW50IHJldDsKPiA+ICAKPiA+IEBAIC04MDAsMTggKzgwMCwyOSBAQCBpbnRlbF9jaGVj a19zcHJpdGVfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPiAgCQlyZXR1cm4gLUVJ TlZBTDsKPiA+ICAJfQo+ID4gIAo+ID4gKwkvKiBzZXR1cCBjYW5fc2NhbGUsIG1pbl9zY2FsZSwg bWF4X3NjYWxlICovCj4gPiArCWlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA5KSB7Cj4gPiAr CQkvKiB1c2Ugc2NhbGVyIHdoZW4gY29sb3JrZXkgaXMgbm90IHJlcXVpcmVkICovCj4gPiArCQlp ZiAoaW50ZWxfcGxhbmUtPmNrZXkuZmxhZ3MgPT0gSTkxNV9TRVRfQ09MT1JLRVlfTk9ORSkgewo+ ID4gKwkJCWNhbl9zY2FsZSA9IDE7Cj4gPiArCQkJbWluX3NjYWxlID0gMTsKPiA+ICsJCQltYXhf c2NhbGUgPSBza2xfbWF4X3NjYWxlKGludGVsX2NydGMsIGNydGNfc3RhdGUpOwo+ID4gKwkJfSBl bHNlIHsKPiA+ICsJCQljYW5fc2NhbGUgPSAwOwo+ID4gKwkJCW1pbl9zY2FsZSA9IERSTV9QTEFO RV9IRUxQRVJfTk9fU0NBTElORzsKPiA+ICsJCQltYXhfc2NhbGUgPSBEUk1fUExBTkVfSEVMUEVS X05PX1NDQUxJTkc7Cj4gPiArCQl9Cj4gPiArCX0gZWxzZSB7Cj4gPiArCQljYW5fc2NhbGUgPSBp bnRlbF9wbGFuZS0+Y2FuX3NjYWxlOwo+ID4gKwkJbWF4X3NjYWxlID0gaW50ZWxfcGxhbmUtPm1h eF9kb3duc2NhbGUgPDwgMTY7Cj4gPiArCQltaW5fc2NhbGUgPSBpbnRlbF9wbGFuZS0+Y2FuX3Nj YWxlID8gMSA6ICgxIDw8IDE2KTsKPiA+ICsJfQo+ID4gKwo+ID4gIAkvKgo+ID4gIAkgKiBGSVhN RSB0aGUgZm9sbG93aW5nIGNvZGUgZG9lcyBhIGJ1bmNoIG9mIGZ1enp5IGFkanVzdG1lbnRzIHRv IHRoZQo+ID4gIAkgKiBjb29yZGluYXRlcyBhbmQgc2l6ZXMuIFdlIHByb2JhYmx5IG5lZWQgc29t ZSB3YXkgdG8gZGVjaWRlIHdoZXRoZXIKPiA+ICAJICogbW9yZSBzdHJpY3QgY2hlY2tpbmcgc2hv dWxkIGJlIGRvbmUgaW5zdGVhZC4KPiA+ICAJICovCj4gPiAtCW1heF9zY2FsZSA9IGludGVsX3Bs YW5lLT5tYXhfZG93bnNjYWxlIDw8IDE2Owo+ID4gLQltaW5fc2NhbGUgPSBpbnRlbF9wbGFuZS0+ Y2FuX3NjYWxlID8gMSA6ICgxIDw8IDE2KTsKPiA+IC0KPiA+IC0JaWYgKElOVEVMX0lORk8oZGV2 KS0+Z2VuID49IDkpIHsKPiA+IC0JCW1pbl9zY2FsZSA9IDE7Cj4gPiAtCQltYXhfc2NhbGUgPSBz a2xfbWF4X3NjYWxlKGludGVsX2NydGMsIGNydGNfc3RhdGUpOwo+ID4gLQl9Cj4gPiAgCj4gPiAg CWRybV9yZWN0X3JvdGF0ZShzcmMsIGZiLT53aWR0aCA8PCAxNiwgZmItPmhlaWdodCA8PCAxNiwK PiA+ICAJCQlzdGF0ZS0+YmFzZS5yb3RhdGlvbik7Cj4gPiBAQCAtODgyLDcgKzg5Myw3IEBAIGlu dGVsX2NoZWNrX3Nwcml0ZV9wbGFuZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAJCQkg KiBNdXN0IGtlZXAgc3JjIGFuZCBkc3QgdGhlCj4gPiAgCQkJICogc2FtZSBpZiB3ZSBjYW4ndCBz Y2FsZS4KPiA+ICAJCQkgKi8KPiA+IC0JCQlpZiAoIWludGVsX3BsYW5lLT5jYW5fc2NhbGUpCj4g PiArCQkJaWYgKCFjYW5fc2NhbGUpCj4gPiAgCQkJCWNydGNfdyAmPSB+MTsKPiA+ICAKPiA+ICAJ CQlpZiAoY3J0Y193ID09IDApCj4gPiBAQCAtODk0LDcgKzkwNSw3IEBAIGludGVsX2NoZWNrX3Nw cml0ZV9wbGFuZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAJaWYgKHN0YXRlLT52aXNp YmxlICYmIChzcmNfdyAhPSBjcnRjX3cgfHwgc3JjX2ggIT0gY3J0Y19oKSkgewo+ID4gIAkJdW5z aWduZWQgaW50IHdpZHRoX2J5dGVzOwo+ID4gIAo+ID4gLQkJV0FSTl9PTighaW50ZWxfcGxhbmUt PmNhbl9zY2FsZSk7Cj4gPiArCQlXQVJOX09OKCFjYW5fc2NhbGUpOwo+ID4gIAo+ID4gIAkJLyog RklYTUUgaW50ZXJsYWNpbmcgbWluIGhlaWdodCBpcyA2ICovCj4gPiAgCj4gPiAtLSAKPiA+IDEu Ny45LjUKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngKPiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==