From: Daniel Vetter Subject: Re: [PATCH 5/7] drm/i915: abstract port hotplug long pulse detection more Date: Wed, 27 May 2015 14:41:29 +0200 Message-ID: <20150527124129.GO8341@phenom.ffwll.local> References: <6be56c568ce8498fb2dc3cc86fc516b185d8ec20.1432728144.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by gabe.freedesktop.org (Postfix) with ESMTP id AF7A86E318 for ; Wed, 27 May 2015 05:39:02 -0700 (PDT) Received: by wgbgq6 with SMTP id gq6so8270601wgb.3 for ; Wed, 27 May 2015 05:39:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6be56c568ce8498fb2dc3cc86fc516b185d8ec20.1432728144.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMjcsIDIwMTUgYXQgMDM6MDM6NDNQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gQWRkIHBsYXRmb3JtIHNwZWNpZmljIGZ1bmN0aW9ucyB0byBkZWNpcGhlciB0aGUgcmVn aXN0ZXIgY29udGVudHMKPiBpbnN0ZWFkIG9mIGp1c3QgcmV0dXJuaW5nIHRoZSBzaGlmdCB2YWx1 ZS4gVXNlIG1hY3JvcyBpbnN0ZWFkIG9mIG1hZ2ljCj4gbnVtYmVycyB0byBsb29rIGF0IHRoZSBy ZWdpc3RlciBiaXRzLgo+IAo+IEFzIGEgc2lkZSBlZmZlY3QsIGlmIGFuIHVuc3VwcG9ydGVkIHBv cnQgaXMgcGFzc2VkLCBjb25zaXN0ZW50bHkgcmV0dXJuCj4gZmFsc2UgKGluZGljYXRpbmcgc2hv cnQgaG90cGx1ZykgaW5zdGVhZCBvZiByZXR1cm5pbmcgLTEgd2hpY2ggd2FzIHVzZWQKPiBmb3Ig c2hpZnRpbmcuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGlu dGVsLmNvbT4KCk5vdCBjb252aW5jZWQuIEN1cnJlbnRseSB3ZSBoYXZlIGEgc3RyYW5nZSBtaXgg b2YgcGFzc2luZyByZWdpc3RlcitkZWNvZGUKdGFibGVzIHRvIGludGVsX2hwZF9pcnFfaGFuZGxl ciBmb3IgaHBkcyBhbmQgZGVjb2RpbmcgdGhlIGxvbmcgdnMuIHNob3J0CnN0dWZmIGludGVybmFs bHkuIFRoYXQgYWxyZWFkeSBkb2Vzbid0IHdvcmsgd2l0aCB0aGluZ3MgbGlrZSBwb3J0IEEgd2hp Y2gKdGVuZHMgdG8gYmUgKGF0IGxlYXN0IG9uIHNvbWUgcGxhdGZvcm1zKSBpbiBhIHRvdGFsbHkg ZGlmZmVyZW50IHJlZ2lzdGVyLgpBbmQgaXQgc3BsaXRzIHVwIHRoZSBkZWZpbml0aW9ucyBmb3Ig dGhlIGhwZCBiaXRzIGZyb20gdGhlIGxvbmcgdnMuIHNob3J0CmJpdHMgdW5lY2Vzc2FyaWx5LiBJ IGV2ZW4gc3VzcGVjdCB3ZSBtaWdodCBoYXZlIHNvbWUgYnVncyB3aXRoIGNvcnJlY3RseQpjbGVh cmluZyB0aG9zZSBhZGRpdGlvbmFsIHN0YXR1cyByZWdpc3RlcnMgc29tZXRpbWVzLgoKSW1vIGlm IHdlIGNsZWFuIHRoaXMgdXAgd2Ugc2hvdWxkIHB1bGwgaXQgYWxsIHRvZ2V0aGVyIGludG8gb25l IHBsYWNlLAppLmUuIHBsYXRmb3JtIGNvZGUgZG9lcyBhbGwgdGhlIHJlZ2lzdGVyIHJlYWRpbmcm ZGVjb2RpbmcgYW5kIHBhc3NlcwpkZWNvZGUgYml0bWFza3MgZG93biB0byBnZW5lcmljIGhhbmRs ZXJzLiBPciBzb21ldGhpbmcgYWxvbmcgdGhvc2UgbGluZXMKYXQgbGVhc3QuCi1EYW5pZWwKCj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgfCA0MCArKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRp b25zKCspLCAyNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBpbmRl eCA5MWNiMGI2ZWM0N2IuLjkwY2MyNDg2OTFkNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEu Ywo+IEBAIC0xMzc1LDM1ICsxMzc1LDMxIEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBnZW44X2d0X2ly cV9oYW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgI2RlZmluZSBI UERfU1RPUk1fREVURUNUX1BFUklPRCAxMDAwCj4gICNkZWZpbmUgSFBEX1NUT1JNX1RIUkVTSE9M RCA1Cj4gIAo+IC1zdGF0aWMgaW50IHBjaF9wb3J0X3RvX2hvdHBsdWdfc2hpZnQoZW51bSBwb3J0 IHBvcnQpCj4gK3N0YXRpYyBib29sIHBjaF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QoZW51bSBw b3J0IHBvcnQsIHUzMiB2YWwpCj4gIHsKPiAgCXN3aXRjaCAocG9ydCkgewo+IC0JY2FzZSBQT1JU X0E6Cj4gLQljYXNlIFBPUlRfRToKPiAtCWRlZmF1bHQ6Cj4gLQkJcmV0dXJuIC0xOwo+ICAJY2Fz ZSBQT1JUX0I6Cj4gLQkJcmV0dXJuIDA7Cj4gKwkJcmV0dXJuIHZhbCAmIFBPUlRCX0hPVFBMVUdf TE9OR19ERVRFQ1Q7Cj4gIAljYXNlIFBPUlRfQzoKPiAtCQlyZXR1cm4gODsKPiArCQlyZXR1cm4g dmFsICYgUE9SVENfSE9UUExVR19MT05HX0RFVEVDVDsKPiAgCWNhc2UgUE9SVF9EOgo+IC0JCXJl dHVybiAxNjsKPiArCQlyZXR1cm4gdmFsICYgUE9SVERfSE9UUExVR19MT05HX0RFVEVDVDsKPiAr CWRlZmF1bHQ6Cj4gKwkJcmV0dXJuIGZhbHNlOwo+ICAJfQo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50 IGk5MTVfcG9ydF90b19ob3RwbHVnX3NoaWZ0KGVudW0gcG9ydCBwb3J0KQo+ICtzdGF0aWMgYm9v bCBpOTE1X3BvcnRfaG90cGx1Z19sb25nX2RldGVjdChlbnVtIHBvcnQgcG9ydCwgdTMyIHZhbCkK PiAgewo+ICAJc3dpdGNoIChwb3J0KSB7Cj4gLQljYXNlIFBPUlRfQToKPiAtCWNhc2UgUE9SVF9F Ogo+IC0JZGVmYXVsdDoKPiAtCQlyZXR1cm4gLTE7Cj4gIAljYXNlIFBPUlRfQjoKPiAtCQlyZXR1 cm4gMTc7Cj4gKwkJcmV0dXJuIHZhbCAmIFBPUlRCX0hPVFBMVUdfSU5UX0xPTkdfUFVMU0U7Cj4g IAljYXNlIFBPUlRfQzoKPiAtCQlyZXR1cm4gMTk7Cj4gKwkJcmV0dXJuIHZhbCAmIFBPUlRDX0hP VFBMVUdfSU5UX0xPTkdfUFVMU0U7Cj4gIAljYXNlIFBPUlRfRDoKPiAtCQlyZXR1cm4gMjE7Cj4g KwkJcmV0dXJuIHZhbCAmIFBPUlREX0hPVFBMVUdfSU5UX0xPTkdfUFVMU0U7Cj4gKwlkZWZhdWx0 Ogo+ICsJCXJldHVybiBmYWxzZTsKPiAgCX0KPiAgfQo+ICAKPiBAQCAtMTQzMSw3ICsxNDI3LDYg QEAgc3RhdGljIHZvaWQgaW50ZWxfaHBkX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsCj4gIAllbnVtIHBvcnQgcG9ydDsKPiAgCWJvb2wgc3Rvcm1fZGV0ZWN0ZWQgPSBmYWxzZTsK PiAgCWJvb2wgcXVldWVfZGlnID0gZmFsc2UsIHF1ZXVlX2hwID0gZmFsc2U7Cj4gLQl1MzIgZGln X3NoaWZ0Owo+ICAJdTMyIGRpZ19wb3J0X21hc2sgPSAwOwo+ICAKPiAgCWlmICghaG90cGx1Z190 cmlnZ2VyKQo+IEBAIC0xNDUxLDEzICsxNDQ2LDEwIEBAIHN0YXRpYyB2b2lkIGludGVsX2hwZF9p cnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCWlmICghcG9ydCB8fCAhZGV2 X3ByaXYtPmhvdHBsdWcuaXJxX3BvcnRbcG9ydF0pCj4gIAkJCWNvbnRpbnVlOwo+ICAKPiAtCQlp ZiAoIUhBU19HTUNIX0RJU1BMQVkoZGV2X3ByaXYpKSB7Cj4gLQkJCWRpZ19zaGlmdCA9IHBjaF9w b3J0X3RvX2hvdHBsdWdfc2hpZnQocG9ydCk7Cj4gLQkJCWxvbmdfaHBkID0gKGRpZ19ob3RwbHVn X3JlZyA+PiBkaWdfc2hpZnQpICYgUE9SVEJfSE9UUExVR19MT05HX0RFVEVDVDsKPiAtCQl9IGVs c2Ugewo+IC0JCQlkaWdfc2hpZnQgPSBpOTE1X3BvcnRfdG9faG90cGx1Z19zaGlmdChwb3J0KTsK PiAtCQkJbG9uZ19ocGQgPSAoaG90cGx1Z190cmlnZ2VyID4+IGRpZ19zaGlmdCkgJiBQT1JUQl9I T1RQTFVHX0xPTkdfREVURUNUOwo+IC0JCX0KPiArCQlpZiAoSEFTX0dNQ0hfRElTUExBWShkZXZf cHJpdikpCj4gKwkJCWxvbmdfaHBkID0gaTkxNV9wb3J0X2hvdHBsdWdfbG9uZ19kZXRlY3QocG9y dCwgaG90cGx1Z190cmlnZ2VyKTsKPiArCQllbHNlCj4gKwkJCWxvbmdfaHBkID0gcGNoX3BvcnRf aG90cGx1Z19sb25nX2RldGVjdChwb3J0LCBkaWdfaG90cGx1Z19yZWcpOwo+ICAKPiAgCQlEUk1f REVCVUdfRFJJVkVSKCJkaWdpdGFsIGhwZCBwb3J0ICVjIC0gJXNcbiIsIHBvcnRfbmFtZShwb3J0 KSwKPiAgCQkJCSBsb25nX2hwZCA/ICJsb25nIiA6ICJzaG9ydCIpOwo+IC0tIAo+IDIuMS40Cj4g Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRl bC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=