From: Daniel Vetter Subject: Re: [PATCH 5/7] drm/i915: abstract port hotplug long pulse detection more Date: Wed, 27 May 2015 14:42:13 +0200 Message-ID: <20150527124213.GP8341@phenom.ffwll.local> References: <6be56c568ce8498fb2dc3cc86fc516b185d8ec20.1432728144.git.jani.nikula@intel.com> <20150527124129.GO8341@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTP id C7E4D7A10A for ; Wed, 27 May 2015 05:39:45 -0700 (PDT) Received: by wicmc15 with SMTP id mc15so92429329wic.1 for ; Wed, 27 May 2015 05:39:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150527124129.GO8341@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMjcsIDIwMTUgYXQgMDI6NDE6MjlQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIE1heSAyNywgMjAxNSBhdCAwMzowMzo0M1BNICswMzAwLCBKYW5pIE5p a3VsYSB3cm90ZToKPiA+IEFkZCBwbGF0Zm9ybSBzcGVjaWZpYyBmdW5jdGlvbnMgdG8gZGVjaXBo ZXIgdGhlIHJlZ2lzdGVyIGNvbnRlbnRzCj4gPiBpbnN0ZWFkIG9mIGp1c3QgcmV0dXJuaW5nIHRo ZSBzaGlmdCB2YWx1ZS4gVXNlIG1hY3JvcyBpbnN0ZWFkIG9mIG1hZ2ljCj4gPiBudW1iZXJzIHRv IGxvb2sgYXQgdGhlIHJlZ2lzdGVyIGJpdHMuCj4gPiAKPiA+IEFzIGEgc2lkZSBlZmZlY3QsIGlm IGFuIHVuc3VwcG9ydGVkIHBvcnQgaXMgcGFzc2VkLCBjb25zaXN0ZW50bHkgcmV0dXJuCj4gPiBm YWxzZSAoaW5kaWNhdGluZyBzaG9ydCBob3RwbHVnKSBpbnN0ZWFkIG9mIHJldHVybmluZyAtMSB3 aGljaCB3YXMgdXNlZAo+ID4gZm9yIHNoaWZ0aW5nLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBK YW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IAo+IE5vdCBjb252aW5jZWQuIEN1 cnJlbnRseSB3ZSBoYXZlIGEgc3RyYW5nZSBtaXggb2YgcGFzc2luZyByZWdpc3RlcitkZWNvZGUK PiB0YWJsZXMgdG8gaW50ZWxfaHBkX2lycV9oYW5kbGVyIGZvciBocGRzIGFuZCBkZWNvZGluZyB0 aGUgbG9uZyB2cy4gc2hvcnQKPiBzdHVmZiBpbnRlcm5hbGx5LiBUaGF0IGFscmVhZHkgZG9lc24n dCB3b3JrIHdpdGggdGhpbmdzIGxpa2UgcG9ydCBBIHdoaWNoCj4gdGVuZHMgdG8gYmUgKGF0IGxl YXN0IG9uIHNvbWUgcGxhdGZvcm1zKSBpbiBhIHRvdGFsbHkgZGlmZmVyZW50IHJlZ2lzdGVyLgo+ IEFuZCBpdCBzcGxpdHMgdXAgdGhlIGRlZmluaXRpb25zIGZvciB0aGUgaHBkIGJpdHMgZnJvbSB0 aGUgbG9uZyB2cy4gc2hvcnQKPiBiaXRzIHVuZWNlc3NhcmlseS4gSSBldmVuIHN1c3BlY3Qgd2Ug bWlnaHQgaGF2ZSBzb21lIGJ1Z3Mgd2l0aCBjb3JyZWN0bHkKPiBjbGVhcmluZyB0aG9zZSBhZGRp dGlvbmFsIHN0YXR1cyByZWdpc3RlcnMgc29tZXRpbWVzLgo+IAo+IEltbyBpZiB3ZSBjbGVhbiB0 aGlzIHVwIHdlIHNob3VsZCBwdWxsIGl0IGFsbCB0b2dldGhlciBpbnRvIG9uZSBwbGFjZSwKPiBp LmUuIHBsYXRmb3JtIGNvZGUgZG9lcyBhbGwgdGhlIHJlZ2lzdGVyIHJlYWRpbmcmZGVjb2Rpbmcg YW5kIHBhc3Nlcwo+IGRlY29kZSBiaXRtYXNrcyBkb3duIHRvIGdlbmVyaWMgaGFuZGxlcnMuIE9y IHNvbWV0aGluZyBhbG9uZyB0aG9zZSBsaW5lcwo+IGF0IGxlYXN0LgoKRm9yZ290IHRvIGFkZDog TWVyZ2VkIGFsbCB0aGUgb3RoZXIgcGF0Y2hlcyB0byBkaW5xLCB0aGFua3MuCi1EYW5pZWwKCj4g LURhbmllbAo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8 IDQwICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9pcnEuYwo+ID4gaW5kZXggOTFjYjBiNmVjNDdiLi45MGNjMjQ4NjkxZDcgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiBAQCAtMTM3NSwzNSArMTM3NSwzMSBA QCBzdGF0aWMgaXJxcmV0dXJuX3QgZ2VuOF9ndF9pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgI2RlZmluZSBIUERfU1RPUk1fREVURUNUX1BFUklPRCAx MDAwCj4gPiAgI2RlZmluZSBIUERfU1RPUk1fVEhSRVNIT0xEIDUKPiA+ICAKPiA+IC1zdGF0aWMg aW50IHBjaF9wb3J0X3RvX2hvdHBsdWdfc2hpZnQoZW51bSBwb3J0IHBvcnQpCj4gPiArc3RhdGlj IGJvb2wgcGNoX3BvcnRfaG90cGx1Z19sb25nX2RldGVjdChlbnVtIHBvcnQgcG9ydCwgdTMyIHZh bCkKPiA+ICB7Cj4gPiAgCXN3aXRjaCAocG9ydCkgewo+ID4gLQljYXNlIFBPUlRfQToKPiA+IC0J Y2FzZSBQT1JUX0U6Cj4gPiAtCWRlZmF1bHQ6Cj4gPiAtCQlyZXR1cm4gLTE7Cj4gPiAgCWNhc2Ug UE9SVF9COgo+ID4gLQkJcmV0dXJuIDA7Cj4gPiArCQlyZXR1cm4gdmFsICYgUE9SVEJfSE9UUExV R19MT05HX0RFVEVDVDsKPiA+ICAJY2FzZSBQT1JUX0M6Cj4gPiAtCQlyZXR1cm4gODsKPiA+ICsJ CXJldHVybiB2YWwgJiBQT1JUQ19IT1RQTFVHX0xPTkdfREVURUNUOwo+ID4gIAljYXNlIFBPUlRf RDoKPiA+IC0JCXJldHVybiAxNjsKPiA+ICsJCXJldHVybiB2YWwgJiBQT1JURF9IT1RQTFVHX0xP TkdfREVURUNUOwo+ID4gKwlkZWZhdWx0Ogo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gIAl9Cj4g PiAgfQo+ID4gIAo+ID4gLXN0YXRpYyBpbnQgaTkxNV9wb3J0X3RvX2hvdHBsdWdfc2hpZnQoZW51 bSBwb3J0IHBvcnQpCj4gPiArc3RhdGljIGJvb2wgaTkxNV9wb3J0X2hvdHBsdWdfbG9uZ19kZXRl Y3QoZW51bSBwb3J0IHBvcnQsIHUzMiB2YWwpCj4gPiAgewo+ID4gIAlzd2l0Y2ggKHBvcnQpIHsK PiA+IC0JY2FzZSBQT1JUX0E6Cj4gPiAtCWNhc2UgUE9SVF9FOgo+ID4gLQlkZWZhdWx0Ogo+ID4g LQkJcmV0dXJuIC0xOwo+ID4gIAljYXNlIFBPUlRfQjoKPiA+IC0JCXJldHVybiAxNzsKPiA+ICsJ CXJldHVybiB2YWwgJiBQT1JUQl9IT1RQTFVHX0lOVF9MT05HX1BVTFNFOwo+ID4gIAljYXNlIFBP UlRfQzoKPiA+IC0JCXJldHVybiAxOTsKPiA+ICsJCXJldHVybiB2YWwgJiBQT1JUQ19IT1RQTFVH X0lOVF9MT05HX1BVTFNFOwo+ID4gIAljYXNlIFBPUlRfRDoKPiA+IC0JCXJldHVybiAyMTsKPiA+ ICsJCXJldHVybiB2YWwgJiBQT1JURF9IT1RQTFVHX0lOVF9MT05HX1BVTFNFOwo+ID4gKwlkZWZh dWx0Ogo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gIAl9Cj4gPiAgfQo+ID4gIAo+ID4gQEAgLTE0 MzEsNyArMTQyNyw2IEBAIHN0YXRpYyB2b2lkIGludGVsX2hwZF9pcnFfaGFuZGxlcihzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LAo+ID4gIAllbnVtIHBvcnQgcG9ydDsKPiA+ICAJYm9vbCBzdG9ybV9k ZXRlY3RlZCA9IGZhbHNlOwo+ID4gIAlib29sIHF1ZXVlX2RpZyA9IGZhbHNlLCBxdWV1ZV9ocCA9 IGZhbHNlOwo+ID4gLQl1MzIgZGlnX3NoaWZ0Owo+ID4gIAl1MzIgZGlnX3BvcnRfbWFzayA9IDA7 Cj4gPiAgCj4gPiAgCWlmICghaG90cGx1Z190cmlnZ2VyKQo+ID4gQEAgLTE0NTEsMTMgKzE0NDYs MTAgQEAgc3RhdGljIHZvaWQgaW50ZWxfaHBkX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCj4gPiAgCQlpZiAoIXBvcnQgfHwgIWRldl9wcml2LT5ob3RwbHVnLmlycV9wb3J0W3Bv cnRdKQo+ID4gIAkJCWNvbnRpbnVlOwo+ID4gIAo+ID4gLQkJaWYgKCFIQVNfR01DSF9ESVNQTEFZ KGRldl9wcml2KSkgewo+ID4gLQkJCWRpZ19zaGlmdCA9IHBjaF9wb3J0X3RvX2hvdHBsdWdfc2hp ZnQocG9ydCk7Cj4gPiAtCQkJbG9uZ19ocGQgPSAoZGlnX2hvdHBsdWdfcmVnID4+IGRpZ19zaGlm dCkgJiBQT1JUQl9IT1RQTFVHX0xPTkdfREVURUNUOwo+ID4gLQkJfSBlbHNlIHsKPiA+IC0JCQlk aWdfc2hpZnQgPSBpOTE1X3BvcnRfdG9faG90cGx1Z19zaGlmdChwb3J0KTsKPiA+IC0JCQlsb25n X2hwZCA9IChob3RwbHVnX3RyaWdnZXIgPj4gZGlnX3NoaWZ0KSAmIFBPUlRCX0hPVFBMVUdfTE9O R19ERVRFQ1Q7Cj4gPiAtCQl9Cj4gPiArCQlpZiAoSEFTX0dNQ0hfRElTUExBWShkZXZfcHJpdikp Cj4gPiArCQkJbG9uZ19ocGQgPSBpOTE1X3BvcnRfaG90cGx1Z19sb25nX2RldGVjdChwb3J0LCBo b3RwbHVnX3RyaWdnZXIpOwo+ID4gKwkJZWxzZQo+ID4gKwkJCWxvbmdfaHBkID0gcGNoX3BvcnRf aG90cGx1Z19sb25nX2RldGVjdChwb3J0LCBkaWdfaG90cGx1Z19yZWcpOwo+ID4gIAo+ID4gIAkJ RFJNX0RFQlVHX0RSSVZFUigiZGlnaXRhbCBocGQgcG9ydCAlYyAtICVzXG4iLCBwb3J0X25hbWUo cG9ydCksCj4gPiAgCQkJCSBsb25nX2hwZCA/ICJsb25nIiA6ICJzaG9ydCIpOwo+ID4gLS0gCj4g PiAyLjEuNAo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==