From: Daniel Vetter Subject: Re: [PATCH] drm/i915: abstract hpd irq storm detection Date: Fri, 29 May 2015 19:24:31 +0200 Message-ID: <20150529172431.GX8341@phenom.ffwll.local> References: <1432905277-24635-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 6177B6EE15 for ; Fri, 29 May 2015 10:22:02 -0700 (PDT) Received: by wicmx19 with SMTP id mx19so24189707wic.0 for ; Fri, 29 May 2015 10:22:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Jani Nikula , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXkgMjksIDIwMTUgYXQgMTE6MDQ6NTlBTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IDIwMTUtMDUtMjkgMTA6MTQgR01ULTAzOjAwIEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs YUBpbnRlbC5jb20+Ogo+ID4gU2ltcGxpZnkgaW50ZWxfaHBkX2lycV9oYW5kbGVyKCkgYnkgZXh0 cmFjdGluZyBIUEQgaXJxIHN0b3JtIGRldGVjdGlvbgo+ID4gdG8gYSBzZXBhcmF0ZSBmdW5jdGlv bi4KPiAKPiBNdWNoIGJldHRlciEKPiAKPiBJJ2QgcHJvYmFibHkgYWRkIGEgdmVyYiB0byB0aGUg ZnVuY3Rpb24gbmFtZSwgYW5kIHRyeSB0byBkbyBzb21ldGhpbmcKPiB0byByZW1vdmUgdGhlIGRl YnVnIG1lc3NhZ2VzIGZyb20gdGhlICJpZiIgc3RhdGVtZW50Lgo+IAo+IFJldmlld2VkLWJ5OiBQ YXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KClF1ZXVlZCBmb3IgLW5leHQs IHRoYW5rcyBmb3IgdGhlIHBhdGNoLgotRGFuaWVsCgo+IAo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgMTMg ZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiBpbmRleCBlNDI2 MGIwOTI0ZjEuLmViNTJhMDM5ZDYyOCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfaXJxLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMK PiA+IEBAIC0xMzc1LDYgKzEzNzUsNDUgQEAgc3RhdGljIGlycXJldHVybl90IGdlbjhfZ3RfaXJx X2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gICNkZWZpbmUg SFBEX1NUT1JNX0RFVEVDVF9QRVJJT0QgMTAwMAo+ID4gICNkZWZpbmUgSFBEX1NUT1JNX1RIUkVT SE9MRCA1Cj4gPgo+ID4gKy8qKgo+ID4gKyAqIGludGVsX2hwZF9pcnFfc3Rvcm0gLSBnYXRoZXIg c3RhdHMgYW5kIGRldGVjdCBIUEQgaXJxIHN0b3JtIG9uIGEgcGluCj4gPiArICogQGRldl9wcml2 OiBwcml2YXRlIGRyaXZlciBkYXRhIHBvaW50ZXIKPiA+ICsgKiBAcGluOiB0aGUgcGluIHRvIGdh dGhlciBzdGF0cyBvbgo+ID4gKyAqCj4gPiArICogR2F0aGVyIHN0YXRzIGFib3V0IEhQRCBpcnFz IGZyb20gdGhlIHNwZWNpZmllZCBAcGluLCBhbmQgZGV0ZWN0IGlycQo+ID4gKyAqIHN0b3Jtcy4g T25seSB0aGUgcGluIHNwZWNpZmljIHN0YXRzIGFuZCBzdGF0ZSBhcmUgY2hhbmdlZCwgdGhlIGNh bGxlciBpcwo+ID4gKyAqIHJlc3BvbnNpYmxlIGZvciBmdXJ0aGVyIGFjdGlvbi4KPiA+ICsgKgo+ ID4gKyAqIEBIUERfU1RPUk1fVEhSRVNIT0xEIGlycXMgYXJlIGFsbG93ZWQgd2l0aGluIEBIUERf U1RPUk1fREVURUNUX1BFUklPRCBtcywKPiA+ICsgKiBvdGhlcndpc2UgaXQncyBjb25zaWRlcmVk IGFuIGlycSBzdG9ybSwgYW5kIHRoZSBpcnEgc3RhdGUgaXMgc2V0IHRvCj4gPiArICogQEhQRF9N QVJLX0RJU0FCTEVELgo+ID4gKyAqCj4gPiArICogUmV0dXJuIHRydWUgaWYgYW4gaXJxIHN0b3Jt IHdhcyBkZXRlY3RlZCBvbiBAcGluLgo+ID4gKyAqLwo+ID4gK3N0YXRpYyBib29sIGludGVsX2hw ZF9pcnFfc3Rvcm0oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBlbnVtIGhwZF9waW4gcGluKQo+ID4gK3sKPiA+ICsg ICAgICAgdW5zaWduZWQgbG9uZyBzdGFydCA9IGRldl9wcml2LT5ob3RwbHVnLnN0YXRzW3Bpbl0u bGFzdF9qaWZmaWVzOwo+ID4gKyAgICAgICB1bnNpZ25lZCBsb25nIGVuZCA9IHN0YXJ0ICsgbXNl Y3NfdG9famlmZmllcyhIUERfU1RPUk1fREVURUNUX1BFUklPRCk7Cj4gPiArICAgICAgIGJvb2wg c3Rvcm0gPSBmYWxzZTsKPiA+ICsKPiA+ICsgICAgICAgaWYgKCF0aW1lX2luX3JhbmdlKGppZmZp ZXMsIHN0YXJ0LCBlbmQpKSB7Cj4gPiArICAgICAgICAgICAgICAgZGV2X3ByaXYtPmhvdHBsdWcu c3RhdHNbcGluXS5sYXN0X2ppZmZpZXMgPSBqaWZmaWVzOwo+ID4gKyAgICAgICAgICAgICAgIGRl dl9wcml2LT5ob3RwbHVnLnN0YXRzW3Bpbl0uY291bnQgPSAwOwo+ID4gKyAgICAgICAgICAgICAg IERSTV9ERUJVR19LTVMoIlJlY2VpdmVkIEhQRCBpbnRlcnJ1cHQgb24gUElOICVkIC0gY250OiAw XG4iLCBwaW4pOwo+ID4gKyAgICAgICB9IGVsc2UgaWYgKGRldl9wcml2LT5ob3RwbHVnLnN0YXRz W3Bpbl0uY291bnQgPiBIUERfU1RPUk1fVEhSRVNIT0xEKSB7Cj4gPiArICAgICAgICAgICAgICAg ZGV2X3ByaXYtPmhvdHBsdWcuc3RhdHNbcGluXS5zdGF0ZSA9IEhQRF9NQVJLX0RJU0FCTEVEOwo+ ID4gKyAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoIkhQRCBpbnRlcnJ1cHQgc3Rvcm0gZGV0 ZWN0ZWQgb24gUElOICVkXG4iLCBwaW4pOwo+ID4gKyAgICAgICAgICAgICAgIHN0b3JtID0gdHJ1 ZTsKPiA+ICsgICAgICAgfSBlbHNlIHsKPiA+ICsgICAgICAgICAgICAgICBkZXZfcHJpdi0+aG90 cGx1Zy5zdGF0c1twaW5dLmNvdW50Kys7Cj4gPiArICAgICAgICAgICAgICAgRFJNX0RFQlVHX0tN UygiUmVjZWl2ZWQgSFBEIGludGVycnVwdCBvbiBQSU4gJWQgLSBjbnQ6ICVkXG4iLCBwaW4sCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXZfcHJpdi0+aG90cGx1Zy5zdGF0c1tw aW5dLmNvdW50KTsKPiA+ICsgICAgICAgfQo+ID4gKwo+ID4gKyAgICAgICByZXR1cm4gc3Rvcm07 Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBib29sIHBjaF9wb3J0X2hvdHBsdWdfbG9uZ19kZXRl Y3QoZW51bSBwb3J0IHBvcnQsIHUzMiB2YWwpCj4gPiAgewo+ID4gICAgICAgICBzd2l0Y2ggKHBv cnQpIHsKPiA+IEBAIC0xNTQ0LDIxICsxNTgzLDkgQEAgc3RhdGljIHZvaWQgaW50ZWxfaHBkX2ly cV9oYW5kbGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiAgICAgICAgICAgICAgICAgICAg ICAgICBxdWV1ZV9ocCA9IHRydWU7Cj4gPiAgICAgICAgICAgICAgICAgfQo+ID4KPiA+IC0gICAg ICAgICAgICAgICBpZiAoIXRpbWVfaW5fcmFuZ2UoamlmZmllcywgZGV2X3ByaXYtPmhvdHBsdWcu c3RhdHNbaV0ubGFzdF9qaWZmaWVzLAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBkZXZfcHJpdi0+aG90cGx1Zy5zdGF0c1tpXS5sYXN0X2ppZmZpZXMKPiA+IC0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKyBtc2Vjc190b19qaWZmaWVzKEhQRF9TVE9STV9E RVRFQ1RfUEVSSU9EKSkpIHsKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgIGRldl9wcml2LT5o b3RwbHVnLnN0YXRzW2ldLmxhc3RfamlmZmllcyA9IGppZmZpZXM7Cj4gPiAtICAgICAgICAgICAg ICAgICAgICAgICBkZXZfcHJpdi0+aG90cGx1Zy5zdGF0c1tpXS5jb3VudCA9IDA7Cj4gPiAtICAg ICAgICAgICAgICAgICAgICAgICBEUk1fREVCVUdfS01TKCJSZWNlaXZlZCBIUEQgaW50ZXJydXB0 IG9uIFBJTiAlZCAtIGNudDogMFxuIiwgaSk7Cj4gPiAtICAgICAgICAgICAgICAgfSBlbHNlIGlm IChkZXZfcHJpdi0+aG90cGx1Zy5zdGF0c1tpXS5jb3VudCA+IEhQRF9TVE9STV9USFJFU0hPTEQp IHsKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgIGRldl9wcml2LT5ob3RwbHVnLnN0YXRzW2ld LnN0YXRlID0gSFBEX01BUktfRElTQUJMRUQ7Cj4gPiArICAgICAgICAgICAgICAgaWYgKGludGVs X2hwZF9pcnFfc3Rvcm0oZGV2X3ByaXYsIGkpKSB7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICBkZXZfcHJpdi0+aG90cGx1Zy5ldmVudF9iaXRzICY9IH5CSVQoaSk7Cj4gPiAtICAgICAgICAg ICAgICAgICAgICAgICBEUk1fREVCVUdfS01TKCJIUEQgaW50ZXJydXB0IHN0b3JtIGRldGVjdGVk IG9uIFBJTiAlZFxuIiwgaSk7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBzdG9ybV9kZXRl Y3RlZCA9IHRydWU7Cj4gPiAtICAgICAgICAgICAgICAgfSBlbHNlIHsKPiA+IC0gICAgICAgICAg ICAgICAgICAgICAgIGRldl9wcml2LT5ob3RwbHVnLnN0YXRzW2ldLmNvdW50Kys7Cj4gPiAtICAg ICAgICAgICAgICAgICAgICAgICBEUk1fREVCVUdfS01TKCJSZWNlaXZlZCBIUEQgaW50ZXJydXB0 IG9uIFBJTiAlZCAtIGNudDogJWRcbiIsIGksCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRldl9wcml2LT5ob3RwbHVnLnN0YXRzW2ldLmNvdW50KTsKPiA+ICAgICAg ICAgICAgICAgICB9Cj4gPiAgICAgICAgIH0KPiA+Cj4gPiAtLQo+ID4gMi4xLjQKPiA+Cj4gPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4g aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ IAo+IAo+IAo+IC0tIAo+IFBhdWxvIFphbm9uaQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK