Date: Tue, 2 Jun 2015 13:05:33 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150602110533.GP26298@aurel32.net>
References: <1432729200-5322-1-git-send-email-hpoussin@reactos.org>
	<1432729200-5322-17-git-send-email-hpoussin@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1432729200-5322-17-git-send-email-hpoussin@reactos.org>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v2 16/17] net/dp8393x: repair can_receive()
	method
To: =?iso-8859-15?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: Leon Alrae <leon.alrae@imgtec.com>, qemu-devel@nongnu.org

On 2015-05-27 14:19, Herv=E9 Poussineau wrote:
> Datasheet clearly says that RXDIS flag prevents reception, but says
> nothing about a required presence of RXEN flag.
>=20
> While at it, fix the style of the following if statement.
>=20
> Signed-off-by: Herv=E9 Poussineau <hpoussin@reactos.org>
> ---
>  hw/net/dp8393x.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
> index 95a4d3d..b81036a 100644
> --- a/hw/net/dp8393x.c
> +++ b/hw/net/dp8393x.c
> @@ -622,10 +622,12 @@ static int dp8393x_can_receive(NetClientState *nc)
>  {
>      dp8393xState *s =3D qemu_get_nic_opaque(nc);
> =20
> -    if (!(s->regs[SONIC_CR] & SONIC_CR_RXEN))
> +    if (s->regs[SONIC_CR] & SONIC_CR_RXDIS) {
>          return 0;
> -    if (s->regs[SONIC_ISR] & SONIC_ISR_RBE)
> +    }
> +    if (s->regs[SONIC_ISR] & SONIC_ISR_RBE) {
>          return 0;
> +    }
>      return 1;
>  }

I don't have the datasheet at hand, but what would be the point of such
a RXEN flag if it is ignored? Are you sure it's not because it's enabled
by default?

--=20
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net