Received: from eggs.gnu.org ([2001:4830:134:3::10]:55446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzoVt-0003Y7-G8 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:54:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzoVq-0001Zv-62 for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:54:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzoVq-0001Zr-0z for qemu-devel@nongnu.org; Tue, 02 Jun 2015 11:53:58 -0400 Date: Tue, 2 Jun 2015 12:53:55 -0300 From: Eduardo Habkost Message-ID: <20150602155355.GC3410@thinpad.lan.raisama.net> References: <789d40c9c89bb3d9eba55ef96e9a95d31ad268f6.1432881408.git.zhugh.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <789d40c9c89bb3d9eba55ef96e9a95d31ad268f6.1432881408.git.zhugh.fnst@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v7 1/3] sysbus: register reset handler for main_system_bus when created List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua Cc: qemu-devel@nongnu.org, guz.fnst@cn.fujitsu.com, pbonzini@redhat.com, izumi.taku@jp.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, imammedo@redhat.com, afaerber@suse.de On Tue, Jun 02, 2015 at 05:23:55PM +0800, Zhu Guihua wrote: > Since icc bus will be droped and apic reset should be after bus > reset in x86, this patch moves reset handler for main_system_bus > from vl.c to sysbus.c So, you are changing reset ordering for all machines because of a x86-specific requirement? Other machines can have different ordering requirements and may break if you unconditionally change the reset order for all machines. Like I said on v6: if x86 has specific CPU reset ordering requirements, we should be able to ensure the expected ordering in x86-specific code (in pc.c?), not hardcode reset ordering for all machines. Maybe we can change the qemu_register_reset() API to accept an explicit ordering parameter, so ordering requirements are visibly encoded in the qemu_register_reset() calls instead of depending on non-obvious initialization code ordering. While we don't have a better API, we can probably ensure the x86 reset ordering without affecting the other machines by calling qemu_register_reset() for the CPUs in a machine_init_done notifier registered by PC. -- Eduardo