From: Ben Widawsky Subject: Re: [PATCH 1/2] i965/gen9: Pass alignment as function parameter in drm_intel_gem_bo_alloc_internal() Date: Mon, 22 Jun 2015 10:01:30 -0700 Message-ID: <20150622170129.GA10820@mail.bwidawsk.net> References: <1428711656-5878-1-git-send-email-anuj.phogat@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id D6B996E857 for ; Mon, 22 Jun 2015 10:02:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Anuj Phogat Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMTksIDIwMTUgYXQgMDM6NTA6NDRQTSAtMDcwMCwgQW51aiBQaG9nYXQgd3Jv dGU6Cj4gK0Jlbi4KPiAKPiBPbiBGcmksIEFwciAxMCwgMjAxNSBhdCA1OjIwIFBNLCBBbnVqIFBo b2dhdCA8YW51ai5waG9nYXRAZ21haWwuY29tPiB3cm90ZToKPiA+IGFuZCB1c2UgaXQgdG8gaW5p dGlhbGl6ZSB0aGUgYWxpZ24gdmFyaWFibGUgaW4gZHJtX2ludGVsX2JvLgo+ID4KPiA+IEluIGNh c2Ugb2YgWUYvWVMgdGlsZWQgYnVmZmVycyBsaWJkcm0gbmVlZCBub3Qga25vdyBhYm91dCB0aGUg dGlsaW5nCj4gPiBmb3JtYXQgYmVjYXVzZSB0aGVzZSBidWZmZXJzIGRvbid0IGhhdmUgaGFyZHdh cmUgc3VwcG9ydCB0byBiZSB0aWxlZAo+ID4gb3IgZGV0aWxlZCB0aHJvdWdoIGEgZmVuY2VkIHJl Z2lvbi4gQnV0LCBsaWJkcm0gc3RpbGwgbmVlZCB0byBrbm93Cj4gPiBhYm91dCBidWZmZXIgYWxp Z25tZW50IHJlc3RyaWN0aW9ucyBiZWNhdXNlIGtlcm5lbCB1c2VzIGl0IHdoZW4KPiA+IHJlc29s dmluZyB0aGUgcmVsb2NhdGlvbi4KPiA+Cj4gPiBNZXNhIHVzZXMgZHJtX2ludGVsX2dlbV9ib19h bGxvY19mb3JfcmVuZGVyKCkgdG8gYWxsb2NhdGUgWWYvWXMgYnVmZmVycy4KPiA+IFNvLCB1c2Ug dGhlIHBhc3NlZCBhbGlnbm1lbnQgdmFsdWUgaW4gdGhpcyBmdW5jdGlvbi4gTm90ZSB0aGF0IHdl IGNvbnRpbnVlCj4gPiBpZ25vcmluZyB0aGUgYWxpZ25tZW50IHZhbHVlIHBhc3NlZCB0byBkcm1f aW50ZWxfZ2VtX2JvX2FsbG9jKCkgdG8gZm9sbG93Cj4gPiB0aGUgcHJldmlvdXMgYmVoYXZpb3Iu CgpJIHRoaW5rIHRoZXJlIGlzIGEgcHJvYmxlbSBoZXJlIGlmIHlvdSdyZSBnZXR0aW5nIHRoZSBC TyBmcm9tIHRoZSBjYWNoZS4gSWYgeW91CmFsbG9jYXRlIG91dCBvZiB0aGUgY2FjaGUsIGFuZCB0 aGUgYWxpZ25tZW50IGlzIGluY29ycmVjdCwgSSBkb24ndCB0aGluawphbnl0aGluZyB3aWxsIGZp eCBpdCBmb3IgeW91LgoKPiA+Cj4gPiBDYzogS3Jpc3RpYW4gSMO4Z3NiZXJnIDxrcmhAYml0cGxh bmV0Lm5ldD4KPiA+IENjOiBEYW1pZW4gTGVzcGlhdSA8ZGFtaWVuLmxlc3BpYXVAaW50ZWwuY29t Pgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiA+IFNpZ25lZC1vZmYt Ynk6IEFudWogUGhvZ2F0IDxhbnVqLnBob2dhdEBnbWFpbC5jb20+Cj4gPiAtLS0KPiA+ICBpbnRl bC9pbnRlbF9idWZtZ3JfZ2VtLmMgfCAxMSArKysrKysrLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2Vk LCA3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2lu dGVsL2ludGVsX2J1Zm1ncl9nZW0uYyBiL2ludGVsL2ludGVsX2J1Zm1ncl9nZW0uYwo+ID4gaW5k ZXggNWE2N2Y1My4uNTFkODdhZSAxMDA2NDQKPiA+IC0tLSBhL2ludGVsL2ludGVsX2J1Zm1ncl9n ZW0uYwo+ID4gKysrIGIvaW50ZWwvaW50ZWxfYnVmbWdyX2dlbS5jCj4gPiBAQCAtNjU1LDcgKzY1 NSw4IEBAIGRybV9pbnRlbF9nZW1fYm9fYWxsb2NfaW50ZXJuYWwoZHJtX2ludGVsX2J1Zm1nciAq YnVmbWdyLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25n IHNpemUsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcg ZmxhZ3MsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IHRpbGlu Z19tb2RlLAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25n IHN0cmlkZSkKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9u ZyBzdHJpZGUsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCBhbGlnbm1lbnQpCj4gPiAgewo+ID4gICAgICAgICBkcm1faW50ZWxfYnVmbWdyX2dlbSAqYnVm bWdyX2dlbSA9IChkcm1faW50ZWxfYnVmbWdyX2dlbSAqKSBidWZtZ3I7Cj4gPiAgICAgICAgIGRy bV9pbnRlbF9ib19nZW0gKmJvX2dlbTsKCkkgdGhpbmsgeW91IG5lZWQgYSBjaGVjayBzb21ld2hl cmUgbGlrZToKaWYgKGFsaWdubWVudCAmJgogICAgYm9fZ2VtLT5iby5hbGlnbiAhPSBhbGlnbm1l bnQpCglhbGxvY19mcm9tX2NhY2hlID0gZmFsc2U7Cgo+ID4gQEAgLTc1NCw2ICs3NTUsNyBAQCBy ZXRyeToKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBOVUxMOwo+ID4gICAgICAg ICAgICAgICAgIH0KPiA+ICAgICAgICAgICAgICAgICBib19nZW0tPmJvLmJ1Zm1nciA9IGJ1Zm1n cjsKPiA+ICsgICAgICAgICAgICAgICBib19nZW0tPmJvLmFsaWduID0gYWxpZ25tZW50Owo+ID4K PiA+ICAgICAgICAgICAgICAgICBib19nZW0tPnRpbGluZ19tb2RlID0gSTkxNV9USUxJTkdfTk9O RTsKPiA+ICAgICAgICAgICAgICAgICBib19nZW0tPnN3aXp6bGVfbW9kZSA9IEk5MTVfQklUXzZf U1dJWlpMRV9OT05FOwo+ID4gQEAgLTc5Nyw3ICs3OTksOCBAQCBkcm1faW50ZWxfZ2VtX2JvX2Fs bG9jX2Zvcl9yZW5kZXIoZHJtX2ludGVsX2J1Zm1nciAqYnVmbWdyLAo+ID4gIHsKPiA+ICAgICAg ICAgcmV0dXJuIGRybV9pbnRlbF9nZW1fYm9fYWxsb2NfaW50ZXJuYWwoYnVmbWdyLCBuYW1lLCBz aXplLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBC T19BTExPQ19GT1JfUkVOREVSLAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBJOTE1X1RJTElOR19OT05FLCAwKTsKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSTkxNV9USUxJTkdfTk9ORSwgMCwKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWxpZ25tZW50KTsK PiA+ICB9Cj4gPgo+ID4gIHN0YXRpYyBkcm1faW50ZWxfYm8gKgo+ID4gQEAgLTgwNyw3ICs4MTAs NyBAQCBkcm1faW50ZWxfZ2VtX2JvX2FsbG9jKGRybV9pbnRlbF9idWZtZ3IgKmJ1Zm1nciwKPiA+ ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGFsaWdubWVudCkKPiA+ICB7Cj4g PiAgICAgICAgIHJldHVybiBkcm1faW50ZWxfZ2VtX2JvX2FsbG9jX2ludGVybmFsKGJ1Zm1nciwg bmFtZSwgc2l6ZSwgMCwKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgSTkxNV9USUxJTkdfTk9ORSwgMCk7Cj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIEk5MTVfVElMSU5HX05PTkUsIDAsIDApOwo+ID4gIH0K PiA+Cj4gPiAgc3RhdGljIGRybV9pbnRlbF9ibyAqCj4gPiBAQCAtODU5LDcgKzg2Miw3IEBAIGRy bV9pbnRlbF9nZW1fYm9fYWxsb2NfdGlsZWQoZHJtX2ludGVsX2J1Zm1nciAqYnVmbWdyLCBjb25z dCBjaGFyICpuYW1lLAo+ID4gICAgICAgICAgICAgICAgIHN0cmlkZSA9IDA7Cj4gPgo+ID4gICAg ICAgICByZXR1cm4gZHJtX2ludGVsX2dlbV9ib19hbGxvY19pbnRlcm5hbChidWZtZ3IsIG5hbWUs IHNpemUsIGZsYWdzLAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB0aWxpbmcsIHN0cmlkZSk7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHRpbGluZywgc3RyaWRlLCAwKTsKPiA+ICB9Cj4gPgo+ID4gIHN0 YXRpYyBkcm1faW50ZWxfYm8gKgo+ID4gLS0KPiA+IDIuMy40Cj4gPgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=