From: Daniel Vetter Subject: Re: [PATCH v2 1/2] i965/gen9: Pass alignment as function parameter in drm_intel_gem_bo_alloc_internal() Date: Mon, 22 Jun 2015 21:51:08 +0200 Message-ID: <20150622195108.GI25769@phenom.ffwll.local> References: <1428711656-5878-1-git-send-email-anuj.phogat@gmail.com> <1434998822-11855-1-git-send-email-anuj.phogat@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id E2FAD6E81F for ; Mon, 22 Jun 2015 12:48:20 -0700 (PDT) Received: by wgqq4 with SMTP id q4so25362455wgq.1 for ; Mon, 22 Jun 2015 12:48:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1434998822-11855-1-git-send-email-anuj.phogat@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Anuj Phogat Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdW4gMjIsIDIwMTUgYXQgMTE6NDc6MDJBTSAtMDcwMCwgQW51aiBQaG9nYXQgd3Jv dGU6Cj4gYW5kIHVzZSBpdCB0byBpbml0aWFsaXplIHRoZSBhbGlnbiB2YXJpYWJsZSBpbiBkcm1f aW50ZWxfYm8uCj4gCj4gSW4gY2FzZSBvZiBZRi9ZUyB0aWxlZCBidWZmZXJzIGxpYmRybSBuZWVk IG5vdCBrbm93IGFib3V0IHRoZSB0aWxpbmcKPiBmb3JtYXQgYmVjYXVzZSB0aGVzZSBidWZmZXJz IGRvbid0IGhhdmUgaGFyZHdhcmUgc3VwcG9ydCB0byBiZSB0aWxlZAo+IG9yIGRldGlsZWQgdGhy b3VnaCBhIGZlbmNlZCByZWdpb24uIEJ1dCwgbGliZHJtIHN0aWxsIG5lZWQgdG8ga25vdwo+IGFi b3V0IGJ1ZmZlciBhbGlnbm1lbnQgcmVzdHJpY3Rpb25zIGJlY2F1c2Uga2VybmVsIHVzZXMgaXQg d2hlbgo+IHJlc29sdmluZyB0aGUgcmVsb2NhdGlvbi4KPiAKPiBNZXNhIHVzZXMgZHJtX2ludGVs X2dlbV9ib19hbGxvY19mb3JfcmVuZGVyKCkgdG8gYWxsb2NhdGUgWWYvWXMgYnVmZmVycy4KPiBT bywgdXNlIHRoZSBwYXNzZWQgYWxpZ25tZW50IHZhbHVlIGluIHRoaXMgZnVuY3Rpb24uIE5vdGUg dGhhdCB3ZSBjb250aW51ZQo+IGlnbm9yaW5nIHRoZSBhbGlnbm1lbnQgdmFsdWUgcGFzc2VkIHRv IGRybV9pbnRlbF9nZW1fYm9fYWxsb2MoKSB0byBmb2xsb3cKPiB0aGUgcHJldmlvdXMgYmVoYXZp b3IuCj4gCj4gVjI6IEFkZCBhIGNvbmRpdGlvbiB0byBhdm9pZCBhbGxvY2F0aW9uIGZyb20gY2Fj aGUuIChCZW4pCgpUaGlzIHdpbGwgaHVydCBiYWRseSBzaW5jZSBzb21lIHByb2dyYW1zIGxvdmUg dG8gY3ljbGUgdGhyb3VnaCB0ZXh0dXJlcy4KWW91IGNhbiBzdGlsbCBhbGxvY2F0ZSBmcm9tIHRo ZSBjYWNoZSwgeW91IG9ubHkgbmVlZCB0byB1cGRhdGUgdGhlCmFsaWduZW1lbnQgY29uc3RyYWlu dC4gVGhlIGtlcm5lbCB3aWxsIG1vdmUgdGhlIGJ1ZmZlciBvbiB0aGUgbmV4dCBleGVjYnVmCmlm IGl0J3MgbWlzcGxhY2VkLgotRGFuaWVsCgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFudWogUGhvZ2F0 IDxhbnVqLnBob2dhdEBnbWFpbC5jb20+Cj4gQ2M6IEJlbiBXaWRhd3NreSA8YmVuQGJ3aWRhd3Nr Lm5ldD4KPiAtLS0KPiAgaW50ZWwvaW50ZWxfYnVmbWdyX2dlbS5jIHwgMjAgKysrKysrKysrKysr KystLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2ludGVsL2ludGVsX2J1Zm1ncl9nZW0uYyBiL2ludGVsL2lu dGVsX2J1Zm1ncl9nZW0uYwo+IGluZGV4IDYwYzA2ZmMuLjYwZjQ5NGUgMTAwNjQ0Cj4gLS0tIGEv aW50ZWwvaW50ZWxfYnVmbWdyX2dlbS5jCj4gKysrIGIvaW50ZWwvaW50ZWxfYnVmbWdyX2dlbS5j Cj4gQEAgLTY2MCw3ICs2NjAsOCBAQCBkcm1faW50ZWxfZ2VtX2JvX2FsbG9jX2ludGVybmFsKGRy bV9pbnRlbF9idWZtZ3IgKmJ1Zm1nciwKPiAgCQkJCXVuc2lnbmVkIGxvbmcgc2l6ZSwKPiAgCQkJ CXVuc2lnbmVkIGxvbmcgZmxhZ3MsCj4gIAkJCQl1aW50MzJfdCB0aWxpbmdfbW9kZSwKPiAtCQkJ CXVuc2lnbmVkIGxvbmcgc3RyaWRlKQo+ICsJCQkJdW5zaWduZWQgbG9uZyBzdHJpZGUsCj4gKwkJ CQl1bnNpZ25lZCBpbnQgYWxpZ25tZW50KQo+ICB7Cj4gIAlkcm1faW50ZWxfYnVmbWdyX2dlbSAq YnVmbWdyX2dlbSA9IChkcm1faW50ZWxfYnVmbWdyX2dlbSAqKSBidWZtZ3I7Cj4gIAlkcm1faW50 ZWxfYm9fZ2VtICpib19nZW07Cj4gQEAgLTcwMCw5ICs3MDEsMTQgQEAgcmV0cnk6Cj4gIAkJCSAq Lwo+ICAJCQlib19nZW0gPSBEUk1MSVNURU5UUlkoZHJtX2ludGVsX2JvX2dlbSwKPiAgCQkJCQkg ICAgICBidWNrZXQtPmhlYWQucHJldiwgaGVhZCk7Cj4gLQkJCURSTUxJU1RERUwoJmJvX2dlbS0+ aGVhZCk7Cj4gLQkJCWFsbG9jX2Zyb21fY2FjaGUgPSB0cnVlOwo+ICsJCQlpZiAoYWxpZ25tZW50 ID4gMCAmJiBib19nZW0tPmJvLmFsaWduICE9IGFsaWdubWVudCkgewo+ICsJCQkJYWxsb2NfZnJv bV9jYWNoZSA9IGZhbHNlOwo+ICsJCQl9IGVsc2Ugewo+ICsJCQkJYWxsb2NfZnJvbV9jYWNoZSA9 IHRydWU7Cj4gKwkJCQlEUk1MSVNUREVMKCZib19nZW0tPmhlYWQpOwo+ICsJCQl9Cj4gIAkJfSBl bHNlIHsKPiArCQkJYXNzZXJ0KGFsaWdubWVudCA9PSAwKTsKPiAgCQkJLyogRm9yIG5vbi1yZW5k ZXItdGFyZ2V0IEJPcyAod2hlcmUgd2UncmUgcHJvYmFibHkKPiAgCQkJICogZ29pbmcgdG8gbWFw IGl0IGZpcnN0IHRoaW5nIGluIG9yZGVyIHRvIGZpbGwgaXQKPiAgCQkJICogd2l0aCBkYXRhKSwg Y2hlY2sgaWYgdGhlIGxhc3QgQk8gaW4gdGhlIGNhY2hlIGlzCj4gQEAgLTc1OSw2ICs3NjUsNyBA QCByZXRyeToKPiAgCQkJcmV0dXJuIE5VTEw7Cj4gIAkJfQo+ICAJCWJvX2dlbS0+Ym8uYnVmbWdy ID0gYnVmbWdyOwo+ICsJCWJvX2dlbS0+Ym8uYWxpZ24gPSBhbGlnbm1lbnQ7Cj4gIAo+ICAJCWJv X2dlbS0+dGlsaW5nX21vZGUgPSBJOTE1X1RJTElOR19OT05FOwo+ICAJCWJvX2dlbS0+c3dpenps ZV9tb2RlID0gSTkxNV9CSVRfNl9TV0laWkxFX05PTkU7Cj4gQEAgLTgwMiw3ICs4MDksOCBAQCBk cm1faW50ZWxfZ2VtX2JvX2FsbG9jX2Zvcl9yZW5kZXIoZHJtX2ludGVsX2J1Zm1nciAqYnVmbWdy LAo+ICB7Cj4gIAlyZXR1cm4gZHJtX2ludGVsX2dlbV9ib19hbGxvY19pbnRlcm5hbChidWZtZ3Is IG5hbWUsIHNpemUsCj4gIAkJCQkJICAgICAgIEJPX0FMTE9DX0ZPUl9SRU5ERVIsCj4gLQkJCQkJ ICAgICAgIEk5MTVfVElMSU5HX05PTkUsIDApOwo+ICsJCQkJCSAgICAgICBJOTE1X1RJTElOR19O T05FLCAwLAo+ICsJCQkJCSAgICAgICBhbGlnbm1lbnQpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgZHJt X2ludGVsX2JvICoKPiBAQCAtODEyLDcgKzgyMCw3IEBAIGRybV9pbnRlbF9nZW1fYm9fYWxsb2Mo ZHJtX2ludGVsX2J1Zm1nciAqYnVmbWdyLAo+ICAJCSAgICAgICB1bnNpZ25lZCBpbnQgYWxpZ25t ZW50KQo+ICB7Cj4gIAlyZXR1cm4gZHJtX2ludGVsX2dlbV9ib19hbGxvY19pbnRlcm5hbChidWZt Z3IsIG5hbWUsIHNpemUsIDAsCj4gLQkJCQkJICAgICAgIEk5MTVfVElMSU5HX05PTkUsIDApOwo+ ICsJCQkJCSAgICAgICBJOTE1X1RJTElOR19OT05FLCAwLCAwKTsKPiAgfQo+ICAKPiAgc3RhdGlj IGRybV9pbnRlbF9ibyAqCj4gQEAgLTg2NCw3ICs4NzIsNyBAQCBkcm1faW50ZWxfZ2VtX2JvX2Fs bG9jX3RpbGVkKGRybV9pbnRlbF9idWZtZ3IgKmJ1Zm1nciwgY29uc3QgY2hhciAqbmFtZSwKPiAg CQlzdHJpZGUgPSAwOwo+ICAKPiAgCXJldHVybiBkcm1faW50ZWxfZ2VtX2JvX2FsbG9jX2ludGVy bmFsKGJ1Zm1nciwgbmFtZSwgc2l6ZSwgZmxhZ3MsCj4gLQkJCQkJICAgICAgIHRpbGluZywgc3Ry aWRlKTsKPiArCQkJCQkgICAgICAgdGlsaW5nLCBzdHJpZGUsIDApOwo+ICB9Cj4gIAo+ICBzdGF0 aWMgZHJtX2ludGVsX2JvICoKPiAtLSAKPiAxLjkuMwo+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK