From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: In DBUF/WM calcs for 90/270, swap w & h Date: Fri, 26 Jun 2015 19:31:34 +0200 Message-ID: <20150626173134.GK30960@phenom.ffwll.local> References: <1435326829-12458-1-git-send-email-chandra.konduru@intel.com> <1435326829-12458-3-git-send-email-chandra.konduru@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTP id C423E6EE4C for ; Fri, 26 Jun 2015 10:28:46 -0700 (PDT) Received: by wibdq8 with SMTP id dq8so23728162wib.1 for ; Fri, 26 Jun 2015 10:28:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1435326829-12458-3-git-send-email-chandra.konduru@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chandra Konduru Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMjYsIDIwMTUgYXQgMDY6NTM6NDlBTSAtMDcwMCwgQ2hhbmRyYSBLb25kdXJ1 IHdyb3RlOgo+IFRoaXMgcGF0Y2ggc3dhcHMgc3JjIHdpZHRoIGFuZCBoZWlnaHQgZm9yIGRidWYv d20gY2FsY3VsYXRpb25zCj4gd2hlbiByb3RhdGlvbiBpcyA5MC8yNzAgYXMgcGVyIGh3IHJlcXVp cmVtZW50cy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaGFuZHJhIEtvbmR1cnUgPGNoYW5kcmEua29u ZHVydUBpbnRlbC5jb20+CgpEbyB3ZSBoYXZlIGFuIGlndCB3aGljaCBwcm92b2tlcyB1bmRlcnJ1 bnMgYW5kIGhlbmNlIGNhbiB0ZXN0IHRoaXMKYXV0b21hdGljYWxseT8gVmVyeSB0YWxsL25hcnJv dyBidWZmZXJzIHNob3VsZCBkbyBpdCBJIHRoaW5rLgotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgICAzMiArKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCBlYTNlNDM1Li43NjczMTNiIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gQEAgLTI5MTMsNiArMjkxMyw4IEBAIHN0YXRp YyB2b2lkIHNrbF9jb21wdXRlX3dtX3BpcGVfcGFyYW1ldGVycyhzdHJ1Y3QgZHJtX2NydGMgKmNy dGMsCj4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gIAlzdHJ1Y3QgZHJt X3BsYW5lICpwbGFuZTsKPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ICsJc3RydWN0 IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCWludCBzcmNfdywgc3JjX2g7Cj4g IAlpbnQgaSA9IDE7IC8qIEluZGV4IGZvciBzcHJpdGUgcGxhbmVzIHN0YXJ0ICovCj4gIAo+ICAJ cC0+YWN0aXZlID0gaW50ZWxfY3J0Yy0+YWN0aXZlOwo+IEBAIC0yOTIxLDYgKzI5MjMsNyBAQCBz dGF0aWMgdm9pZCBza2xfY29tcHV0ZV93bV9waXBlX3BhcmFtZXRlcnMoc3RydWN0IGRybV9jcnRj ICpjcnRjLAo+ICAJCXAtPnBpeGVsX3JhdGUgPSBza2xfcGlwZV9waXhlbF9yYXRlKGludGVsX2Ny dGMtPmNvbmZpZyk7Cj4gIAo+ICAJCWZiID0gY3J0Yy0+cHJpbWFyeS0+c3RhdGUtPmZiOwo+ICsJ CXBsYW5lX3N0YXRlID0gdG9faW50ZWxfcGxhbmVfc3RhdGUoY3J0Yy0+cHJpbWFyeS0+c3RhdGUp Owo+ICAJCS8qIEZvciBwbGFuYXI6IEJwcCBpcyBmb3IgdXYgcGxhbmUsIHlfQnBwIGlzIGZvciB5 IHBsYW5lICovCj4gIAkJaWYgKGZiKSB7Cj4gIAkJCXAtPnBsYW5lWzBdLmVuYWJsZWQgPSB0cnVl Owo+IEBAIC0yOTM1LDggKzI5MzgsMjIgQEAgc3RhdGljIHZvaWQgc2tsX2NvbXB1dGVfd21fcGlw ZV9wYXJhbWV0ZXJzKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCQkJcC0+cGxhbmVbMF0ueV9i eXRlc19wZXJfcGl4ZWwgPSAwOwo+ICAJCQlwLT5wbGFuZVswXS50aWxpbmcgPSBEUk1fRk9STUFU X01PRF9OT05FOwo+ICAJCX0KPiAtCQlwLT5wbGFuZVswXS5ob3Jpel9waXhlbHMgPSBpbnRlbF9j cnRjLT5jb25maWctPnBpcGVfc3JjX3c7Cj4gLQkJcC0+cGxhbmVbMF0udmVydF9waXhlbHMgPSBp bnRlbF9jcnRjLT5jb25maWctPnBpcGVfc3JjX2g7Cj4gKwo+ICsJCWlmIChkcm1fcmVjdF93aWR0 aCgmcGxhbmVfc3RhdGUtPnNyYykpIHsKPiArCQkJc3JjX3cgPSBkcm1fcmVjdF93aWR0aCgmcGxh bmVfc3RhdGUtPnNyYykgPj4gMTY7Cj4gKwkJCXNyY19oID0gZHJtX3JlY3RfaGVpZ2h0KCZwbGFu ZV9zdGF0ZS0+c3JjKSA+PiAxNjsKPiArCQl9IGVsc2Ugewo+ICsJCQlzcmNfdyA9IGludGVsX2Ny dGMtPmNvbmZpZy0+cGlwZV9zcmNfdzsKPiArCQkJc3JjX2ggPSBpbnRlbF9jcnRjLT5jb25maWct PnBpcGVfc3JjX2g7Cj4gKwkJfQo+ICsKPiArCQlpZiAoaW50ZWxfcm90YXRpb25fOTBfb3JfMjcw KGNydGMtPnByaW1hcnktPnN0YXRlLT5yb3RhdGlvbikpIHsKPiArCQkJcC0+cGxhbmVbMF0uaG9y aXpfcGl4ZWxzID0gc3JjX2g7Cj4gKwkJCXAtPnBsYW5lWzBdLnZlcnRfcGl4ZWxzID0gc3JjX3c7 Cj4gKwkJfSBlbHNlIHsKPiArCQkJcC0+cGxhbmVbMF0uaG9yaXpfcGl4ZWxzID0gc3JjX3c7Cj4g KwkJCXAtPnBsYW5lWzBdLnZlcnRfcGl4ZWxzID0gc3JjX2g7Cj4gKwkJfQo+ICAJCXAtPnBsYW5l WzBdLnJvdGF0aW9uID0gY3J0Yy0+cHJpbWFyeS0+c3RhdGUtPnJvdGF0aW9uOwo+ICAKPiAgCQlm YiA9IGNydGMtPmN1cnNvci0+c3RhdGUtPmZiOwo+IEBAIC0zNDY4LDggKzM0ODUsMTUgQEAgc2ts X3VwZGF0ZV9zcHJpdGVfd20oc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsIHN0cnVjdCBkcm1fY3J0 YyAqY3J0YywKPiAgCj4gIAlpbnRlbF9wbGFuZS0+d20uZW5hYmxlZCA9IGVuYWJsZWQ7Cj4gIAlp bnRlbF9wbGFuZS0+d20uc2NhbGVkID0gc2NhbGVkOwo+IC0JaW50ZWxfcGxhbmUtPndtLmhvcml6 X3BpeGVscyA9IHNwcml0ZV93aWR0aDsKPiAtCWludGVsX3BsYW5lLT53bS52ZXJ0X3BpeGVscyA9 IHNwcml0ZV9oZWlnaHQ7Cj4gKwo+ICsJaWYgKGludGVsX3JvdGF0aW9uXzkwX29yXzI3MChwbGFu ZS0+c3RhdGUtPnJvdGF0aW9uKSkgewo+ICsJCWludGVsX3BsYW5lLT53bS5ob3Jpel9waXhlbHMg PSBzcHJpdGVfaGVpZ2h0Owo+ICsJCWludGVsX3BsYW5lLT53bS52ZXJ0X3BpeGVscyA9IHNwcml0 ZV93aWR0aDsKPiArCX0gZWxzZSB7Cj4gKwkJaW50ZWxfcGxhbmUtPndtLmhvcml6X3BpeGVscyA9 IHNwcml0ZV93aWR0aDsKPiArCQlpbnRlbF9wbGFuZS0+d20udmVydF9waXhlbHMgPSBzcHJpdGVf aGVpZ2h0Owo+ICsJfQo+ICsKPiAgCWludGVsX3BsYW5lLT53bS50aWxpbmcgPSBEUk1fRk9STUFU X01PRF9OT05FOwo+ICAKPiAgCS8qIEZvciBwbGFuYXI6IEJwcCBpcyBmb3IgVVYgcGxhbmUsIHlf QnBwIGlzIGZvciBZIHBsYW5lICovCj4gLS0gCj4gMS43LjkuNQo+IAo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK