From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Preallocate request before access of the ring Date: Mon, 29 Jun 2015 17:50:21 +0200 Message-ID: <20150629155021.GX30960@phenom.ffwll.local> References: <1430323845-28906-1-git-send-email-yu.dai@intel.com> <55422611.7030902@intel.com> <20150506100603.GN30184@phenom.ffwll.local> <87pp4eyc97.fsf@intel.com> <55914EE5.1060300@intel.com> <876166y3on.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 92E086E09E for ; Mon, 29 Jun 2015 08:48:04 -0700 (PDT) Received: by wgqq4 with SMTP id q4so145032746wgq.1 for ; Mon, 29 Jun 2015 08:48:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <876166y3on.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdW4gMjksIDIwMTUgYXQgMDU6NDQ6NDBQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gTW9uLCAyOSBKdW4gMjAxNSwgRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGlu dGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiAyOS8wNi8xNSAxMjozOSwgSmFuaSBOaWt1bGEgd3JvdGU6 Cj4gPj4gT24gV2VkLCAwNiBNYXkgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNo PiB3cm90ZToKPiA+Pj4gT24gVGh1LCBBcHIgMzAsIDIwMTUgYXQgMDE6NTQ6NDFQTSArMDEwMCwg RGF2ZSBHb3Jkb24gd3JvdGU6Cj4gPj4+PiBPbiAyOS8wNC8xNSAxNzoxMCwgeXUuZGFpQGludGVs LmNvbSB3cm90ZToKPiA+Pj4+PiBGcm9tOiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiA+ Pj4+Pgo+ID4+Pj4+IFRoaXMgaXMgdG8gYXZvaWQgYmFkIElPIGFjY2VzcyBjYXVzZWQgYnkgd3Jp dGluZyBOT09QIHRvIHdyYXAgdGhlCj4gPj4+Pj4gcmluZyBidWZmZXIgd2hpbHN0IHJpbmcgaXMg dW5waW5uZWQuCj4gPj4+Pj4KPiA+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBBbGV4IERhaSA8eXUuZGFp QGludGVsLmNvbT4KPiA+Pj4+PiAtLS0KPiA+Pj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMgfCA2ICsrKy0tLQo+ID4+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQo+ID4+Pj4+Cj4gPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMKPiA+Pj4+PiBpbmRleCA3MzJmZDYzLi4zZThmY2ZkIDEwMDY0NAo+ID4+Pj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiA+Pj4+PiBAQCAtODAzLDEyICs4MDMsMTIgQEAgc3RhdGlj IGludCBpbnRlbF9sb2dpY2FsX3JpbmdfYmVnaW4oc3RydWN0IGludGVsX3JpbmdidWZmZXIgKnJp bmdidWYsCj4gPj4+Pj4gIAlpZiAocmV0KQo+ID4+Pj4+ICAJCXJldHVybiByZXQ7Cj4gPj4+Pj4g IAo+ID4+Pj4+IC0JcmV0ID0gbG9naWNhbF9yaW5nX3ByZXBhcmUocmluZ2J1ZiwgY3R4LCBudW1f ZHdvcmRzICogc2l6ZW9mKHVpbnQzMl90KSk7Cj4gPj4+Pj4gKwkvKiBQcmVhbGxvY2F0ZSB0aGUg b2xyIGJlZm9yZSB0b3VjaGluZyB0aGUgcmluZyAqLwo+ID4+Pj4+ICsJcmV0ID0gaTkxNV9nZW1f cmVxdWVzdF9hbGxvYyhyaW5nLCBjdHgpOwo+ID4+Pj4+ICAJaWYgKHJldCkKPiA+Pj4+PiAgCQly ZXR1cm4gcmV0Owo+ID4+Pj4+ICAKPiA+Pj4+PiAtCS8qIFByZWFsbG9jYXRlIHRoZSBvbHIgYmVm b3JlIHRvdWNoaW5nIHRoZSByaW5nICovCj4gPj4+Pj4gLQlyZXQgPSBpOTE1X2dlbV9yZXF1ZXN0 X2FsbG9jKHJpbmcsIGN0eCk7Cj4gPj4+Pj4gKwlyZXQgPSBsb2dpY2FsX3JpbmdfcHJlcGFyZShy aW5nYnVmLCBjdHgsIG51bV9kd29yZHMgKiBzaXplb2YodWludDMyX3QpKTsKPiA+Pj4+PiAgCWlm IChyZXQpCj4gPj4+Pj4gIAkJcmV0dXJuIHJldDsKPiA+Pj4+Cj4gPj4+PiBSZXZpZXdlZC1ieTog RGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPiA+Pj4+IHdpdGggaW5wdXQg YWxzbyBmcm9tIEpvaG4gSGFycmlzb24gPGpvaG4uYy5oYXJyaXNvbkBpbnRlbC5jb20+LCB3aG8K PiA+Pj4+IHdvdWxkIGxpa2UgdG8gcG9pbnQgb3V0IHRoYXQgdGhpcyB3aWxsIGJlIHN1cGVyY2Vk ZWQgYnkgdGhlIEFudGktT0xSCj4gPj4+PiBwYXRjaGVzIGFscmVhZHkgcG9zdGVkLiAoSW4gdGhh dCBtb2RlbCwgdGhlIHJlcXVlc3Qgd2lsbCBiZSBhbGxvY2F0ZWQKPiA+Pj4+IG11Y2ggZWFybGll ciwgYW5kIHBhc3NlZCBhcm91bmQgZXhwbGljaXRseSByYXRoZXIgdGhhbiBkYW5nbGluZyBmcm9t IHRoZQo+ID4+Pj4gY29udGV4dCkuCj4gPj4+Cj4gPj4+IERvIHdlIG5lZWQgdGhpcyBmb3IgZXhl Y2xpc3QgaW4gZ2VuZXJhbCwgaS5lLiBjYzogc3RhYmxlPyBXaGVyZSdzIHRoZSBidWcKPiA+Pj4g cmVwb3J0L2lndCB0ZXN0Y2FzZT8KPiA+Pj4KPiA+Pj4gRm9yIHNlcmlvdXMtbG9va2luZyBidWdz IHBsZWFzZSBhZGQgbW9yZSBkZXRhaWxzIGxpa2UgdGhhdCB0byB0aGUgY29tbWl0Cj4gPj4+IG1l c3NhZ2UsIG90aGVyd2lzZSBtYWludGFpbmVycyBoYXZlIG5vIGlkZWEgd2hlcmUgdG8gYXBwbHkg YSBwYXRjaC4KPiA+PiAKPiA+PiBBbmQgZHVlIHRvIG5vIHJlcGx5LCB0aGUgbWFpbnRhaW5lcnMg aGF2ZSBmb3Jnb3R0ZW4gYWJvdXQgcGF0Y2hlcyBsaWtlCj4gPj4gdGhpcy4gRHJvcHBpbmcgZnJv bSBteSBmaXhlcyBxdWV1ZS4KPiA+PiAKPiA+PiBCUiwKPiA+PiBKYW5pLgo+ID4KPiA+IFRoaXMg YmVjYW1lIG9ic29sZXRlIHdpdGggdGhlIG1lcmdlIG9mIEpvaG4gSGFycmlzb24ncyBwYXRjaHNl dAo+ID4gCSJSZW1vdmUgdGhlIG91dHN0YW5kaW5nX2xhenlfcmVxdWVzdCIKPiAKPiBUaGFua3Mu CgpJdCBvbmx5IGJlY2FtZSBvYnNvbGV0ZSBmb3IgZGlucS80LjMsIEkgdGhpbmsgd2Ugc3RpbGwg bmVlZCB0aGlzIGZvciBhbnkKb3RoZXIga2VybmVscyBzaGlwcGluZyB3aXRoIGV4ZWNsaXN0LiBE YXZlLCBjYW4geW91IHBsZWFzZSBjb25maXJtPwoKSSB0cmllZCB0byBkaWdnIG91dCB3aGVuIGV4 YWN0bHkgd2UgZW5hYmxlZCBleGVjbGlzdCwgYnV0IHRoZXJlJ3MgYSBtb2R1bGUKb3B0aW9ucyBs b29wIGFuZCBzbyBJIGdvdCBsb3N0IGluIHRoZSByZWN1cnNpb24gLi4uCi1EYW5pZWwKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==