From: Theodore Ts'o Subject: Re: [PATCH 1/2] ext4: replace ext4_io_submit->io_op with ->io_wbc Date: Tue, 21 Jul 2015 23:56:09 -0400 Message-ID: <20150722035609.GC2944@thunk.org> References: <1434495193-31182-1-git-send-email-tj@kernel.org> <1434495193-31182-2-git-send-email-tj@kernel.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=CM5V8M4qKh/ZVbRFL5sDl2d5+rA/ue7Sda+J0NVl1qg=; b=AvOA78RWnZvi/OnEtKgbCWRjJI7fLP9pQij9nMacxCxtZqn7hDl4I+Llk70jJ8Uqy7aQn0tXLmmcEu+Djbxy4BKMpIP+FtRT1VBhY9PalY3OvSSO0Mb5nMctRCpZSwDggb/7RG2mtraUy/a2J2kqjPTZit3UwWwVOU10Rv4/j/o=; Content-Disposition: inline In-Reply-To: <1434495193-31182-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org, adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Tue, Jun 16, 2015 at 06:53:12PM -0400, Tejun Heo wrote: > ext4_io_submit_init() takes the pointer to writeback_control to test > its sync_mode and determine between WRITE and WRITE_SYNC and records > the result in ->io_op. This patch makes it record the pointer > directly and moves the test to ext4_io_submit(). > > This doesn't cause any noticeable differences now but having > writeback_control available throughout IO submission path will be > depended upon by the planned cgroup writeback support. > > Signed-off-by: Tejun Heo > Cc: "Theodore Ts'o" > Cc: Andreas Dilger > Cc: linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Thanks, applied. - Ted