Date: Sun, 26 Jul 2015 22:14:03 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150726201403.GB13016@aurel32.net>
References: <1437763343-7980-1-git-send-email-hpoussin@reactos.org>
	<1437763343-7980-4-git-send-email-hpoussin@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1437763343-7980-4-git-send-email-hpoussin@reactos.org>
Subject: Re: [Qemu-devel] [PATCH for 2.4 3/3] net/dp8393x: remove check of
	runt packets
To: =?iso-8859-15?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: Leon Alrae <leon.alrae@imgtec.com>, qemu-devel@nongnu.org

On 2015-07-24 20:42, Herv=E9 Poussineau wrote:
> Ethernet requires that messages are at least 64 bytes on the wire. This
> limitation does not exist on emulation (no wire message), so remove the
> check. Netcard is now able to receive small network packets.
>=20
> Signed-off-by: Herv=E9 Poussineau <hpoussin@reactos.org>
> ---
>  hw/net/dp8393x.c | 5 -----
>  1 file changed, 5 deletions(-)
>=20
> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
> index 55168b5..d4f811d 100644
> --- a/hw/net/dp8393x.c
> +++ b/hw/net/dp8393x.c
> @@ -645,11 +645,6 @@ static int dp8393x_receive_filter(dp8393xState *s, c=
onst uint8_t * buf,
>      static const uint8_t bcast[] =3D {0xff, 0xff, 0xff, 0xff, 0xff, 0xff=
};
>      int i;
> =20
> -    /* Check for runt packet (remember that checksum is not there) */
> -    if (size < 64 - 4) {
> -        return (s->regs[SONIC_RCR] & SONIC_RCR_RNT) ? 0 : -1;
> -    }
> -
>      /* Check promiscuous mode */
>      if ((s->regs[SONIC_RCR] & SONIC_RCR_PRO) && (buf[0] & 1) =3D=3D 0) {
>          return 0;

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

--=20
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net