From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Split sink_crc function in start, stop and read. Date: Wed, 5 Aug 2015 10:07:14 +0200 Message-ID: <20150805080713.GB17734@phenom.ffwll.local> References: <20150729082452.GR16722@phenom.ffwll.local> <1438298799-4024-1-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A37F6E0F8 for ; Wed, 5 Aug 2015 01:07:18 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so54951975wib.1 for ; Wed, 05 Aug 2015 01:07:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1438298799-4024-1-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdWwgMzAsIDIwMTUgYXQgMDQ6MjY6MzlQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IFRoaXMgaXMganVzdCBhIHByZXBhcmF0aW9uIHBhdGNoIHRvIG1ha2UgY2xlYXIgd2hh dCBvcGVyYXRpb24gd2UKPiBhcmUgcGVyZm9ybWluZy4gVGhlcmUgaXMgbm8gZnVuY3Rpb25hbCBj aGFuZ2Ugb24gdGhlIHNpbmsgY3JjCj4gbG9naWMuCj4gCj4gaHN3X2Rpc2FibGVfaXBzIGhhcyBi ZWVuIG1vdmVkIGEgYml0IGZ1cnRoZXIgaW4gdGhlIHN0YXJ0IGZ1bmN0aW9uCj4gdG8gYXZvaWQg ZGlzYWJsaW5nIGlwcyB3aGVuIHNpbmsgY3JjIGlzIG5vdCBnb2luZyB0byBiZSBzdGFydGVkLgo+ IGFuZCB0byBhdm9pZCBnb3RvIG9uIHRoaXMgZnVuY3Rpb24uCj4gCj4gdjI6IGV4cGxhaW4gd2h5 IGhzd19kaXNhYmxlX2lwcygpIGNhbGwgcGxhY2UgaGFzIGNoYW5nZWQuCj4gCj4gQ2M6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gUmV2aWV3ZWQtYnk6IFJhZmFlbCBB bnRvZ25vbGxpIDxyYWZhZWwuYW50b2dub2xsaUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog Um9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKVGhhbmtzIGZvciB0aGUgdXBk YXRlZCBjb21taXQgbWVzc2FnZS4gUXVldWVkIGZvciAtbmV4dCwgdGhhbmtzIGZvciB0aGUKcGF0 Y2guCi1EYW5pZWwKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDg5 ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCA1MCBpbnNlcnRpb25zKCspLCAzOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMKPiBpbmRleCA0NGY4YTMyLi4xMGNiYzk4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jCj4gQEAgLTM5NTgsNDAgKzM5NTgsNjQgQEAgaW50ZWxfZHBfcHJvYmVfbXN0KHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAlyZXR1cm4gaW50ZWxfZHAtPmlzX21zdDsKPiAgfQo+ ICAKPiAtaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4 ICpjcmMpCj4gK3N0YXRpYyB2b2lkIGludGVsX2RwX3NpbmtfY3JjX3N0b3Aoc3RydWN0IGludGVs X2RwICppbnRlbF9kcCkKPiAgewo+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxf ZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gLQlzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2ID0gaW50ZWxfZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXY7Cj4gLQlzdHJ1Y3QgaW50ZWxf Y3J0YyAqaW50ZWxfY3J0YyA9Cj4gLQkJdG9faW50ZWxfY3J0YyhpbnRlbF9kaWdfcG9ydC0+YmFz ZS5iYXNlLmNydGMpOwo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBk cF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0 YyA9IHRvX2ludGVsX2NydGMoZGlnX3BvcnQtPmJhc2UuYmFzZS5jcnRjKTsKPiAgCXU4IGJ1ZjsK PiAtCWludCB0ZXN0X2NyY19jb3VudDsKPiAtCWludCBhdHRlbXB0cyA9IDY7Cj4gLQlpbnQgcmV0 ID0gMDsKPiAtCj4gLQloc3dfZGlzYWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4gIAo+IC0JaWYgKGRy bV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTktfTUlTQywgJmJ1Zikg PCAwKSB7Cj4gLQkJcmV0ID0gLUVJTzsKPiAtCQlnb3RvIG91dDsKPiArCWlmIChkcm1fZHBfZHBj ZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLCAmYnVmKSA8IDApIHsKPiArCQlE Uk1fREVCVUdfS01TKCJTaW5rIENSQyBjb3VsZG4ndCBiZSBzdG9wcGVkIHByb3Blcmx5XG4iKTsK PiArCQlyZXR1cm47Cj4gIAl9Cj4gIAo+IC0JaWYgKCEoYnVmICYgRFBfVEVTVF9DUkNfU1VQUE9S VEVEKSkgewo+IC0JCXJldCA9IC1FTk9UVFk7Cj4gLQkJZ290byBvdXQ7Cj4gLQl9Cj4gKwlpZiAo ZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTkssCj4gKwkJCSAg ICAgICBidWYgJiB+RFBfVEVTVF9TSU5LX1NUQVJUKSA8IDApCj4gKwkJRFJNX0RFQlVHX0tNUygi U2luayBDUkMgY291bGRuJ3QgYmUgc3RvcHBlZCBwcm9wZXJseVxuIik7Cj4gIAo+IC0JaWYgKGRy bV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTkssICZidWYpIDwgMCkg ewo+IC0JCXJldCA9IC1FSU87Cj4gLQkJZ290byBvdXQ7Cj4gLQl9Cj4gKwloc3dfZW5hYmxlX2lw cyhpbnRlbF9jcnRjKTsKPiArfQo+ICsKPiArc3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2NyY19z dGFydChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZGln aXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiArCXN0cnVj dCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhkaWdfcG9ydC0+YmFzZS5i YXNlLmNydGMpOwo+ICsJdTggYnVmOwo+ICsKPiArCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50 ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LX01JU0MsICZidWYpIDwgMCkKPiArCQlyZXR1cm4gLUVJ TzsKPiArCj4gKwlpZiAoIShidWYgJiBEUF9URVNUX0NSQ19TVVBQT1JURUQpKQo+ICsJCXJldHVy biAtRU5PVFRZOwo+ICsKPiArCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwg RFBfVEVTVF9TSU5LLCAmYnVmKSA8IDApCj4gKwkJcmV0dXJuIC1FSU87Cj4gKwo+ICsJaHN3X2Rp c2FibGVfaXBzKGludGVsX2NydGMpOwo+ICAKPiAgCWlmIChkcm1fZHBfZHBjZF93cml0ZWIoJmlu dGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOSywKPiAtCQkJCWJ1ZiB8IERQX1RFU1RfU0lOS19TVEFS VCkgPCAwKSB7Cj4gLQkJcmV0ID0gLUVJTzsKPiAtCQlnb3RvIG91dDsKPiArCQkJICAgICAgIGJ1 ZiB8IERQX1RFU1RfU0lOS19TVEFSVCkgPCAwKSB7Cj4gKwkJaHN3X2VuYWJsZV9pcHMoaW50ZWxf Y3J0Yyk7Cj4gKwkJcmV0dXJuIC1FSU87Cj4gIAl9Cj4gIAo+ICsJcmV0dXJuIDA7Cj4gK30KPiAr Cj4gK2ludCBpbnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCB1OCAq Y3JjKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3Rv X2RpZ19wb3J0KGludGVsX2RwKTsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkaWdfcG9y dC0+YmFzZS5iYXNlLmRldjsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9f aW50ZWxfY3J0YyhkaWdfcG9ydC0+YmFzZS5iYXNlLmNydGMpOwo+ICsJdTggYnVmOwo+ICsJaW50 IHRlc3RfY3JjX2NvdW50Owo+ICsJaW50IGF0dGVtcHRzID0gNjsKPiArCWludCByZXQ7Cj4gKwo+ ICsJcmV0ID0gaW50ZWxfZHBfc2lua19jcmNfc3RhcnQoaW50ZWxfZHApOwo+ICsJaWYgKHJldCkK PiArCQlyZXR1cm4gcmV0Owo+ICsKPiAgCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAt PmF1eCwgRFBfVEVTVF9TSU5LX01JU0MsICZidWYpIDwgMCkgewo+ICAJCXJldCA9IC1FSU87Cj4g IAkJZ290byBzdG9wOwo+IEBAIC00MDE0LDIzICs0MDM4LDEwIEBAIGludCBpbnRlbF9kcF9zaW5r X2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCB1OCAqY3JjKQo+ICAJCWdvdG8gc3RvcDsK PiAgCX0KPiAgCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBfVEVT VF9DUkNfUl9DUiwgY3JjLCA2KSA8IDApIHsKPiArCWlmIChkcm1fZHBfZHBjZF9yZWFkKCZpbnRl bF9kcC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLCBjcmMsIDYpIDwgMCkKPiAgCQlyZXQgPSAtRUlP Owo+IC0JCWdvdG8gc3RvcDsKPiAtCX0KPiAtCj4gIHN0b3A6Cj4gLQlpZiAoZHJtX2RwX2RwY2Rf cmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOSywgJmJ1ZikgPCAwKSB7Cj4gLQkJRFJN X0RFQlVHX0tNUygiU2luayBDUkMgY291bGRuJ3QgYmUgc3RvcHBlZCBwcm9wZXJseVxuIik7Cj4g LQkJZ290byBvdXQ7Cj4gLQl9Cj4gLQlpZiAoZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+ YXV4LCBEUF9URVNUX1NJTkssCj4gLQkJCSAgICAgICBidWYgJiB+RFBfVEVTVF9TSU5LX1NUQVJU KSA8IDApIHsKPiAtCQlEUk1fREVCVUdfS01TKCJTaW5rIENSQyBjb3VsZG4ndCBiZSBzdG9wcGVk IHByb3Blcmx5XG4iKTsKPiAtCQlnb3RvIG91dDsKPiAtCX0KPiAtb3V0Ogo+IC0JaHN3X2VuYWJs ZV9pcHMoaW50ZWxfY3J0Yyk7Cj4gKwlpbnRlbF9kcF9zaW5rX2NyY19zdG9wKGludGVsX2RwKTsK PiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gLS0gCj4gMi4xLjAKPiAKCi0tIApEYW5pZWwgVmV0 dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZnds bC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=