From: Peter Zijlstra Subject: Re: [PATCH] coredump: Replace opencoded set_mask_bits() Date: Fri, 7 Aug 2015 16:57:37 +0200 Message-ID: <20150807145737.GL16853@twins.programming.kicks-ass.net> References: <1438935406-5762-1-git-send-email-vgupta@synopsys.com> <20150807115710.GA16897@redhat.com> <55C4C433.5000501@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Oleg Nesterov , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Vineet Gupta Return-path: Received: from casper.infradead.org ([85.118.1.10]:50985 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753957AbbHGO5k (ORCPT ); Fri, 7 Aug 2015 10:57:40 -0400 Content-Disposition: inline In-Reply-To: <55C4C433.5000501@synopsys.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Aug 07, 2015 at 08:14:03PM +0530, Vineet Gupta wrote: > See, I have such a cmpxchg loop in ARC code - originally from Peter :-) > arch/arc/kernel/smp.c. @ipi_data_ptr is NOT atomic_t > > do { > new = old = ACCESS_ONCE(*ipi_data_ptr); > new |= 1U << msg; > } while (cmpxchg(ipi_data_ptr, old, new) != old); > Well, you'll have atomic_or() real soon now.