From: Peter Zijlstra Subject: Re: [PATCH] coredump: Replace opencoded set_mask_bits() Date: Fri, 7 Aug 2015 17:45:25 +0200 Message-ID: <20150807154525.GO16853@twins.programming.kicks-ass.net> References: <1438935406-5762-1-git-send-email-vgupta@synopsys.com> <20150807115710.GA16897@redhat.com> <55C4C433.5000501@synopsys.com> <20150807145737.GL16853@twins.programming.kicks-ass.net> <55C4D02A.5000902@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Oleg Nesterov , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Vineet Gupta Return-path: Content-Disposition: inline In-Reply-To: <55C4D02A.5000902@synopsys.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Aug 07, 2015 at 09:05:06PM +0530, Vineet Gupta wrote: > On Friday 07 August 2015 08:27 PM, Peter Zijlstra wrote: > > On Fri, Aug 07, 2015 at 08:14:03PM +0530, Vineet Gupta wrote: > > > >> > See, I have such a cmpxchg loop in ARC code - originally from Peter :-) > >> > arch/arc/kernel/smp.c. @ipi_data_ptr is NOT atomic_t > >> > > >> > do { > >> > new = old = ACCESS_ONCE(*ipi_data_ptr); > >> > new |= 1U << msg; > >> > } while (cmpxchg(ipi_data_ptr, old, new) != old); > >> > > > Well, you'll have atomic_or() real soon now. > > Doesn't help my cause - ipi_data_ptr is not atomic_t - hence my prev question in > this thread A cast will work :-) But yes, ideally everything will be type safe because of those archs that cannot have atomic RmW ops like !ARC_HAS_LLSC. Mixing cmpxchg()/xchg() with regular stores is broken on those. Fwiw, you might want to set ARCH_SUPPORTS_ATOMIC_RMW for ARC_HAS_LLSC.