From: Steven Rostedt Subject: [PATCH RT 1/6] Revert "slub: delay ctor until the object is requested" Date: Fri, 07 Aug 2015 14:07:10 -0400 Message-ID: <20150807180723.506362537@goodmis.org> References: <20150807180709.744130098@goodmis.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Cc: Thomas Gleixner , Carsten Emde , Sebastian Andrzej Siewior , John Kacur , Paul Gortmaker , To: linux-kernel@vger.kernel.org, linux-rt-users Return-path: Received: from mail.kernel.org ([198.145.29.136]:46373 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946120AbbHGSH1 (ORCPT ); Fri, 7 Aug 2015 14:07:27 -0400 Content-Disposition: inline; filename=0001-Revert-slub-delay-ctor-until-the-object-is-requested.patch Sender: linux-rt-users-owner@vger.kernel.org List-ID: 3.10.84-rt92-rc1 stable review patch. If anyone has any objections, please let me know. ------------------ From: Sebastian Andrzej Siewior This approach is broken with SLAB_DESTROY_BY_RCU allocations. Reported by Steven Rostedt and Koehrer Mathias. Cc: stable-rt@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Steven Rostedt --- mm/slub.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 8d8a3a641f0b..8ca44623dba7 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1347,10 +1347,8 @@ static void setup_object(struct kmem_cache *s, struct page *page, void *object) { setup_object_debug(s, page, object); -#ifndef CONFIG_PREEMPT_RT_FULL if (unlikely(s->ctor)) s->ctor(object); -#endif } static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node) @@ -2446,10 +2444,6 @@ redo: if (unlikely(gfpflags & __GFP_ZERO) && object) memset(object, 0, s->object_size); -#ifdef CONFIG_PREEMPT_RT_FULL - if (unlikely(s->ctor) && object) - s->ctor(object); -#endif slab_post_alloc_hook(s, gfpflags, object); -- 2.4.6