From: Daniel Vetter Subject: Re: [PATCH 1/3] drm: atomic-helper: Implement drm_atomic_helper_duplicate_state() Date: Tue, 11 Aug 2015 13:49:55 +0200 Message-ID: <20150811114955.GT17734@phenom.ffwll.local> References: <1439293065-15941-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 328666E405 for ; Tue, 11 Aug 2015 04:49:59 -0700 (PDT) Received: by wicne3 with SMTP id ne3so57277204wic.0 for ; Tue, 11 Aug 2015 04:49:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1439293065-15941-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMTEsIDIwMTUgYXQgMDE6Mzc6NDNQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBU aGlzIGZ1bmN0aW9uIGNhbiBiZSB1c2VkIHRvIGR1cGxpY2F0ZSBhbiBhdG9taWMgc3RhdGUgb2Jq ZWN0LiBUaGlzIGlzCj4gdXNlZnVsIGZvciBleGFtcGxlIHRvIGltcGxlbWVudCBzdXNwZW5kL3Jl c3VtZSwgd2hlcmUgdGhlIHN0YXRlIGJlZm9yZQo+IHN1c3BlbmQgY2FuIGJlIHNhdmVkIGFuZCBy ZXN0b3JlZCB1cG9uIHJlc3VtZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUaGllcnJ5IFJlZGluZyA8 dHJlZGluZ0BudmlkaWEuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuYyB8IDkwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5j bHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaCAgICAgfCAgMiArCj4gIDIgZmlsZXMgY2hhbmdl ZCwgOTIgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4g aW5kZXggZmQwNjU5NWMyZWU1Li5mODQyNDk5Y2E3OWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYwo+IEBAIC0yMzU4LDYgKzIzNTgsOTYgQEAgZHJtX2F0b21pY19oZWxwZXJf Y29ubmVjdG9yX2R1cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y KQo+ICBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kdXBsaWNhdGVf c3RhdGUpOwo+ICAKPiAgLyoqCj4gKyAqIGRybV9hdG9taWNfaGVscGVyX2R1cGxpY2F0ZV9zdGF0 ZSAtIGR1cGxpY2F0ZSBhbiBhdG9taWMgc3RhdGUgb2JqZWN0Cj4gKyAqIEBkZXY6IERSTSBkZXZp Y2UKPiArICoKPiArICogTWFrZXMgYSBjb3B5IG9mIHRoZSBjdXJyZW50IGF0b21pYyBzdGF0ZSBi eSBsb29waW5nIG92ZXIgYWxsIG9iamVjdHMgYW5kCj4gKyAqIGR1cGxpY2F0aW5nIHRoZWlyIHJl c3BlY3RpdmUgc3RhdGVzLgoKVGhpcyBuZWVkcyBhIGJpZyB3YXJuaW5nIHRoYXQgZHJpdmVycyBi ZXR0ZXIga25vdyB3aGF0IHRoZXkncmUgZG9pbmcgZm9yCnR3byByZWFzb25zOiBJdCBwcm9taXNl cyB0aGF0IGF0b21pYyBzdGF0ZXMgY2FuIGJlIHRyZWF0ZWQgYXMgcGVyc2lzdGVudApiaXRzIChl LmcuIGlmIGEgZHJpdmVyIGhhcyBhbiB1cGRhdGUtY291bnRlciBzb21ld2hlcmUgdGhhdCB3b24n dCB3b3JrKS4KQW5kIGl0IGRyb3BzIGxvY2tzIGFnYWluIHNvIHdpbGwgcmFjZSBpZiB0aGF0J3Mg bm90IG90aGVyd2lzZSBleGNsdWRlZAoobGlrZSBpbiBzdXNwZW5kL3Jlc3VtZSB3aGVyZSBub3Ro aW5nIGVsc2UgaXMgYWxsb3dlZCB0byBydW4gaWYgeW91IHNodXQKZG93biBmYmNvbiB3aXRoIGZi ZGV2X3NldF9zdXNwZW5kKCkgYmVmb3JlIGNhbGxpbmcgdGhpcyBmdW5jdGlvbikuCgpNYXliZSBu ZWVkcyBzb21lIHJld29yZGluZywgYnV0IGFsbCBvZiB0aGUgYWJvdmUgKGluY2x1ZGluZyBkZXRh aWxzIGxpa2UKZmJkZXZfc2V0X3N1c3BlbmQpIG11c3QgYmUgbWVudGlvbmVkLgoKPiArICoKPiAr ICogUmV0dXJuczogQSBwb2ludGVyIHRvIHRoZSBjb3B5IG9mIHRoZSBhdG9taWMgc3RhdGUgb2Jq ZWN0IG9uIHN1Y2Nlc3Mgb3IgYW4KPiArICogRVJSX1BUUigpLWVuY29kZWQgZXJyb3IgY29kZSBv biBmYWlsdXJlLgo+ICsgKi8KPiArc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKgo+ICtkcm1fYXRv bWljX2hlbHBlcl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiArewo+ ICsJc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4IGN0eDsKPiArCXN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZTsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uOwo+ICsJc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gKwlpbnQg ZXJyOwo+ICsKPiArCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+ICsJaWYg KCFzdGF0ZSkKPiArCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKPiArCj4gKwlkcm1fbW9kZXNl dF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4gKwlzdGF0ZS0+YWNxdWlyZV9jdHggPSAmY3R4Owo+ ICsKPiArCWVyciA9IGRybV9tb2Rlc2V0X2xvY2soJmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlv bl9tdXRleCwgJmN0eCk7Cj4gKwlpZiAoZXJyIDwgMCkKPiArCQlnb3RvIGZyZWU7CgpKdXN0IHVz ZSBkcm1fbW9kZXNldF9sb2NrX2FsbC4gWW91IG5lZWQgdGhlbSBhbGwgYW55d2F5IGFuZCBmb3IK c3VzcGVuZC9yZXN1bWUgdGhlcmUgd29uJ3QgYmUgYW55IGNvbnRlbnRpb24gYW55d2F5LgoKT3Ro ZXJ3aXNlIGxndG0uCi1EYW5pZWwKCj4gKwo+ICsJZHJtX2Zvcl9lYWNoX2NydGMoY3J0YywgZGV2 KSB7Cj4gKwkJdW5zaWduZWQgaW50IGluZGV4ID0gZHJtX2NydGNfaW5kZXgoY3J0Yyk7Cj4gKwkJ c3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ICsKPiArCQljcnRjX3N0YXRlID0g Y3J0Yy0+ZnVuY3MtPmF0b21pY19kdXBsaWNhdGVfc3RhdGUoY3J0Yyk7Cj4gKwkJaWYgKCFjcnRj X3N0YXRlKSB7Cj4gKwkJCWVyciA9IC1FTk9NRU07Cj4gKwkJCWdvdG8gdW5sb2NrOwo+ICsJCX0K PiArCj4gKwkJc3RhdGUtPmNydGNfc3RhdGVzW2luZGV4XSA9IGNydGNfc3RhdGU7Cj4gKwkJc3Rh dGUtPmNydGNzW2luZGV4XSA9IGNydGM7Cj4gKwkJY3J0Y19zdGF0ZS0+c3RhdGUgPSBzdGF0ZTsK PiArCX0KPiArCj4gKwlkcm1fZm9yX2VhY2hfcGxhbmUocGxhbmUsIGRldikgewo+ICsJCXVuc2ln bmVkIGludCBpbmRleCA9IGRybV9wbGFuZV9pbmRleChwbGFuZSk7Cj4gKwkJc3RydWN0IGRybV9w bGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGU7Cj4gKwo+ICsJCXBsYW5lX3N0YXRlID0gcGxhbmUtPmZ1 bmNzLT5hdG9taWNfZHVwbGljYXRlX3N0YXRlKHBsYW5lKTsKPiArCQlpZiAoIXBsYW5lX3N0YXRl KSB7Cj4gKwkJCWVyciA9IC1FTk9NRU07Cj4gKwkJCWdvdG8gdW5sb2NrOwo+ICsJCX0KPiArCj4g KwkJc3RhdGUtPnBsYW5lX3N0YXRlc1tpbmRleF0gPSBwbGFuZV9zdGF0ZTsKPiArCQlzdGF0ZS0+ cGxhbmVzW2luZGV4XSA9IHBsYW5lOwo+ICsJCXBsYW5lX3N0YXRlLT5zdGF0ZSA9IHN0YXRlOwo+ ICsJfQo+ICsKPiArCWRybV9mb3JfZWFjaF9jb25uZWN0b3IoY29ubiwgZGV2KSB7Cj4gKwkJdW5z aWduZWQgaW50IGluZGV4ID0gZHJtX2Nvbm5lY3Rvcl9pbmRleChjb25uKTsKPiArCQlzdHJ1Y3Qg ZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsKPiArCj4gKwkJY29ubl9zdGF0ZSA9IGNv bm4tPmZ1bmNzLT5hdG9taWNfZHVwbGljYXRlX3N0YXRlKGNvbm4pOwo+ICsJCWlmICghY29ubl9z dGF0ZSkgewo+ICsJCQllcnIgPSAtRU5PTUVNOwo+ICsJCQlnb3RvIHVubG9jazsKPiArCQl9Cj4g Kwo+ICsJCXN0YXRlLT5jb25uZWN0b3Jfc3RhdGVzW2luZGV4XSA9IGNvbm5fc3RhdGU7Cj4gKwkJ c3RhdGUtPmNvbm5lY3RvcnNbaW5kZXhdID0gY29ubjsKPiArCQljb25uX3N0YXRlLT5zdGF0ZSA9 IHN0YXRlOwo+ICsJfQo+ICsKPiArdW5sb2NrOgo+ICsJZHJtX21vZGVzZXRfZHJvcF9sb2Nrcygm Y3R4KTsKPiArZnJlZToKPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiArCj4g KwlpZiAoZXJyIDwgMCkgewo+ICsJCWRybV9hdG9taWNfc3RhdGVfZnJlZShzdGF0ZSk7Cj4gKwkJ c3RhdGUgPSBFUlJfUFRSKGVycik7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIHN0YXRlOwo+ICt9Cj4g K0VYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfZHVwbGljYXRlX3N0YXRlKTsKPiArCj4g Ky8qKgo+ICAgKiBfX2RybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kZXN0cm95X3N0YXRlIC0g cmVsZWFzZSBjb25uZWN0b3Igc3RhdGUKPiAgICogQGNvbm5lY3RvcjogY29ubmVjdG9yIG9iamVj dAo+ICAgKiBAc3RhdGU6IGNvbm5lY3RvciBzdGF0ZSBvYmplY3QgdG8gcmVsZWFzZQo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJt X2F0b21pY19oZWxwZXIuaAo+IGluZGV4IDRmZmU5ZGNhMDdjNC4uNWQyNzYxMjk5N2NlIDEwMDY0 NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgKPiArKysgYi9pbmNsdWRl L2RybS9kcm1fYXRvbWljX2hlbHBlci5oCj4gQEAgLTExOCw2ICsxMTgsOCBAQCBfX2RybV9hdG9t aWNfaGVscGVyX2Nvbm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvciwKPiAgCQkJCQkgICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqc3RhdGUp Owo+ICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqCj4gIGRybV9hdG9taWNfaGVscGVyX2Nv bm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rvcik7 Cj4gK3N0cnVjdCBkcm1fYXRvbWljX3N0YXRlICoKPiArZHJtX2F0b21pY19oZWxwZXJfZHVwbGlj YXRlX3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICB2b2lkCj4gIF9fZHJtX2F0b21p Y19oZWxwZXJfY29ubmVjdG9yX2Rlc3Ryb3lfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNv bm5lY3RvciwKPiAgCQkJCQkgICAgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKnN0YXRlKTsK PiAtLSAKPiAyLjQuNQo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==