From: Daniel Vetter Subject: Re: [PATCH 1/3] drm: atomic-helper: Implement drm_atomic_helper_duplicate_state() Date: Tue, 11 Aug 2015 13:52:29 +0200 Message-ID: <20150811115228.GU17734@phenom.ffwll.local> References: <1439293065-15941-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 014026E4CD for ; Tue, 11 Aug 2015 04:52:33 -0700 (PDT) Received: by wicne3 with SMTP id ne3so173326604wic.1 for ; Tue, 11 Aug 2015 04:52:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1439293065-15941-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMTEsIDIwMTUgYXQgMDE6Mzc6NDNQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBU aGlzIGZ1bmN0aW9uIGNhbiBiZSB1c2VkIHRvIGR1cGxpY2F0ZSBhbiBhdG9taWMgc3RhdGUgb2Jq ZWN0LiBUaGlzIGlzCj4gdXNlZnVsIGZvciBleGFtcGxlIHRvIGltcGxlbWVudCBzdXNwZW5kL3Jl c3VtZSwgd2hlcmUgdGhlIHN0YXRlIGJlZm9yZQo+IHN1c3BlbmQgY2FuIGJlIHNhdmVkIGFuZCBy ZXN0b3JlZCB1cG9uIHJlc3VtZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUaGllcnJ5IFJlZGluZyA8 dHJlZGluZ0BudmlkaWEuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuYyB8IDkwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5j bHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaCAgICAgfCAgMiArCj4gIDIgZmlsZXMgY2hhbmdl ZCwgOTIgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4g aW5kZXggZmQwNjU5NWMyZWU1Li5mODQyNDk5Y2E3OWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuYwo+IEBAIC0yMzU4LDYgKzIzNTgsOTYgQEAgZHJtX2F0b21pY19oZWxwZXJf Y29ubmVjdG9yX2R1cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y KQo+ICBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kdXBsaWNhdGVf c3RhdGUpOwo+ICAKPiAgLyoqCj4gKyAqIGRybV9hdG9taWNfaGVscGVyX2R1cGxpY2F0ZV9zdGF0 ZSAtIGR1cGxpY2F0ZSBhbiBhdG9taWMgc3RhdGUgb2JqZWN0Cj4gKyAqIEBkZXY6IERSTSBkZXZp Y2UKPiArICoKPiArICogTWFrZXMgYSBjb3B5IG9mIHRoZSBjdXJyZW50IGF0b21pYyBzdGF0ZSBi eSBsb29waW5nIG92ZXIgYWxsIG9iamVjdHMgYW5kCj4gKyAqIGR1cGxpY2F0aW5nIHRoZWlyIHJl c3BlY3RpdmUgc3RhdGVzLgo+ICsgKgo+ICsgKiBSZXR1cm5zOiBBIHBvaW50ZXIgdG8gdGhlIGNv cHkgb2YgdGhlIGF0b21pYyBzdGF0ZSBvYmplY3Qgb24gc3VjY2VzcyBvciBhbgo+ICsgKiBFUlJf UFRSKCktZW5jb2RlZCBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCj4gKyAqLwo+ICtzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqCj4gK2RybV9hdG9taWNfaGVscGVyX2R1cGxpY2F0ZV9zdGF0ZShzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9j dHggY3R4Owo+ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ICsJc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm47Cj4gKwlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiArCXN0cnVj dCBkcm1fY3J0YyAqY3J0YzsKPiArCWludCBlcnI7Cj4gKwo+ICsJc3RhdGUgPSBkcm1fYXRvbWlj X3N0YXRlX2FsbG9jKGRldik7Cj4gKwlpZiAoIXN0YXRlKQo+ICsJCXJldHVybiBFUlJfUFRSKC1F Tk9NRU0pOwo+ICsKPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfaW5pdCgmY3R4LCAwKTsKPiArCXN0 YXRlLT5hY3F1aXJlX2N0eCA9ICZjdHg7Cj4gKwo+ICsJZXJyID0gZHJtX21vZGVzZXRfbG9jaygm ZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4LCAmY3R4KTsKPiArCWlmIChlcnIgPCAw KQo+ICsJCWdvdG8gZnJlZTsKPiArCj4gKwlkcm1fZm9yX2VhY2hfY3J0YyhjcnRjLCBkZXYpIHsK PiArCQl1bnNpZ25lZCBpbnQgaW5kZXggPSBkcm1fY3J0Y19pbmRleChjcnRjKTsKPiArCQlzdHJ1 Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwo+ICsJCWNydGNfc3RhdGUgPSBjcnRj LT5mdW5jcy0+YXRvbWljX2R1cGxpY2F0ZV9zdGF0ZShjcnRjKTsKPiArCQlpZiAoIWNydGNfc3Rh dGUpIHsKPiArCQkJZXJyID0gLUVOT01FTTsKPiArCQkJZ290byB1bmxvY2s7Cj4gKwkJfQo+ICsK PiArCQlzdGF0ZS0+Y3J0Y19zdGF0ZXNbaW5kZXhdID0gY3J0Y19zdGF0ZTsKPiArCQlzdGF0ZS0+ Y3J0Y3NbaW5kZXhdID0gY3J0YzsKPiArCQljcnRjX3N0YXRlLT5zdGF0ZSA9IHN0YXRlOwo+ICsJ fQo+ICsKPiArCWRybV9mb3JfZWFjaF9wbGFuZShwbGFuZSwgZGV2KSB7Cj4gKwkJdW5zaWduZWQg aW50IGluZGV4ID0gZHJtX3BsYW5lX2luZGV4KHBsYW5lKTsKPiArCQlzdHJ1Y3QgZHJtX3BsYW5l X3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCj4gKwkJcGxhbmVfc3RhdGUgPSBwbGFuZS0+ZnVuY3Mt PmF0b21pY19kdXBsaWNhdGVfc3RhdGUocGxhbmUpOwo+ICsJCWlmICghcGxhbmVfc3RhdGUpIHsK PiArCQkJZXJyID0gLUVOT01FTTsKPiArCQkJZ290byB1bmxvY2s7Cj4gKwkJfQo+ICsKPiArCQlz dGF0ZS0+cGxhbmVfc3RhdGVzW2luZGV4XSA9IHBsYW5lX3N0YXRlOwo+ICsJCXN0YXRlLT5wbGFu ZXNbaW5kZXhdID0gcGxhbmU7Cj4gKwkJcGxhbmVfc3RhdGUtPnN0YXRlID0gc3RhdGU7Cj4gKwl9 Cj4gKwo+ICsJZHJtX2Zvcl9lYWNoX2Nvbm5lY3Rvcihjb25uLCBkZXYpIHsKPiArCQl1bnNpZ25l ZCBpbnQgaW5kZXggPSBkcm1fY29ubmVjdG9yX2luZGV4KGNvbm4pOwo+ICsJCXN0cnVjdCBkcm1f Y29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlOwo+ICsKPiArCQljb25uX3N0YXRlID0gY29ubi0+ ZnVuY3MtPmF0b21pY19kdXBsaWNhdGVfc3RhdGUoY29ubik7Cj4gKwkJaWYgKCFjb25uX3N0YXRl KSB7Cj4gKwkJCWVyciA9IC1FTk9NRU07Cj4gKwkJCWdvdG8gdW5sb2NrOwo+ICsJCX0KPiArCj4g KwkJc3RhdGUtPmNvbm5lY3Rvcl9zdGF0ZXNbaW5kZXhdID0gY29ubl9zdGF0ZTsKPiArCQlzdGF0 ZS0+Y29ubmVjdG9yc1tpbmRleF0gPSBjb25uOwo+ICsJCWNvbm5fc3RhdGUtPnN0YXRlID0gc3Rh dGU7Cj4gKwl9Cj4gKwo+ICt1bmxvY2s6Cj4gKwlkcm1fbW9kZXNldF9kcm9wX2xvY2tzKCZjdHgp Owo+ICtmcmVlOgo+ICsJZHJtX21vZGVzZXRfYWNxdWlyZV9maW5pKCZjdHgpOwoKT25lIG1vcmU6 IEkgdGhpbmsgd2Ugc2hvdWxkIGNsZWFyIHN0YXRlLT5hY3F1aXJlX2N0eCBoZXJlLCBqdXN0IHRv IG1ha2UKc3VyZSBpdCdzIG5vdCBhY2NpZGVudGFsbHkgcmV1c2VkLgotRGFuaWVsCgo+ICsKPiAr CWlmIChlcnIgPCAwKSB7Cj4gKwkJZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRlKTsKPiArCQlz dGF0ZSA9IEVSUl9QVFIoZXJyKTsKPiArCX0KPiArCj4gKwlyZXR1cm4gc3RhdGU7Cj4gK30KPiAr RVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9kdXBsaWNhdGVfc3RhdGUpOwo+ICsKPiAr LyoqCj4gICAqIF9fZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2Rlc3Ryb3lfc3RhdGUgLSBy ZWxlYXNlIGNvbm5lY3RvciBzdGF0ZQo+ICAgKiBAY29ubmVjdG9yOiBjb25uZWN0b3Igb2JqZWN0 Cj4gICAqIEBzdGF0ZTogY29ubmVjdG9yIHN0YXRlIG9iamVjdCB0byByZWxlYXNlCj4gZGlmZiAt LWdpdCBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmggYi9pbmNsdWRlL2RybS9kcm1f YXRvbWljX2hlbHBlci5oCj4gaW5kZXggNGZmZTlkY2EwN2M0Li41ZDI3NjEyOTk3Y2UgMTAwNjQ0 Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUv ZHJtL2RybV9hdG9taWNfaGVscGVyLmgKPiBAQCAtMTE4LDYgKzExOCw4IEBAIF9fZHJtX2F0b21p Y19oZWxwZXJfY29ubmVjdG9yX2R1cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAq Y29ubmVjdG9yLAo+ICAJCQkJCSAgIHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpzdGF0ZSk7 Cj4gIHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICoKPiAgZHJtX2F0b21pY19oZWxwZXJfY29u bmVjdG9yX2R1cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsK PiArc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2hlbHBlcl9kdXBsaWNh dGVfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIHZvaWQKPiAgX19kcm1fYXRvbWlj X2hlbHBlcl9jb25uZWN0b3JfZGVzdHJveV9zdGF0ZShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29u bmVjdG9yLAo+ICAJCQkJCSAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqc3RhdGUpOwo+ IC0tIAo+IDIuNC41Cj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK