From: Daniel Vetter Subject: Re: [PATCH v2 2/3] drm/atomic-helper: Implement subsystem-level suspend/resume Date: Wed, 12 Aug 2015 17:06:38 +0200 Message-ID: <20150812150638.GE17734@phenom.ffwll.local> References: <1439390250-1402-1-git-send-email-thierry.reding@gmail.com> <1439390250-1402-2-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A7A86E43B for ; Wed, 12 Aug 2015 08:07:02 -0700 (PDT) Received: by wicja10 with SMTP id ja10so31293131wic.1 for ; Wed, 12 Aug 2015 08:07:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1439390250-1402-2-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMTIsIDIwMTUgYXQgMDQ6Mzc6MjlQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBQ cm92aWRlIHN1YnN5c3RlbS1sZXZlbCBzdXNwZW5kIGFuZCByZXN1bWUgaGVscGVycyB0aGF0IGNh biBiZSB1c2VkIHRvCj4gaW1wbGVtZW50IHN1c3BlbmQvcmVzdW1lIG9uIGF0b21pYyBtb2RlLXNl dHRpbmcgZW5hYmxlZCBkcml2ZXJzLgo+IAo+IHYyOiBzaW1wbGlmeSBsb2NraW5nLCBlbmhhbmNl IGtlcm5lbGRvYyBjb21tZW50cwo+IAo+IFNpZ25lZC1vZmYtYnk6IFRoaWVycnkgUmVkaW5nIDx0 cmVkaW5nQG52aWRpYS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hl bHBlci5jIHwgMTQxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNs dWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oICAgICB8ICAgNSArKwo+ICAyIGZpbGVzIGNoYW5n ZWQsIDE0NiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMK PiBpbmRleCAxZjg0ZGYzYjBhNWQuLjBlYjQ1YTdhNzYwZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jCj4gQEAgLTE3NTEsNiArMTc1MSwxNDcgQEAgYmFja29mZjoKPiAgRVhQ T1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9zZXRfY29uZmlnKTsKPiAgCj4gIC8qKgo+ICsg KiBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbCAtIGRpc2FibGUgYWxsIGN1cnJlbnRseSBh Y3RpdmUgb3V0cHV0cwo+ICsgKiBAZGV2OiBEUk0gZGV2aWNlCj4gKyAqCj4gKyAqIExvb3BzIHRo cm91Z2ggYWxsIGNvbm5lY3RvcnMsIGZpbmRpbmcgdGhvc2UgdGhhdCBhcmVuJ3QgdHVybmVkIG9m ZiBhbmQgdGhlbgo+ICsgKiB0dXJucyB0aGVtIG9mZiBieSBzZXR0aW5nIHRoZWlyIERQTVMgbW9k ZSB0byBPRkYgYW5kIGRlYWN0aXZhdGluZyB0aGUgQ1JUQwo+ICsgKiB0aGF0IHRoZXkgYXJlIGNv bm5lY3RlZCB0by4KPiArICoKPiArICogVGhpcyBpcyB1c2VkIGZvciBleGFtcGxlIGluIHN1c3Bl bmQvcmVzdW1lIHRvIGRpc2FibGUgYWxsIGN1cnJlbnRseSBhY3RpdmUKPiArICogZnVuY3Rpb25z IHdoZW4gc3VzcGVuZGluZy4gU2VlIGRybV9hdG9taWNfaGVscGVyX3N1c3BlbmQoKS4KCkkgdGhp bmsgYW4gYW5hbG9nIHBhcmFncmFwaCBzaG91bGQgYmUgYWRkZWQgdG8gZHVwbGljYXRlX3N0YXRl KCksIG1heWJlIGluCnRoaXMgcGF0Y2g/Cgo+ICsgKgo+ICsgKiBSZXR1cm5zOgo+ICsgKiAwIG9u IHN1Y2Nlc3Mgb3IgYSBuZWdhdGl2ZSBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCgpQbGVhc2UgYWRk IHRoZSBzYW1lIGNhdmVhdCBhYm91dCBsb2NraW5nIGxpa2UgZm9yIGR1cGxpY2F0ZV9zdGF0ZSBo ZXJlLgoKPiArICovCj4gK2ludCBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbChzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICpjb25maWcg PSAmZGV2LT5tb2RlX2NvbmZpZzsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25u X3N0YXRlOwo+ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ICsJc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm47Cj4gKwl1bnNpZ25lZCBpbnQgaTsKPiArCWludCBlcnI7Cj4gKwo+ ICsJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4gKwlpZiAoIXN0YXRlKQo+ ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCXN0YXRlLT5hY3F1aXJlX2N0eCA9IGNvbmZpZy0+ YWNxdWlyZV9jdHg7CgpTYW1lIGNvbW1lbnQgYWJvdXQgcmV1c2luZyB0aGUgaGlkZGVuIGFjcXVp cmVfY3R4OiBQbGVhc2UgZG9uJ3QgYW5kCmluc3RlYWQgbWFrZSBpdCBhbiBleHBsaWNpdCBwYXJh bXRlci4KCj4gKwo+ICsJZHJtX2Zvcl9lYWNoX2Nvbm5lY3Rvcihjb25uLCBkZXYpIHsKPiArCQlz dHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBjb25uLT5zdGF0ZS0+Y3J0YzsKPiArCQlzdHJ1Y3QgZHJt X2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwo+ICsJCWlmICghY3J0YyB8fCBjb25uLT5kcG1z ICE9IERSTV9NT0RFX0RQTVNfT04pCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiArCQljcnRjX3N0YXRl ID0gZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gKwkJaWYgKElTX0VS UihjcnRjX3N0YXRlKSkgewo+ICsJCQllcnIgPSBQVFJfRVJSKGNydGNfc3RhdGUpOwo+ICsJCQln b3RvIGZyZWU7Cj4gKwkJfQo+ICsKPiArCQllcnIgPSBkcm1fYXRvbWljX2FkZF9hZmZlY3RlZF9j b25uZWN0b3JzKHN0YXRlLCBjcnRjKTsKPiArCQlpZiAoZXJyIDwgMCkKPiArCQkJZ290byBmcmVl Owo+ICsKPiArCQljb25uLT5kcG1zID0gRFJNX01PREVfRFBNU19PRkY7Cj4gKwkJY3J0Y19zdGF0 ZS0+YWN0aXZlID0gZmFsc2U7Cj4gKwl9Cj4gKwo+ICsJZXJyID0gZHJtX2F0b21pY19jb21taXQo c3RhdGUpOwo+ICsJaWYgKGVyciA8IDApIHsKPiArCQkvKiByZXN0b3JlIERQTVMgbW9kZSAqLwo+ ICsJCWZvcl9lYWNoX2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0ZSwgY29ubiwgY29ubl9zdGF0ZSwg aSkKPiArCQkJY29ubi0+ZHBtcyA9IERSTV9NT0RFX0RQTVNfT047Cj4gKwo+ICsJCWdvdG8gZnJl ZTsKPiArCX0KPiArCj4gK2ZyZWU6Cj4gKwlpZiAoZXJyIDwgMCkKPiArCQlkcm1fYXRvbWljX3N0 YXRlX2ZyZWUoc3RhdGUpOwo+ICsKPiArCXJldHVybiBlcnI7Cj4gK30KPiArRVhQT1JUX1NZTUJP TChkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbCk7Cj4gKwo+ICsvKioKPiArICogZHJtX2F0 b21pY19oZWxwZXJfc3VzcGVuZCAtIHN1YnN5c3RlbS1sZXZlbCBzdXNwZW5kIGhlbHBlcgo+ICsg KiBAZGV2OiBEUk0gZGV2aWNlCj4gKyAqCj4gKyAqIER1cGxpY2F0ZXMgdGhlIGN1cnJlbnQgYXRv bWljIHN0YXRlLCBkaXNhYmxlcyBhbGwgYWN0aXZlIG91dHB1dHMgYW5kIHRoZW4KPiArICogcmV0 dXJucyBhIHBvaW50ZXIgdG8gdGhlIG9yaWdpbmFsIGF0b21pYyBzdGF0ZSB0byB0aGUgY2FsbGVy LiBEcml2ZXJzIGNhbgo+ICsgKiBwYXNzIHRoaXMgcG9pbnRlciB0byB0aGUgZHJtX2F0b21pY19o ZWxwZXJfcmVzdW1lKCkgaGVscGVyIHVwb24gcmVzdW1lIHRvCj4gKyAqIHJlc3RvcmUgdGhlIG91 dHB1dCBjb25maWd1cmF0aW9uIHRoYXQgd2FzIGFjdGl2ZSBhdCB0aGUgdGltZSB0aGUgc3lzdGVt Cj4gKyAqIGVudGVyZWQgc3VzcGVuZC4KCkknZCBtZW50aW9uIHRoZSB0d28gaGVscGVycyBleHBs aWNpdGx5IHNvIHRoYXQgdGhleSBhbGwgZ2V0IGxpbmtlZCB1cCBoZXJlCmluIHRoZSBrZXJuZWxk b2MgKGkuZS4gZHVwbGljYXRlX3N0YXRlKCkgYW5kIGRpc2FibGVfYWxsKCkpLgoKbGd0bSBvdGhl cndpc2UuCi1EYW5pZWwKCj4gKyAqCj4gKyAqIE5vdGUgdGhhdCBpdCBpcyBwb3RlbnRpYWxseSB1 bnNhZmUgdG8gdXNlIHRoaXMuIFRoZSBhdG9taWMgc3RhdGUgb2JqZWN0Cj4gKyAqIHJldHVybmVk IGJ5IHRoaXMgZnVuY3Rpb24gaXMgYXNzdW1lZCB0byBiZSBwZXJzaXN0ZW50LiBEcml2ZXJzIG11 c3QgZW5zdXJlCj4gKyAqIHRoYXQgdGhpcyBob2xkcyB0cnVlLiBCZWZvcmUgY2FsbGluZyB0aGlz IGZ1bmN0aW9uLCBkcml2ZXJzIG11c3QgbWFrZSBzdXJlCj4gKyAqIHRvIHN1c3BlbmQgZmJkZXYg ZW11bGF0aW9uIHNvIHRoYXQgbm90aGluZyBjYW4gYmUgdXNpbmcgdGhlIGRldmljZS4KPiArICoK PiArICogUmV0dXJuczoKPiArICogQSBwb2ludGVyIHRvIGEgY29weSBvZiB0aGUgc3RhdGUgYmVm b3JlIHN1c3BlbmQgb24gc3VjY2VzcyBvciBhbiBFUlJfUFRSKCktCj4gKyAqIGVuY29kZWQgZXJy b3IgY29kZSBvbiBmYWlsdXJlLiBEcml2ZXJzIHNob3VsZCBzdG9yZSB0aGUgcmV0dXJuZWQgYXRv bWljCj4gKyAqIHN0YXRlIG9iamVjdCBhbmQgcGFzcyBpdCB0byB0aGUgZHJtX2F0b21pY19oZWxw ZXJfcmVzdW1lKCkgaGVscGVyIHVwb24KPiArICogcmVzdW1lLgo+ICsgKi8KPiArc3RydWN0IGRy bV9hdG9taWNfc3RhdGUgKmRybV9hdG9taWNfaGVscGVyX3N1c3BlbmQoc3RydWN0IGRybV9kZXZp Y2UgKmRldikKPiArewo+ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ICsJaW50 IGVycjsKPiArCj4gKwlkcm1fbW9kZXNldF9sb2NrX2FsbChkZXYpOwo+ICsKPiArCXN0YXRlID0g ZHJtX2F0b21pY19oZWxwZXJfZHVwbGljYXRlX3N0YXRlKGRldik7Cj4gKwlpZiAoSVNfRVJSKHN0 YXRlKSkKPiArCQlnb3RvIHVubG9jazsKPiArCj4gKwllcnIgPSBkcm1fYXRvbWljX2hlbHBlcl9k aXNhYmxlX2FsbChkZXYpOwo+ICsJaWYgKGVyciA8IDApIHsKPiArCQlkcm1fYXRvbWljX3N0YXRl X2ZyZWUoc3RhdGUpOwo+ICsJCXN0YXRlID0gRVJSX1BUUihlcnIpOwo+ICsJCWdvdG8gdW5sb2Nr Owo+ICsJfQo+ICsKPiArdW5sb2NrOgo+ICsJZHJtX21vZGVzZXRfdW5sb2NrX2FsbChkZXYpOwo+ ICsJcmV0dXJuIHN0YXRlOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJf c3VzcGVuZCk7Cj4gKwo+ICsvKioKPiArICogZHJtX2F0b21pY19oZWxwZXJfcmVzdW1lIC0gc3Vi c3lzdGVtLWxldmVsIHJlc3VtZSBoZWxwZXIKPiArICogQGRldjogRFJNIGRldmljZQo+ICsgKiBA c3RhdGU6IGF0b21pYyBzdGF0ZSB0byByZXN1bWUgdG8KPiArICoKPiArICogQ2FsbHMgZHJtX21v ZGVfY29uZmlnX3Jlc2V0KCkgdG8gc3luY2hyb25pemUgaGFyZHdhcmUgYW5kIHNvZnR3YXJlIHN0 YXRlcywKPiArICogZ3JhYnMgYWxsIG1vZGVzZXQgbG9ja3MgYW5kIGNvbW1pdHMgdGhlIGF0b21p YyBzdGF0ZSBvYmplY3QuIFRoaXMgY2FuIGJlCj4gKyAqIHVzZWQgaW4gY29uanVuY3Rpb24gd2l0 aCB0aGUgZHJtX2F0b21pY19oZWxwZXJfc3VzcGVuZCgpIGhlbHBlciB0bwo+ICsgKiBpbXBsZW1l bnQgc3VzcGVuZC9yZXN1bWUgZm9yIGRyaXZlcnMgdGhhdCBzdXBwb3J0IGF0b21pYyBtb2RlLXNl dHRpbmcuCj4gKyAqCj4gKyAqIFJldHVybnM6Cj4gKyAqIDAgb24gc3VjY2VzcyBvciBhIG5lZ2F0 aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiArICovCj4gK2ludCBkcm1fYXRvbWljX2hlbHBl cl9yZXN1bWUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiArCQkJICAgICBzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBkcm1fbW9kZV9jb25maWcgKmNvbmZp ZyA9ICZkZXYtPm1vZGVfY29uZmlnOwo+ICsJaW50IGVycjsKPiArCj4gKwlkcm1fbW9kZV9jb25m aWdfcmVzZXQoZGV2KTsKPiArCWRybV9tb2Rlc2V0X2xvY2tfYWxsKGRldik7Cj4gKwlzdGF0ZS0+ YWNxdWlyZV9jdHggPSBjb25maWctPmFjcXVpcmVfY3R4Owo+ICsJZXJyID0gZHJtX2F0b21pY19j b21taXQoc3RhdGUpOwo+ICsJZHJtX21vZGVzZXRfdW5sb2NrX2FsbChkZXYpOwo+ICsKPiArCXJl dHVybiBlcnI7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9yZXN1bWUp Owo+ICsKPiArLyoqCj4gICAqIGRybV9hdG9taWNfaGVscGVyX2NydGNfc2V0X3Byb3BlcnR5IC0g aGVscGVyIGZvciBjcnRjIHByb3BlcnRpZXMKPiAgICogQGNydGM6IERSTSBjcnRjCj4gICAqIEBw cm9wZXJ0eTogRFJNIHByb3BlcnR5Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmggYi9pbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oCj4gaW5kZXggNWQy NzYxMjk5N2NlLi4wODBmMTMxYzlmMmUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2F0 b21pY19oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgKPiBA QCAtNzUsNiArNzUsMTEgQEAgaW50IGRybV9hdG9taWNfaGVscGVyX3VwZGF0ZV9wbGFuZShzdHJ1 Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgaW50IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfcGxh bmUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpOwo+ICBpbnQgZHJtX2F0b21pY19oZWxwZXJfc2V0 X2NvbmZpZyhzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQpOwo+ICAKPiAraW50IGRybV9hdG9taWNf aGVscGVyX2Rpc2FibGVfYWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICtzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqZHJtX2F0b21pY19oZWxwZXJfc3VzcGVuZChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KTsKPiAraW50IGRybV9hdG9taWNfaGVscGVyX3Jlc3VtZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LAo+ICsJCQkgICAgIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSk7Cj4gKwo+ ICBpbnQgZHJtX2F0b21pY19oZWxwZXJfY3J0Y19zZXRfcHJvcGVydHkoc3RydWN0IGRybV9jcnRj ICpjcnRjLAo+ICAJCQkJCXN0cnVjdCBkcm1fcHJvcGVydHkgKnByb3BlcnR5LAo+ICAJCQkJCXVp bnQ2NF90IHZhbCk7Cj4gLS0gCj4gMi40LjUKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJl IEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=