From: Daniel Vetter Subject: Re: [PATCH 08/13] drm/irq: Check for valid VBLANK before dereference Date: Wed, 12 Aug 2015 17:40:11 +0200 Message-ID: <20150812154011.GN17734@phenom.ffwll.local> References: <1439391635-29166-1-git-send-email-thierry.reding@gmail.com> <1439391635-29166-8-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27ABB6E204 for ; Wed, 12 Aug 2015 08:40:16 -0700 (PDT) Received: by wicja10 with SMTP id ja10so117976039wic.1 for ; Wed, 12 Aug 2015 08:40:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1439391635-29166-8-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMTIsIDIwMTUgYXQgMDU6MDA6MzBQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBX aGVuIGFjY2Vzc2luZyB0aGUgYXJyYXkgb2YgcGVyLUNSVEMgVkJMQU5LIHN0cnVjdHVyZXMgd2Ug bXVzdCBhbHdheXMKPiBjaGVjayB0aGF0IHRoZSBpbmRleCBpbnRvIHRoZSBhcnJheSBpcyB2YWxp ZCBiZWZvcmUgZGVyZWZlcmVuY2luZyB0bwo+IGF2b2lkIGNyYXNoaW5nLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+CgpUaGlzIG1pc3NlcyB2 YmxhbmtfcmVzZXQgKEkgZ3Vlc3MgdGhhdCBmdW5jdGlvbiBpcyBuZXdlciB0aGFuIHlvdXIKcGF0 Y2hlcykuIENhbiB5b3UgcGxlYXNlIGRvIGEgZm9sbG93LXVwPyBJIG1lcmdlZCB0aGlzIG9uZSBt ZWFud2hpbGUuCgpJIGFsc28gc3F1YXNoZWQgaW4gYSB3aGl0ZXNwYWNlIGZpeHVwIGluIHZibGFu a19jb3VudCBJIHNwb3R0ZWQgd2hpbGUKcmV2aWV3aW5nIHRoaXMgb25lIGhlcmUuCi1EYW5pZWwK Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMgfCAxMCArKysrKysrKy0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ly cS5jCj4gaW5kZXggNWM2NjZjNzgwZmU5Li5hOTU3Yjk2MThlODUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9pcnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMK PiBAQCAtMTExMCwxMCArMTExMCwxMCBAQCB2b2lkIGRybV92YmxhbmtfcHV0KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsIGludCBjcnRjKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX3ZibGFua19jcnRjICp2 YmxhbmsgPSAmZGV2LT52YmxhbmtbY3J0Y107Cj4gIAo+IC0JaWYgKFdBUk5fT04oYXRvbWljX3Jl YWQoJnZibGFuay0+cmVmY291bnQpID09IDApKQo+ICsJaWYgKFdBUk5fT04oY3J0YyA+PSBkZXYt Pm51bV9jcnRjcykpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCWlmIChXQVJOX09OKGNydGMgPj0gZGV2 LT5udW1fY3J0Y3MpKQo+ICsJaWYgKFdBUk5fT04oYXRvbWljX3JlYWQoJnZibGFuay0+cmVmY291 bnQpID09IDApKQo+ICAJCXJldHVybjsKPiAgCj4gIAkvKiBMYXN0IHVzZXIgc2NoZWR1bGVzIGlu dGVycnVwdCBkaXNhYmxlICovCj4gQEAgLTExNTgsNiArMTE1OCw5IEBAIHZvaWQgZHJtX3dhaXRf b25lX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgY3J0YykKPiAgCWludCByZXQ7 Cj4gIAl1MzIgbGFzdDsKPiAgCj4gKwlpZiAoV0FSTl9PTihjcnRjID49IGRldi0+bnVtX2NydGNz KSkKPiArCQlyZXR1cm47Cj4gKwo+ICAJcmV0ID0gZHJtX3ZibGFua19nZXQoZGV2LCBjcnRjKTsK PiAgCWlmIChXQVJOKHJldCwgInZibGFuayBub3QgYXZhaWxhYmxlIG9uIGNydGMgJWksIHJldD0l aVxuIiwgY3J0YywgcmV0KSkKPiAgCQlyZXR1cm47Cj4gQEAgLTE0MjgsNiArMTQzMSw5IEBAIHZv aWQgZHJtX3ZibGFua19wb3N0X21vZGVzZXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGNy dGMpCj4gIAlpZiAoIWRldi0+bnVtX2NydGNzKQo+ICAJCXJldHVybjsKPiAgCj4gKwlpZiAoV0FS Tl9PTihjcnRjID49IGRldi0+bnVtX2NydGNzKSkKPiArCQlyZXR1cm47Cj4gKwo+ICAJaWYgKHZi bGFuay0+aW5tb2Rlc2V0KSB7Cj4gIAkJc3Bpbl9sb2NrX2lycXNhdmUoJmRldi0+dmJsX2xvY2ss IGlycWZsYWdzKTsKPiAgCQlkZXYtPnZibGFua19kaXNhYmxlX2FsbG93ZWQgPSB0cnVlOwo+IC0t IAo+IDIuNC41Cj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwg Q29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK