From: Tom Rini Date: Thu, 20 Aug 2015 12:51:17 -0400 Subject: [U-Boot] [PATCH] net: Return -1 when ctrl+c is pressed In-Reply-To: <55D5C4DF.3010906@monstr.eu> References: <55D5C4DF.3010906@monstr.eu> Message-ID: <20150820165117.GR25532@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Aug 20, 2015 at 02:15:27PM +0200, Michal Simek wrote: > On 08/13/2015 09:46 AM, Michal Simek wrote: > > Current behavior is that if CTRL+C is pressed command returns 0 that was > > successful which is not correct behavior. > > The easiest test case is "tftpboot 80000 uImage && echo yes" > > and press CTRL+C. Then the second command is called which is incorrect. > > > > Error log: > > zynq-uboot> tftpb 80000 uImage && echo yes > > Gem.e000b000:7 is connected to Gem.e000b000. Reconnecting to > > Gem.e000b000 > > Gem.e000b000 Waiting for PHY auto negotiation to complete....... done > > Using Gem.e000b000 device > > TFTP from server 192.168.0.102; our IP address is 192.168.0.101 > > Filename 'uImage'. > > Load address: 0x80000 > > Loading: ################ > > Abort > > yes > > zynq-uboot> > > > > This patch adds -1 return value when CTRL+C is pressed. > > > > Signed-off-by: Michal Simek > > --- > > > > Not sure if -1 is the right error code but I have parsed the code and it > > looks like that -1 is standard behavior for CTRL+C. But I am happy to > > change this behavior. > > > > --- > > net/net.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/net/net.c b/net/net.c > > index 67e0ad297cf5..738a0db8c2ba 100644 > > --- a/net/net.c > > +++ b/net/net.c > > @@ -565,6 +565,7 @@ restart: > > /* include a debug print as well incase the debug > > messages are directed to stderr */ > > debug_cond(DEBUG_INT_STATE, "--- net_loop Abort!\n"); > > + ret = -1; > > goto done; > > } > > > > > > Joe, Tom: Any update on this one? Reviewed-by: Tom Rini Joe, do you want to pick this up? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: