From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Change SRM, LRM instructions to use correct length Date: Wed, 26 Aug 2015 08:45:49 +0200 Message-ID: <20150826064549.GM20434@phenom.ffwll.local> References: <1437059974-26575-1-git-send-email-arun.siluvery@linux.intel.com> <1438701740-32793-1-git-send-email-arun.siluvery@linux.intel.com> <87fv3fbdcq.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id A28066E540 for ; Tue, 25 Aug 2015 23:45:53 -0700 (PDT) Received: by widdq5 with SMTP id dq5so36128419wid.1 for ; Tue, 25 Aug 2015 23:45:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87fv3fbdcq.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMTksIDIwMTUgYXQgMDQ6NDY6MTNQTSArMDMwMCwgTWlrYSBLdW9wcGFsYSB3 cm90ZToKPiBBcnVuIFNpbHV2ZXJ5IDxhcnVuLnNpbHV2ZXJ5QGxpbnV4LmludGVsLmNvbT4gd3Jp dGVzOgo+IAo+ID4gTUlfU1RPUkVfUkVHSVNURVJfTUVNLCBNSV9MT0FEX1JFR0lTVEVSX01FTSBp bnN0cnVjdGlvbnMgYXJlIG5vdCByZWFsbHkKPiA+IHZhcmlhYmxlIGxlbmd0aCBpbnN0cnVjdGlv bnMgdW5saWtlIE1JX0xPQURfUkVHSVNURVJfSU1NIHdoZXJlIGl0IGV4cGVjdHMKPiA+IChyZWcs IGFkZHIpIHBhaXJzIHNvIHVzZSBmaXhlZCBsZW5ndGggZm9yIHRoZXNlIGluc3RydWN0aW9ucy4K PiA+Cj4gPiB2MjogcmViYXNlCj4gPgo+ID4gQ2M6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRv bkBpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBcnVuIFNpbHV2ZXJ5IDxhcnVuLnNpbHV2 ZXJ5QGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfY21kX3BhcnNlci5jIHwgOCArKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcmVnLmggICAgICAgIHwgOCArKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYyAgIHwgNCArKy0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMgICAgICAgfCA0ICsrLS0KPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMo KyksIDEyIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2NtZF9wYXJzZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfY21kX3Bh cnNlci5jCj4gPiBpbmRleCA0MzA1NzFiLi4zNzcxOTIyIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9jbWRfcGFyc2VyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfY21kX3BhcnNlci5jCj4gPiBAQCAtMTI0LDE0ICsxMjQsMTQgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBkcm1faTkxNV9jbWRfZGVzY3JpcHRvciBjb21tb25fY21kc1tdID0gewo+ ID4gIAlDTUQoICBNSV9TVE9SRV9EV09SRF9JTkRFWCwgICAgICAgICAgICAgU01JLCAgICFGLCAg MHhGRiwgICBSICApLAo+ID4gIAlDTUQoICBNSV9MT0FEX1JFR0lTVEVSX0lNTSgxKSwgICAgICAg ICAgU01JLCAgICFGLCAgMHhGRiwgICBXLAo+ID4gIAkgICAgICAucmVnID0geyAub2Zmc2V0ID0g MSwgLm1hc2sgPSAweDAwN0ZGRkZDLCAuc3RlcCA9IDIgfSAgICApLAo+ID4gLQlDTUQoICBNSV9T VE9SRV9SRUdJU1RFUl9NRU0oMSksICAgICAgICAgU01JLCAgICFGLCAgMHhGRiwgICBXIHwgQiwK PiA+ICsJQ01EKCAgTUlfU1RPUkVfUkVHSVNURVJfTUVNLCAgICAgICAgICAgIFNNSSwgICAgRiwg IDEsICAgICBXIHwgQiwKPiA+ICAJICAgICAgLnJlZyA9IHsgLm9mZnNldCA9IDEsIC5tYXNrID0g MHgwMDdGRkZGQyB9LAo+ID4gIAkgICAgICAuYml0cyA9IHt7Cj4gPiAgCQkJLm9mZnNldCA9IDAs Cj4gPiAgCQkJLm1hc2sgPSBNSV9HTE9CQUxfR1RULAo+ID4gIAkJCS5leHBlY3RlZCA9IDAsCj4g PiAgCSAgICAgIH19LAkJCQkJCSAgICAgICApLAo+ID4gLQlDTUQoICBNSV9MT0FEX1JFR0lTVEVS X01FTSgxKSwgICAgICAgICAgICAgU01JLCAgICFGLCAgMHhGRiwgICBXIHwgQiwKPiA+ICsJQ01E KCAgTUlfTE9BRF9SRUdJU1RFUl9NRU0sICAgICAgICAgICAgIFNNSSwgICAgRiwgIDEsICAgICBX IHwgQiwKPiA+ICAJICAgICAgLnJlZyA9IHsgLm9mZnNldCA9IDEsIC5tYXNrID0gMHgwMDdGRkZG QyB9LAo+ID4gIAkgICAgICAuYml0cyA9IHt7Cj4gPiAgCQkJLm9mZnNldCA9IDAsCj4gPiBAQCAt MTAyMSw3ICsxMDIxLDcgQEAgc3RhdGljIGJvb2wgY2hlY2tfY21kKGNvbnN0IHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKnJpbmcsCj4gPiAgCQkJICogb25seSBNSV9MT0FEX1JFR0lTVEVSX0lNTSBj b21tYW5kcy4KPiA+ICAJCQkgKi8KPiA+ICAJCQlpZiAocmVnX2FkZHIgPT0gT0FDT05UUk9MKSB7 Cj4gPiAtCQkJCWlmIChkZXNjLT5jbWQudmFsdWUgPT0gTUlfTE9BRF9SRUdJU1RFUl9NRU0oMSkp IHsKPiA+ICsJCQkJaWYgKGRlc2MtPmNtZC52YWx1ZSA9PSBNSV9MT0FEX1JFR0lTVEVSX01FTSkg ewo+ID4gIAkJCQkJRFJNX0RFQlVHX0RSSVZFUigiQ01EOiBSZWplY3RlZCBMUk0gdG8gT0FDT05U Uk9MXG4iKTsKPiA+ICAJCQkJCXJldHVybiBmYWxzZTsKPiA+ICAJCQkJfQo+ID4gQEAgLTEwMzUs NyArMTAzNSw3IEBAIHN0YXRpYyBib29sIGNoZWNrX2NtZChjb25zdCBzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICpyaW5nLAo+ID4gIAkJCSAqIGFsbG93ZWQgbWFzay92YWx1ZSBwYWlyIGdpdmVuIGlu IHRoZSB3aGl0ZWxpc3QgZW50cnkuCj4gPiAgCQkJICovCj4gPiAgCQkJaWYgKHJlZy0+bWFzaykg ewo+ID4gLQkJCQlpZiAoZGVzYy0+Y21kLnZhbHVlID09IE1JX0xPQURfUkVHSVNURVJfTUVNKDEp KSB7Cj4gPiArCQkJCWlmIChkZXNjLT5jbWQudmFsdWUgPT0gTUlfTE9BRF9SRUdJU1RFUl9NRU0p IHsKPiA+ICAJCQkJCURSTV9ERUJVR19EUklWRVIoIkNNRDogUmVqZWN0ZWQgTFJNIHRvIG1hc2tl ZCByZWdpc3RlciAweCUwOFhcbiIsCj4gPiAgCQkJCQkJCSByZWdfYWRkcik7Cj4gPiAgCQkJCQly ZXR1cm4gZmFsc2U7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9y ZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+IGluZGV4IDgyNzcxNGMu LmUxYTg4NzYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5o Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiBAQCAtMzQzLDgg KzM0Myw4IEBACj4gPiAgICovCj4gPiAgI2RlZmluZSBNSV9MT0FEX1JFR0lTVEVSX0lNTSh4KQlN SV9JTlNUUigweDIyLCAyKih4KS0xKQo+ID4gICNkZWZpbmUgICBNSV9MUklfRk9SQ0VfUE9TVEVE CQkoMTw8MTIpCj4gPiAtI2RlZmluZSBNSV9TVE9SRV9SRUdJU1RFUl9NRU0oeCkgTUlfSU5TVFIo MHgyNCwgMiooeCktMSkKPiA+IC0jZGVmaW5lIE1JX1NUT1JFX1JFR0lTVEVSX01FTV9HRU44KHgp IE1JX0lOU1RSKDB4MjQsIDMqKHgpLTEpCj4gPiArI2RlZmluZSBNSV9TVE9SRV9SRUdJU1RFUl9N RU0gICAgICAgIE1JX0lOU1RSKDB4MjQsIDEpCj4gPiArI2RlZmluZSBNSV9TVE9SRV9SRUdJU1RF Ul9NRU1fR0VOOCAgIE1JX0lOU1RSKDB4MjQsIDIpCj4gPiAgI2RlZmluZSAgIE1JX1NSTV9MUk1f R0xPQkFMX0dUVAkJKDE8PDIyKQo+ID4gICNkZWZpbmUgTUlfRkxVU0hfRFcJCU1JX0lOU1RSKDB4 MjYsIDEpIC8qIGZvciBHRU42ICovCj4gPiAgI2RlZmluZSAgIE1JX0ZMVVNIX0RXX1NUT1JFX0lO REVYCSgxPDwyMSkKPiA+IEBAIC0zNTUsOCArMzU1LDggQEAKPiA+ICAjZGVmaW5lICAgTUlfSU5W QUxJREFURV9CU0QJCSgxPDw3KQo+ID4gICNkZWZpbmUgICBNSV9GTFVTSF9EV19VU0VfR1RUCQko MTw8MikKPiA+ICAjZGVmaW5lICAgTUlfRkxVU0hfRFdfVVNFX1BQR1RUCQkoMDw8MikKPiA+IC0j ZGVmaW5lIE1JX0xPQURfUkVHSVNURVJfTUVNKHgpIE1JX0lOU1RSKDB4MjksIDIqKHgpLTEpCj4g PiAtI2RlZmluZSBNSV9MT0FEX1JFR0lTVEVSX01FTV9HRU44KHgpIE1JX0lOU1RSKDB4MjksIDMq KHgpLTEpCj4gPiArI2RlZmluZSBNSV9MT0FEX1JFR0lTVEVSX01FTSAJICAgTUlfSU5TVFIoMHgy OSwgMSkKPiA+ICsjZGVmaW5lIE1JX0xPQURfUkVHSVNURVJfTUVNX0dFTjggIE1JX0lOU1RSKDB4 MjksIDIpCj4gCj4gTWlub3Igbml0cGljazogY2hlY2twYXRjaCBjb21wbGFpbmVkIGFib3V0IHRo ZXJlIGJlaW5nIHNwYWNlIGJlZm9yZQo+IHRhYiBpbiBoZXJlLgoKRml4ZWQgYW5kIGFwcGxpZWQu IEFzaWRlOiBpOTE1X2NtZF9wYXJzZXIuYyBtYWtlcyBjaGVja3BhdGNoIGZhaXJseQp1bmhhcHB5 LCBtaWdodCBiZSB3b3J0aCBmaXhpbmcuCi1EYW5pZWwKCj4gUmV2aWV3ZWQtYnk6IE1pa2EgS3Vv cHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgo+IAo+ID4gICNkZWZpbmUgTUlfQkFUQ0hf QlVGRkVSCQlNSV9JTlNUUigweDMwLCAxKQo+ID4gICNkZWZpbmUgICBNSV9CQVRDSF9OT05fU0VD VVJFCQkoMSkKPiA+ICAvKiBmb3Igc25iL2l2Yi92bHYgdGhpcyBhbHNvIG1lYW5zICJiYXRjaCBp biBwcGd0dCIgd2hlbiBwcGd0dCBpcyBlbmFibGVkLiAqLwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggYWYwYmNmZS4uZThmMWM5NSAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMTExMjMsMTAgKzExMTIzLDEwIEBA IHN0YXRpYyBpbnQgaW50ZWxfZ2VuN19xdWV1ZV9mbGlwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs Cj4gPiAgCQkJCQlERVJSTVJfUElQRUJfUFJJX0ZMSVBfRE9ORSB8Cj4gPiAgCQkJCQlERVJSTVJf UElQRUNfUFJJX0ZMSVBfRE9ORSkpOwo+ID4gIAkJaWYgKElTX0dFTjgoZGV2KSkKPiA+IC0JCQlp bnRlbF9yaW5nX2VtaXQocmluZywgTUlfU1RPUkVfUkVHSVNURVJfTUVNX0dFTjgoMSkgfAo+ID4g KwkJCWludGVsX3JpbmdfZW1pdChyaW5nLCBNSV9TVE9SRV9SRUdJU1RFUl9NRU1fR0VOOCB8Cj4g PiAgCQkJCQkgICAgICBNSV9TUk1fTFJNX0dMT0JBTF9HVFQpOwo+ID4gIAkJZWxzZQo+ID4gLQkJ CWludGVsX3JpbmdfZW1pdChyaW5nLCBNSV9TVE9SRV9SRUdJU1RFUl9NRU0oMSkgfAo+ID4gKwkJ CWludGVsX3JpbmdfZW1pdChyaW5nLCBNSV9TVE9SRV9SRUdJU1RFUl9NRU0gfAo+ID4gIAkJCQkJ ICAgICAgTUlfU1JNX0xSTV9HTE9CQUxfR1RUKTsKPiA+ICAJCWludGVsX3JpbmdfZW1pdChyaW5n LCBERVJSTVIpOwo+ID4gIAkJaW50ZWxfcmluZ19lbWl0KHJpbmcsIHJpbmctPnNjcmF0Y2guZ3R0 X29mZnNldCArIDI1Nik7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ID4gaW5kZXggZDNh MDNmMy4uOTlhNzgyMCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ID4gQEAg LTExMDYsNyArMTEwNiw3IEBAIHN0YXRpYyBpbmxpbmUgaW50IGdlbjhfZW1pdF9mbHVzaF9jb2hl cmVudGwzX3dhKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsCj4gPiAgCWlmIChJU19TS1lM QUtFKHJpbmctPmRldikgJiYgSU5URUxfUkVWSUQocmluZy0+ZGV2KSA8PSBTS0xfUkVWSURfRTAp Cj4gPiAgCQlsM3NxYzRfZmx1c2ggfD0gR0VOOF9MUVNDX1JPX1BFUkZfRElTOwo+ID4gIAo+ID4g LQl3YV9jdHhfZW1pdChiYXRjaCwgaW5kZXgsIChNSV9TVE9SRV9SRUdJU1RFUl9NRU1fR0VOOCgx KSB8Cj4gPiArCXdhX2N0eF9lbWl0KGJhdGNoLCBpbmRleCwgKE1JX1NUT1JFX1JFR0lTVEVSX01F TV9HRU44IHwKPiA+ICAJCQkJICAgTUlfU1JNX0xSTV9HTE9CQUxfR1RUKSk7Cj4gPiAgCXdhX2N0 eF9lbWl0KGJhdGNoLCBpbmRleCwgR0VOOF9MM1NRQ1JFRzQpOwo+ID4gIAl3YV9jdHhfZW1pdChi YXRjaCwgaW5kZXgsIHJpbmctPnNjcmF0Y2guZ3R0X29mZnNldCArIDI1Nik7Cj4gPiBAQCAtMTEy NCw3ICsxMTI0LDcgQEAgc3RhdGljIGlubGluZSBpbnQgZ2VuOF9lbWl0X2ZsdXNoX2NvaGVyZW50 bDNfd2Eoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiA+ICAJd2FfY3R4X2VtaXQoYmF0 Y2gsIGluZGV4LCAwKTsKPiA+ICAJd2FfY3R4X2VtaXQoYmF0Y2gsIGluZGV4LCAwKTsKPiA+ICAK PiA+IC0Jd2FfY3R4X2VtaXQoYmF0Y2gsIGluZGV4LCAoTUlfTE9BRF9SRUdJU1RFUl9NRU1fR0VO OCgxKSB8Cj4gPiArCXdhX2N0eF9lbWl0KGJhdGNoLCBpbmRleCwgKE1JX0xPQURfUkVHSVNURVJf TUVNX0dFTjggfAo+ID4gIAkJCQkgICBNSV9TUk1fTFJNX0dMT0JBTF9HVFQpKTsKPiA+ICAJd2Ff Y3R4X2VtaXQoYmF0Y2gsIGluZGV4LCBHRU44X0wzU1FDUkVHNCk7Cj4gPiAgCXdhX2N0eF9lbWl0 KGJhdGNoLCBpbmRleCwgcmluZy0+c2NyYXRjaC5ndHRfb2Zmc2V0ICsgMjU2KTsKPiA+IC0tIAo+ ID4gMS45LjEKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==