Received: from eggs.gnu.org ([2001:4830:134:3::10]:57218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXSOM-0003ub-Bw for qemu-devel@nongnu.org; Thu, 03 Sep 2015 07:09:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXSOI-0004GS-Av for qemu-devel@nongnu.org; Thu, 03 Sep 2015 07:09:18 -0400 Received: from mail-ob0-x22c.google.com ([2607:f8b0:4003:c01::22c]:35181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXSOI-0004GO-65 for qemu-devel@nongnu.org; Thu, 03 Sep 2015 07:09:14 -0400 Received: by obuk4 with SMTP id k4so29272470obu.2 for ; Thu, 03 Sep 2015 04:09:13 -0700 (PDT) Date: Thu, 3 Sep 2015 13:09:10 +0200 From: "Edgar E. Iglesias" Message-ID: <20150903110909.GB15790@toto> References: <1441230361-3184-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441230361-3184-1-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH] target-microblaze: Use setcond for pcmp* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Wed, Sep 02, 2015 at 02:46:01PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias I've added this to my MB queue, thanks. Cheers, Edgar > --- > This was originally posted back in February. I failed to keep > any reply, if any, that may have been given. There's no change > to the code after updating to mainline. > > > r~ > --- > target-microblaze/translate.c | 23 ++++------------------- > 1 file changed, 4 insertions(+), 19 deletions(-) > > diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c > index 47ac180..d4d9a8a 100644 > --- a/target-microblaze/translate.c > +++ b/target-microblaze/translate.c > @@ -313,7 +313,6 @@ static void dec_sub(DisasContext *dc) > static void dec_pattern(DisasContext *dc) > { > unsigned int mode; > - TCGLabel *l1; > > if ((dc->tb_flags & MSR_EE_FLAG) > && (dc->cpu->env.pvr.regs[2] & PVR2_ILL_OPCODE_EXC_MASK) > @@ -333,29 +332,15 @@ static void dec_pattern(DisasContext *dc) > case 2: > LOG_DIS("pcmpeq r%d r%d r%d\n", dc->rd, dc->ra, dc->rb); > if (dc->rd) { > - TCGv t0 = tcg_temp_local_new(); > - l1 = gen_new_label(); > - tcg_gen_movi_tl(t0, 1); > - tcg_gen_brcond_tl(TCG_COND_EQ, > - cpu_R[dc->ra], cpu_R[dc->rb], l1); > - tcg_gen_movi_tl(t0, 0); > - gen_set_label(l1); > - tcg_gen_mov_tl(cpu_R[dc->rd], t0); > - tcg_temp_free(t0); > + tcg_gen_setcond_tl(TCG_COND_EQ, cpu_R[dc->rd], > + cpu_R[dc->ra], cpu_R[dc->rb]); > } > break; > case 3: > LOG_DIS("pcmpne r%d r%d r%d\n", dc->rd, dc->ra, dc->rb); > - l1 = gen_new_label(); > if (dc->rd) { > - TCGv t0 = tcg_temp_local_new(); > - tcg_gen_movi_tl(t0, 1); > - tcg_gen_brcond_tl(TCG_COND_NE, > - cpu_R[dc->ra], cpu_R[dc->rb], l1); > - tcg_gen_movi_tl(t0, 0); > - gen_set_label(l1); > - tcg_gen_mov_tl(cpu_R[dc->rd], t0); > - tcg_temp_free(t0); > + tcg_gen_setcond_tl(TCG_COND_NE, cpu_R[dc->rd], > + cpu_R[dc->ra], cpu_R[dc->rb]); > } > break; > default: > -- > 2.4.3 >