Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 2A8491A0163 for ; Tue, 8 Sep 2015 22:05:01 +1000 (AEST) In-Reply-To: <20150902153928.GB47557@linux.vnet.ibm.com> To: Nishanth Aravamudan , Alexey Kardashevskiy From: Michael Ellerman Cc: Wei Yang , Gavin Shan , Paul Mackerras , Hari Bathini , linuxppc-dev@lists.ozlabs.org, David Gibson Subject: Re: [v2] powerpc/powernv/pci-ioda: fix 32-bit TCE table init in kdump kernel Message-Id: <20150908120501.13340140129@ozlabs.org> Date: Tue, 8 Sep 2015 22:05:01 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2015-02-09 at 15:39:28 UTC, Nishanth Aravamudan wrote: > When attempting to kdump with the 4.2 kernel, we see for each PCI > device: > > pci 0003:01 : [PE# 000] Assign DMA32 space > pci 0003:01 : [PE# 000] Setting up 32-bit TCE table at 0..80000000 > pci 0003:01 : [PE# 000] Failed to create 32-bit TCE table, err -22 > is a valid sanity check for pnv_pci_ioda2_table_alloc_pages(), so adjust > the caller to pass in a smaller window size if our maximum memory value > is smaller than the DMA window. > > After this change, the PCI devices successfully set up the 32-bit TCE > table and kdump succeeds. > > The problem was seen on a Firestone machine originally. > > Fixes: aca6913f5551 ("powerpc/powernv/ioda2: Introduce helpers to allocate TCE pages") > Signed-off-by: Nishanth Aravamudan > Reviewed-by: Alexey Kardashevskiy Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/bb0054552d080dd929907c59 cheers