Received: from eggs.gnu.org ([2001:4830:134:3::10]:53881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZhVl-0003zg-Li for qemu-devel@nongnu.org; Wed, 09 Sep 2015 11:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZhVi-0004GB-Ly for qemu-devel@nongnu.org; Wed, 09 Sep 2015 11:42:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZhVi-0004G0-Hb for qemu-devel@nongnu.org; Wed, 09 Sep 2015 11:42:10 -0400 Date: Wed, 9 Sep 2015 12:42:07 -0300 From: Eduardo Habkost Message-ID: <20150909154207.GG3574@thinpad.lan.raisama.net> References: <10d59855527f68bfaa90e74ec45b0da50ce5463a.1441627175.git.DirtY.iCE.hu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <10d59855527f68bfaa90e74ec45b0da50ce5463a.1441627175.git.DirtY.iCE.hu@gmail.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/7] qapi: convert NumaOptions into a flat union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= Cc: qemu-devel@nongnu.org, Markus Armbruster On Mon, Sep 07, 2015 at 02:08:07PM +0200, K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1= n wrote: [...] > diff --git a/qapi-schema.json b/qapi-schema.json > index 67fef37..9e4fe5d 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3550,17 +3550,6 @@ > 'data': { '*console':'int', 'events': [ 'InputEvent' ] } } > =20 > ## > -# @NumaOptions > -# > -# A discriminated record of NUMA options. (for OptsVisitor) > -# > -# Since 2.1 > -## > -{ 'union': 'NumaOptions', > - 'data': { > - 'node': 'NumaNodeOptions' }} > - > -## > # @NumaNodeOptions > # > # Create a guest NUMA node. (for OptsVisitor) > @@ -3587,6 +3576,42 @@ > '*memdev': 'str' }} > =20 > ## > +# @NumaOptionType > +# > +# List of possible numa drivers. There's no such thing as a "numa driver". The type name was fixed but the documentation still doesn't make sense. I suggest: # NUMA command-line option type. # # @node: Create a guest NUMA node. See @NumaNodeOptions. > +# > +# Since: 2.5 > +## > +{ 'enum': 'NumaOptionType', > + 'data': [ 'node' ] } > + > +## > +# @NumaCommonOptions > +# > +# Common set of numa options. > +# > +# @type: the numa driver to use Suggestion: # @type: NUMA command-line option type. --=20 Eduardo