Received: from eggs.gnu.org ([2001:4830:134:3::10]:40260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZlb9-0002Kc-Dr for qemu-devel@nongnu.org; Wed, 09 Sep 2015 16:04:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZlb6-00056u-6m for qemu-devel@nongnu.org; Wed, 09 Sep 2015 16:04:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZlb6-00056f-2B for qemu-devel@nongnu.org; Wed, 09 Sep 2015 16:04:00 -0400 Date: Wed, 9 Sep 2015 17:03:56 -0300 From: Eduardo Habkost Message-ID: <20150909200356.GA11100@thinpad.lan.raisama.net> References: <1441626932-76366-1-git-send-email-imammedo@redhat.com> <1441626932-76366-2-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441626932-76366-2-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserved-memory-end List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: bharata@linux.vnet.ibm.com, qemu-devel@nongnu.org, mst@redhat.com On Mon, Sep 07, 2015 at 01:55:31PM +0200, Igor Mammedov wrote: > reserved-memory-end tells firmware address from which > it could start treating memory as PCI address space > and map PCI BARs after it to avoid collisions with > RAM. > Currently it is incorrectly pointing to address where > hotplugged memory range starts which could redirect > hotplugged RAM accesses to PCI BARs when firmware > maps them over RAM or viceverse. > Fix this by pointing reserved-memory-end to the end > of memory hotplug area. > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost But I would like to see this squashed into patch 2/2 (or the rebased version of patch 2/2) to keep bisectability. -- Eduardo