From: Wei Liu Subject: Re: [v2][PATCH] xen/vtd/iommu: permit group devices to passthrough in relaxed mode Date: Tue, 15 Sep 2015 10:13:08 +0100 Message-ID: <20150915091308.GI2294@zion.uk.xensource.com> References: <55EFF3CE02000078000A1150@prv-mh.provo.novell.com> <55F156E302000078000A18B4@prv-mh.provo.novell.com> <20150910103720.GG8496@zion.uk.xensource.com> <55F2B34202000078000A201A@prv-mh.provo.novell.com> <55F66839.6030501@intel.com> <55F6C22F02000078000A283A@prv-mh.provo.novell.com> <55F77193.6090303@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <55F77193.6090303@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Chen, Tiejun" Cc: Yang Z Zhang , Kevin Tian , Wei Liu , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Tue, Sep 15, 2015 at 09:17:07AM +0800, Chen, Tiejun wrote: > >>But looks its not better, so any idea? > > > >Did you at least make an attempt to find other examples of where > >we dynamically determine the log level to be used for a message? > >I would assume that if you did, you'd have come to > > > > printk(XENLOG_GUEST "%s" VTDPREFIX > > I didn't know this tip on Xen side and its really good. > > > " It's %s to assign %04x:%02x:%02x.%u" > > " with shared RMRR at %"PRIx64" for Dom%d.\n", > > relaxed ? XENLOG_WARNING : XENLOG_ERROR, > > relaxed ? "risky" : "disallowed", > > seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn), > > rmrr->base_address, d->domain_id); > > > >pretty naturally. > > > > But I noticed my original patch is already merged into staging. So > > Wei, > > Do you think if we need a small patch to improved this? Maybe you can squash > that if necessary. Feel free to send follow-up patch to improve logging message. Wei. > > Thanks > Tiejun