From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915/ddi: use switch case instead of if ladder for ddi_get_encoder_port Date: Tue, 29 Sep 2015 11:10:19 +0200 Message-ID: <20150929091019.GJ3383@phenom.ffwll.local> References: <1443511466-8017-1-git-send-email-jani.nikula@intel.com> <1443511466-8017-2-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AC476E18D for ; Tue, 29 Sep 2015 02:07:25 -0700 (PDT) Received: by wicfx3 with SMTP id fx3so140158305wic.1 for ; Tue, 29 Sep 2015 02:07:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1443511466-8017-2-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMjksIDIwMTUgYXQgMTA6MjQ6MjZBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gTWFrZSB0aGUgYWx0ZXJuYXRpdmVzIHN0YW5kICBvdXQgYmV0dGVyLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgpCb3RoIGFwcGxp ZWQgdG8gZGlucS4KLURhbmllbAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGRpLmMgfCAyMCArKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5z ZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ IGluZGV4IGZkY2I0NTYyYzhjZS4uMmI1YTI5ODE3ZTJlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmMKPiBAQCAtMzA5LDIwICszMDksMjYgQEAgc3RhdGljIHZvaWQgZGRpX2dldF9lbmNv ZGVyX3BvcnQoc3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIsCj4gIAkJCQkgZW51 bSBwb3J0ICpwb3J0KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIgPSAmaW50 ZWxfZW5jb2Rlci0+YmFzZTsKPiAtCWludCB0eXBlID0gaW50ZWxfZW5jb2Rlci0+dHlwZTsKPiAg Cj4gLQlpZiAodHlwZSA9PSBJTlRFTF9PVVRQVVRfRFBfTVNUKSB7Cj4gKwlzd2l0Y2ggKGludGVs X2VuY29kZXItPnR5cGUpIHsKPiArCWNhc2UgSU5URUxfT1VUUFVUX0RQX01TVDoKPiAgCQkqZGln X3BvcnQgPSBlbmNfdG9fbXN0KGVuY29kZXIpLT5wcmltYXJ5Owo+ICAJCSpwb3J0ID0gKCpkaWdf cG9ydCktPnBvcnQ7Cj4gLQl9IGVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0RJU1BMQVlQ T1JUIHx8IHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCB8fAo+IC0JICAgIHR5cGUgPT0gSU5URUxf T1VUUFVUX0hETUkgfHwgdHlwZSA9PSBJTlRFTF9PVVRQVVRfVU5LTk9XTikgewo+ICsJCWJyZWFr Owo+ICsJY2FzZSBJTlRFTF9PVVRQVVRfRElTUExBWVBPUlQ6Cj4gKwljYXNlIElOVEVMX09VVFBV VF9FRFA6Cj4gKwljYXNlIElOVEVMX09VVFBVVF9IRE1JOgo+ICsJY2FzZSBJTlRFTF9PVVRQVVRf VU5LTk9XTjoKPiAgCQkqZGlnX3BvcnQgPSBlbmNfdG9fZGlnX3BvcnQoZW5jb2Rlcik7Cj4gIAkJ KnBvcnQgPSAoKmRpZ19wb3J0KS0+cG9ydDsKPiAtCX0gZWxzZSBpZiAodHlwZSA9PSBJTlRFTF9P VVRQVVRfQU5BTE9HKSB7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIElOVEVMX09VVFBVVF9BTkFMT0c6 Cj4gIAkJKmRpZ19wb3J0ID0gTlVMTDsKPiAgCQkqcG9ydCA9IFBPUlRfRTsKPiAtCX0gZWxzZSB7 Cj4gLQkJV0FSTigxLCAiSW52YWxpZCBEREkgZW5jb2RlciB0eXBlICVkXG4iLCB0eXBlKTsKPiAr CQlicmVhazsKPiArCWRlZmF1bHQ6Cj4gKwkJV0FSTigxLCAiSW52YWxpZCBEREkgZW5jb2RlciB0 eXBlICVkXG4iLCBpbnRlbF9lbmNvZGVyLT50eXBlKTsKPiArCQlicmVhazsKPiAgCX0KPiAgfQo+ ICAKPiAtLSAKPiAyLjEuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK