From: Wolfgang Denk Date: Thu, 01 Oct 2015 16:22:05 +0200 Subject: [U-Boot] [ANN] U-Boot v2015.10-rc4 released In-Reply-To: References: <20150928210901.GH22966@bill-the-cat> <560C1233.3000300@writeme.com> <560C18FC.2000501@freescale.com> <560C1A4D.3070509@writeme.com> <560C23B5.7060104@writeme.com> <560C2AFF.4080502@writeme.com> Message-ID: <20151001142205.2B4DA3822C0@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Fabio, In message you wrote: > > Ok, the issue is due to endianness: on LS1021 the watchdog is > big-endian, so that's why we can't use clrsetbits_le16(). ... > + int reg; > > - clrsetbits_le16(&wdog->wcr, 0, WCR_WDE); > + reg = readw(&wdog->wcr); > + reg |= WCR_WDE; > + writew(reg, &wdog->wcr); But this is broken. We have the clrsetbits() [*] macros exactly to avoid such code. [*] resp. setbits() - using clrsetbits*() with 0 as clear mask is a stupid thing to do anyway. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is wrong always, everywhere and for everyone to believe anything upon insufficient evidence. - W. K. Clifford, British philosopher, circa 1876