From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [OSSTEST PATCH 1/2] TestSupport.pm: allow creating
 vNUMA enabled HVM guest configs
Date: Fri, 2 Oct 2015 13:18:05 +0100
Message-ID: <20151002121805.GD30122@zion.uk.xensource.com>
References: <20151001230750.15271.26071.stgit@Solace.station>
	<20151001231731.15271.87986.stgit@Solace.station>
	<20151002113242.GA30122@zion.uk.xensource.com>
	<1443787335.14525.62.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7101e345a=wei.liu2@citrix.com>)
	id 1ZhzHt-0003cg-JD
	for xen-devel@lists.xenproject.org; Fri, 02 Oct 2015 12:18:09 +0000
Content-Disposition: inline
In-Reply-To: <1443787335.14525.62.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Dario Faggioli <dario.faggioli@ctirix.com>, xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Oct 02, 2015 at 02:02:15PM +0200, Dario Faggioli wrote:
> On Fri, 2015-10-02 at 12:32 +0100, Wei Liu wrote:
> > On Fri, Oct 02, 2015 at 01:17:31AM +0200, Dario Faggioli wrote:
> 
> > > diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> > > index 2b67e32..bf8bd56 100644
> > > --- a/Osstest/TestSupport.pm
> > > +++ b/Osstest/TestSupport.pm
> > > @@ -1709,6 +1709,34 @@ sub prepareguest_part_xencfg ($$$$$) {
> 
> > > +        # Let's put all vnodes on pnode 0, as we don't even know
> > > (for now)
> > > +        # whether or not the host has more NUMA nodes than that!
> > > +        @vnuma_pnode = (0) x $vnuma_nodes;
> > > +
> > 
> > The thing I worry about putting everything in node 0 is that if we
> > somehow has hardware that has several nodes but each node has
> > relative
> > small amount of ram it would cause this test case to fail.
> > 
> ISWYM.
> 
> > In the current arrangement, HVM guest gets 5G of ram if OSSTest
> > determines the host has enough (2x5G + slack) ram for it.  So vnuma
> > test
> > case will fail on a box with 4 nodes but has 16G of ram. Is such
> > hardware configuration not very likely to exist?
> > 
> Well, 16GB is a rather small amount of RAM for a box with 4 nodes, IMO.
> 
> However, I think your point is valid... I think I can, in case
> vnuma_nodes is provided, overrun $ram_mb with something more likely to
> fit on one physical node?
> 
> Unfortunately, it's not something we can check precisely, because, in
> Xen, there is (yet) no mechanism to know, in case we have XX free RAM
> (apart from parsing the console output after issuing `xl debug-key u',
> which is really really unpractical!), how many of it actually comes
> from each NUMA ndoe... but I can apply a bit of guessing.
> 

What about `xl info -n`. That should be easier to parse?

> What do you think?
> 
> Regards,
> Dario
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>