From: Christoph Hellwig Date: Sun, 04 Oct 2015 06:36:13 +0000 Subject: Re: [patch - Nicholas's tree] netconsole: Missing unlock on error path Message-Id: <20151004063613.GB13199@lst.de> List-Id: References: <20151003190524.GA766@mwanda> In-Reply-To: <20151003190524.GA766@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Tejun Heo , Christoph Hellwig , Andrew Morton , Nicholas Bellinger , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, Oct 03, 2015 at 10:05:24PM +0300, Dan Carpenter wrote: > We added new locking to this function but we missed one error path which > needs an unlock. > > Fixes: cdacad4993f4 ('netconsole: use per-attribute show and store methods') > Signed-off-by: Dan Carpenter > --- > This is going through Nicholas Bellinger's tree not net-next. Hi Dan, this was fixed a while ago, I'm actually surpised it was still in the patches Nic merged. My repost from earlier yesterday should have fixed it.