Received-SPF: pass (google.com: domain of sudipm.mukherjee@gmail.com designates 2607:f8b0:400e:c03::233 as permitted sender) client-ip=2607:f8b0:400e:c03::233;
Date: Tue, 6 Oct 2015 09:57:23 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Alison Schofield <amsfield22@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8712: fix comparison test
 warnings
Message-ID: <20151006042723.GB4745@sudip-pc>
References: <20151005183935.GA3350@Ubuntu-D830>
 <alpine.DEB.2.10.1510052136480.2608@hadrien>
 <20151005213849.GA3566@Ubuntu-D830>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151005213849.GA3566@Ubuntu-D830>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Mon, Oct 05, 2015 at 02:38:49PM -0700, Alison Schofield wrote:
> On Mon, Oct 05, 2015 at 09:38:28PM +0100, Julia Lawall wrote:
> > On Mon, 5 Oct 2015, Alison Schofield wrote:
> > 
> > > This patch fixes multiple instances of the checkpatch.pl warning:
> > >
> > > WARNING: Comparisons should place the constant on the right side of the
> > > test
> > 
> > Thanks for the patch, but try to avoid using "fix" in your commit message.
> > Say instead what you have done to do the fix.  Here, you could say
> > something like "Move constant to the right side of a comparison operator,
> > as suggested by checkpatch".
> > 
> > julia
> 
> Thanks for the quick review and I will check that on future patches.
> Do I need to amend and resend this one?

I think no need to resend this one. But keep in mind what Julia said in
your next patches.

regards
sudip