Received-SPF: pass (google.com: domain of sudipm.mukherjee@gmail.com designates 2607:f8b0:400e:c03::231 as permitted sender) client-ip=2607:f8b0:400e:c03::231;
Date: Wed, 7 Oct 2015 17:22:10 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH 09/10] staging: iio: adc: use BIT macro
Message-ID: <20151007115210.GB17761@sudip-pc>
References: <cover.1444172065.git.ciorneiioana@gmail.com>
 <c8e2d47eeef0c65ce13a9b2a8159a92a04686e72.1444172066.git.ciorneiioana@gmail.com>
 <20151007051736.GD4070@sudip-pc>
 <CAHWJYFkgfqMhe9CjsnnmARE_ts6_BRGDAKnxxR-C1rc+PbNLtA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHWJYFkgfqMhe9CjsnnmARE_ts6_BRGDAKnxxR-C1rc+PbNLtA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Wed, Oct 07, 2015 at 01:48:05PM +0300, Ioana Ciornei wrote:
> On Wed, Oct 7, 2015 at 8:17 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Wed, Oct 07, 2015 at 01:57:09AM +0300, Ioana Ciornei wrote:
> >> Use BIT macro instead of shifting operator in order to improve
> >> readability
> >>
> >> Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
> >> ---
> >
> > This is introducing build warnings:
> >
> > drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_complete_touch_event’:
> > drivers/staging/iio/adc/mxs-lradc.c:728:6: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> >       LRADC_DELAY(2));
> >       ^
> > drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_buffer_preenable’:
> > drivers/staging/iio/adc/mxs-lradc.c:1292:8: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> >         LRADC_DELAY_KICK, LRADC_DELAY(0));
> >         ^
> > drivers/staging/iio/adc/mxs-lradc.c: In function ‘mxs_lradc_buffer_postdisable’:
> > drivers/staging/iio/adc/mxs-lradc.c:1311:8: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> >         LRADC_DELAY_KICK, LRADC_DELAY(0));
> >         ^
> >
> 
> I did saw the build warnings when I build tested them but I really do
> not know what should I do in this case.
> The problems appear because 1UL' replaces '1' when using the BIT macro.
> In this case, should it be appropriate to just drop this patch and
> create a new patchset with just 9 patches?
Never send a patch which introduces build warnings. Better send the
series with the other 9 patches and meanwhile try to see if you can find
any possible solution to this problem. When you find the solution then
send that particular patch as a single patch.

regards
sudip