Received-SPF: pass (google.com: domain of sudipm.mukherjee@gmail.com designates 2607:f8b0:400e:c03::230 as permitted sender) client-ip=2607:f8b0:400e:c03::230;
Date: Sat, 10 Oct 2015 13:52:44 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Alison Schofield <amsfield22@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rdma: hfi1: remove
 unnecessary 'out of memory' messages
Message-ID: <20151010082244.GI4795@sudip-pc>
References: <20151010044521.GA27086@Ubuntu-D830>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151010044521.GA27086@Ubuntu-D830>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Fri, Oct 09, 2015 at 09:45:34PM -0700, Alison Schofield wrote:
> 'Out of memory' messages are unnecssary in the drivers as they are
> reported by memory management.
> 
> Addresses checkpatch.pl: WARNING: Possible unnecessary 'out of memory' message
> 
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> ---
<snip>
> diff --git a/drivers/staging/rdma/hfi1/user_sdma.c b/drivers/staging/rdma/hfi1/user_sdma.c
> index 6620262..b20cbb9 100644
> --- a/drivers/staging/rdma/hfi1/user_sdma.c
> +++ b/drivers/staging/rdma/hfi1/user_sdma.c
> @@ -378,20 +378,14 @@ int hfi1_user_sdma_alloc_queues(struct hfi1_ctxtdata *uctxt, struct file *fp)
>  	dd = uctxt->dd;
>  
>  	pq = kzalloc(sizeof(*pq), GFP_KERNEL);
> -	if (!pq) {
> -		dd_dev_err(dd,
> -			   "[%u:%u] Failed to allocate SDMA request struct\n",
> -			   uctxt->ctxt, subctxt_fp(fp));
> +	if (!pq)
>  		goto pq_nomem;
> -	}
> +
>  	memsize = sizeof(*pq->reqs) * hfi1_sdma_comp_ring_size;
>  	pq->reqs = kmalloc(memsize, GFP_KERNEL);
> -	if (!pq->reqs) {
> -		dd_dev_err(dd,
> -			   "[%u:%u] Failed to allocate SDMA request queue (%u)\n",
> -			   uctxt->ctxt, subctxt_fp(fp), memsize);
> +	if (!pq->reqs) 

trailing whitespace error here.

regards
sudip