From: Dario Faggioli Subject: [PATCH] xen: cpufreq: fix notifier block double registration Date: Mon, 12 Oct 2015 16:52:47 +0200 Message-ID: <20151012145247.13949.83606.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZleT6-0004hr-CD for xen-devel@lists.xenproject.org; Mon, 12 Oct 2015 14:52:52 +0000 Received: by wicge5 with SMTP id ge5so153718972wic.0 for ; Mon, 12 Oct 2015 07:52:50 -0700 (PDT) List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , "Wang, Wei W" , Jan Beulich List-Id: xen-devel@lists.xenproject.org As a consequence of commit 49388f11d512bb92706ce ("x86/cpufreq: relocate the driver register function") the cpufreq CPU notifier was being registered twice. That resulted in bugs when trying to offline a CPU, as reported here: https://www.mail-archive.com/xen-devel@lists.xen.org/msg41618.html Signed-off-by: Dario Faggioli --- Cc: Jan Beulich Cc: Andrew Cooper Cc: "Wang, Wei W" Cc: Konrad Rzeszutek Wilk --- xen/drivers/cpufreq/cpufreq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 81a187b..6e666e4 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -650,6 +650,5 @@ int __init cpufreq_register_driver(struct cpufreq_driver *driver_data) cpufreq_driver = driver_data; - register_cpu_notifier(&cpu_nfb); return 0; }