From: horms@verge.net.au (Simon Horman) Date: Tue, 13 Oct 2015 10:04:47 +0900 Subject: [PATCH] ARM: shmobile: porter: add QSPI DT support In-Reply-To: References: <1738678.v21ITp1gYW@wasted.cogentembedded.com> <20151012000453.GC20025@verge.net.au> Message-ID: <20151013010446.GC4836@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 12, 2015 at 08:53:26AM +0200, Geert Uytterhoeven wrote: > On Mon, Oct 12, 2015 at 2:04 AM, Simon Horman wrote: > >> + flash at 0 { > >> + #address-cells = <1>; > >> + #size-cells = <1>; > >> + compatible = "spansion,s25fl512s", "jedec,spi-nor"; > > > > spansion,s25fl512s is used in several dt files but it seems to be > > undocumented. Do we have a plan to resolve this? > > Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt: > > - compatible : May include a device-specific string consisting of the > manufacturer and name of the chip. Bear in mind the DT binding > is not Linux-only, but in case of Linux, see the "m25p_ids" > table in drivers/mtd/devices/m25p80.c for the list of supported > chips. > Must also include "jedec,spi-nor" for any SPI NOR flash that can > be identified by the JEDEC READ ID opcode (0x9F). > > Hence it's OK. Thanks, I guess checkpatch needs to learn about that rule.