Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZmOtH-0001x4-QJ for linux-mtd@lists.infradead.org; Wed, 14 Oct 2015 16:27:00 +0000 Received: by pabur7 with SMTP id ur7so9657392pab.3 for ; Wed, 14 Oct 2015 09:26:39 -0700 (PDT) Date: Wed, 14 Oct 2015 09:26:36 -0700 From: Brian Norris To: Fabio Estevam Cc: han.xu@freescale.com, linux-mtd@lists.infradead.org, Fabio Estevam Subject: Re: [PATCH] mtd: fsl-quadspi: Include to avoid build error Message-ID: <20151014162636.GH107187@google.com> References: <1444793984-21655-1-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444793984-21655-1-git-send-email-festevam@gmail.com> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 14, 2015 at 12:39:44AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Building for x86 results in the following build errors: > > drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_init_lut': > >> drivers/mtd/spi-nor/fsl-quadspi.c:355:21: error: 'SZ_16M' undeclared (first use in this function) > if (q->nor_size <= SZ_16M) { > ^ > drivers/mtd/spi-nor/fsl-quadspi.c:355:21: note: each undeclared identifier is reported only once for each function it appears in > drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_read': > >> drivers/mtd/spi-nor/fsl-quadspi.c:208:27: error: 'SZ_4M' undeclared (first use in this function) > #define QUADSPI_MIN_IOMAP SZ_4M > ^ > >> drivers/mtd/spi-nor/fsl-quadspi.c:845:25: note: in expansion of macro 'QUADSPI_MIN_IOMAP' > q->memmap_len = len > QUADSPI_MIN_IOMAP ? len : QUADSPI_MIN_IOMAP; > > Explicitly include to fix the problem. > > Reported-by: kbuild test robot > Signed-off-by: Fabio Estevam Applied to l2-mtd.git. Thanks.