Received-SPF: pass (google.com: domain of eraretuya@gmail.com designates 2607:f8b0:400e:c03::233 as permitted sender) client-ip=2607:f8b0:400e:c03::233;
Date: Mon, 19 Oct 2015 00:00:16 +0800
From: Eva Rachel Retuya <eraretuya@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: mt29f_spinand: Remove
 space after a cast
Message-ID: <20151018155912.GA3682@Socrates-Mint>
References: <20151018101529.GA6434@Socrates-Mint>
 <5200397.Z5PqNk5xTM@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5200397.Z5PqNk5xTM@wuerfel>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Sun, Oct 18, 2015 at 02:55:56PM +0200, Arnd Bergmann wrote:
> On Sunday 18 October 2015 18:16:09 Eva Rachel Retuya wrote:
> > diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
> > index 1aa449e..cf98228 100644
> > --- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
> > +++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
> > @@ -594,7 +594,7 @@ static int spinand_erase_block(struct spi_device *spi_nand, u16 block_id)
> >                 if (retval < 0) {
> >                         dev_err(&spi_nand->dev,
> >                                         "error %d reading status register\n",
> > -                                       (int) retval);
> > +                                       (int)retval);
> >                         return retval;
> 
> 
> The change is correct, but it would be nicer to remove the cast as well,
> because 'retval' is already an 'int'.
> 
> 	Arnd

Looking back, you are indeed right. Do I have to send this change as a
revision or go for a new patch? 

Thank you for pointing this out. I admit, all I did was to change the
piece of code as suggested by the checkpatch. Next time I will be more mindful of the change/s I'm introducing.

Eva