From: Daniel Vetter Subject: Re: [PATCH] drm/i915/skl: Correct other-pipe watermark update condition check Date: Mon, 19 Oct 2015 15:22:56 +0200 Message-ID: <20151019132256.GA13786@phenom.ffwll.local> References: <1442858564-27931-1-git-send-email-mahesh1.kumar@intel.com> <20151019092959.GQ13786@phenom.ffwll.local> <20151019130018.GZ26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8C8C720F9 for ; Mon, 19 Oct 2015 06:23:00 -0700 (PDT) Received: by wicfv8 with SMTP id fv8so5641067wic.0 for ; Mon, 19 Oct 2015 06:22:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20151019130018.GZ26517@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTksIDIwMTUgYXQgMDQ6MDA6MThQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIE1vbiwgT2N0IDE5LCAyMDE1IGF0IDExOjI5OjU5QU0gKzAyMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBNb24sIFNlcCAyMSwgMjAxNSBhdCAxMTozMjo0NFBNICsw NTMwLCBLdW1hciwgTWFoZXNoIHdyb3RlOgo+ID4gPiBJZiBkZGIgYWxsb2NhdGlvbiBmb3IgcGxh bmVzIGluIGN1cnJlbnQgQ1JUQyBpcyBjaGFuZ2VkLCB0aGF0IGRvZXNuJ3QKPiA+ID4gbGVhZCB0 byBkZGIgYWxsb2NhdGlvbiBjaGFuZ2UgZm9yIG90aGVyIENSVENzLCBiZWNhdXNlIG91ciBEREIg YWxsb2NhdGlvbgo+ID4gPiBpcyBub3QgZHluYW1pYyBhY2NvcmRpbmcgdG8gcGxhbmUgcGFyYW1l dGVycywgZGRiIGlzIGFsbG9jYXRlZCBhY2NvcmRpbmcKPiA+ID4gdG8gbnVtYmVyIG9mIENSVEMg ZW5hYmxlZCwgJiBkaXZpZGVkIGVxdWFsbHkgYW1vbmcgQ1RSQydzLgo+ID4gPiAKPiA+ID4gSW4g Y3VycmVudCBjb25kaXRpb24gY2hlY2sgZHVyaW5nIFdhdGVybWFyayBjYWxjdWxhdGlvbiwgaWYg bnVtYmVyIG9mCj4gPiA+IHBsYW5lL2RkYiBhbGxvY2F0aW9uIGNoYW5nZXMgZm9yIGN1cnJlbnQg Q1JUQywgV2F0ZXJtYXJrIGZvciBvdGhlciBwaXBlcwo+ID4gPiBhcmUgcmVjYWxjdWxhdGVkLiBC dXQgdGhlcmUgaXMgbm8gY2hhbmdlIGluIEREQiBhbGxvY2F0aW9uIG9mIG90aGVyIHBpcGUKPiA+ ID4gc28gd2F0ZXJtYXJrIGlzIGFsc28gbm90IGNoYW5nZWQsIFRoaXMgbGVhZHMgdG8gd2Fybmlu ZyBtZXNzYWdlcy4KPiA+ID4gV0FSTl9PTighd21fY2hhbmdlZCkKPiA+ID4gCj4gPiA+IFRoaXMg cGF0Y2ggY29ycmVjdHMgdGhpcyBhbmQgY2hlY2sgaWYgRERCIGFsbG9jYXRpb24gZm9yIHBpcGVz IGlzIGNoYW5nZWQsCj4gPiA+IHRoZW4gb25seSByZWNhbGN1bGF0ZSB3YXRlcm1hcmtzLgo+ID4g PiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogS3VtYXIsIE1haGVzaCA8bWFoZXNoMS5rdW1hckBpbnRl bC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8 IDEyICsrKysrLS0tLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwg NyBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gPiBp bmRleCA2MmRlOTdlLi5hMWVkOTIwIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wbS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bt LmMKPiA+ID4gQEAgLTMxMjcsMTQgKzMxMjcsMTIgQEAgc3RhdGljIGJvb2wgc2tsX2RkYl9hbGxv Y2F0aW9uX2NoYW5nZWQoY29uc3Qgc3RydWN0IHNrbF9kZGJfYWxsb2NhdGlvbiAqbmV3X2RkYiwK PiA+ID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfY3J0Yy0+YmFzZS5kZXY7Cj4g PiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0 ZTsKPiA+ID4gIAljb25zdCBzdHJ1Y3Qgc2tsX2RkYl9hbGxvY2F0aW9uICpjdXJfZGRiID0gJmRl dl9wcml2LT53bS5za2xfaHcuZGRiOwo+ID4gPiAtCWVudW0gcGlwZSBwaXBlID0gaW50ZWxfY3J0 Yy0+cGlwZTsKPiA+ID4gLQo+ID4gPiAtCWlmIChtZW1jbXAobmV3X2RkYi0+cGxhbmVbcGlwZV0s IGN1cl9kZGItPnBsYW5lW3BpcGVdLAo+ID4gPiAtCQkgICBzaXplb2YobmV3X2RkYi0+cGxhbmVb cGlwZV0pKSkKPiA+ID4gLQkJcmV0dXJuIHRydWU7Cj4gPiA+ICAKPiA+ID4gLQlpZiAobWVtY21w KCZuZXdfZGRiLT5jdXJzb3JbcGlwZV0sICZjdXJfZGRiLT5jdXJzb3JbcGlwZV0sCj4gPiA+IC0J CSAgICBzaXplb2YobmV3X2RkYi0+Y3Vyc29yW3BpcGVdKSkpCj4gPiA+ICsJLyoKPiA+ID4gKwkg KiBJZiBkZGIgYWxsb2NhdGlvbiBvZiBwaXBlcyBjaGVuZ2VkLCBpdCBtYXkgcmVxdWlyZSByZWNh bGN1bGF0aW9uIG9mCj4gPiA+ICsJICogd2F0ZXJtYXJrcwo+ID4gPiArCSAqLwo+ID4gPiArCWlm IChtZW1jbXAobmV3X2RkYi0+cGlwZSwgY3VyX2RkYi0+cGlwZSwgc2l6ZW9mKG5ld19kZGItPnBp cGUpKSkKPiA+ID4gIAkJcmV0dXJuIHRydWU7Cj4gPiAKPiA+IEkgc3RpbGwgaGF2ZSB0aGUgY3Vy c29yIGNvZGUgaGVyZSwgdGhpcyBwYXRjaCBuZWVkcyB0byBiZSByZWJhc2VkLgo+IAo+IEkgc3Vw cG9zZSB5b3UgbWVhbiB5b3UgaGF2ZSB0aGUgb3RoZXIgY3Vyc29yIGNvZGUgdGhlcmUsIGNhdXNl IHRoaXMgb25lCj4gaGFzIGl0IHRvbywganVzdCBsb29raW5nIGEgYml0IGRpZmZlcmVudC4KCkht IHllYWggcmlnaHQsIGp1c3Qgc2hvd3MgaG93IGxpdHRsZSBJIHVuZGVyc3RhbmQgZnJvbSB0aGUg d20gY29kZSBkZXRhaWxzCjstKQoKQW55d2F5LCBwbGVhc2UgcmViYXNlIHNpbmNlIEkgY2FuJ3Qg bWFrZSB0aGlzIG9uZSBmaXQgd2l0aG91dCB0b28gbXVjaApyaXNrIG9mIG1lIGZ1bWJsaW5nIHRo aW5ncy4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwg Q29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK