From: Patrik Jakobsson Subject: Re: [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized Date: Mon, 26 Oct 2015 10:57:15 +0100 Message-ID: <20151026095715.GA3242@patrik-desktop.isw.intel.com> References: <1445593310-26596-1-git-send-email-patrik.jakobsson@linux.intel.com> <562B1811.1060000@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A1C66E8C2 for ; Mon, 26 Oct 2015 02:57:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <562B1811.1060000@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Animesh Manna Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBPY3QgMjQsIDIwMTUgYXQgMTE6MDM6MDVBTSArMDUzMCwgQW5pbWVzaCBNYW5uYSB3 cm90ZToKPiAKPiAKPiBPbiAxMC8yMy8yMDE1IDM6MTEgUE0sIFBhdHJpayBKYWtvYnNzb24gd3Jv dGU6Cj4gPlRoZSBjdXJyZW50IENTUiBsb2FkaW5nIGNvZGUgZGVwZW5kcyBvbiB0aGUgQ1NSIHBy b2dyYW0gbWVtb3J5IHRvIGJlCj4gPmNsZWFyZWQgYWZ0ZXIgYm9vdC4gVGhpcyBpcyB1bmZvcnR1 bmF0ZWx5IG5vdCB0cnVlIG9uIGFsbCBoYXJkd2FyZS4KPiA+SW5zdGVhZCBtYWtlIHVzZSBvZiB0 aGUgRldfVU5JTklUSUFMSVpFRCBzdGF0ZSBpbiBpbml0IGFuZCBjaGVjayBmb3IKPiA+RldfTE9B REVEIHRvIHByZXZlbnQgaW5pdCBwYXRoIGZyb20gc2tpcHBpbmcgdGhlIGFjdHVhbCBwcm9ncmFt bWluZy4KPiA+Cj4gPnYyOiBNb3ZlIGluaXRpYWxpemF0aW9uIG9mIHN0YXRlIHRvIGFmdGVyIEhB U19DU1IoKSBjaGVjawo+ID4KPiA+U2lnbmVkLW9mZi1ieTogUGF0cmlrIEpha29ic3NvbiA8cGF0 cmlrLmpha29ic3NvbkBsaW51eC5pbnRlbC5jb20+Cj4gPlRlc3RlZC1ieTogUm9kcmlnbyBWaXZp IDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID5SZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxy b2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9jc3IuYyB8IDQgKysrLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKPiA+Cj4gPmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9jc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nzci5jCj4gPmluZGV4IDll NTMwYTcuLmU3NGMwOWUgMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Nzci5jCj4gPisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nzci5jCj4gPkBAIC0y NzEsNyArMjcxLDcgQEAgdm9pZCBpbnRlbF9jc3JfbG9hZF9wcm9ncmFtKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4gPiAgCSAqIFVuZm9ydHVuYXRlbHkgdGhlIEFDUEkgc3Vic3lzdGVtIGRvZXNu J3QgeWV0IGdpdmUgdXMgYSB3YXkgdG8KPiA+ICAJICogZGlmZmVyZW50aWF0ZSB0aGlzLCBoZW5j ZSBmaWd1cmUgaXQgb3V0IHdpdGggdGhpcyBoYWNrLgo+ID4gIAkgKi8KPiA+LQlpZiAoSTkxNV9S RUFEKENTUl9QUk9HUkFNKDApKSkKPiA+KwlpZiAoSTkxNV9SRUFEKENTUl9QUk9HUkFNKDApKSAm JiBkZXZfcHJpdi0+Y3NyLnN0YXRlID09IEZXX0xPQURFRCkuc3RhdGUKPiAKPiBBcyBJIHdpbGwg YmUgcmVtb3ZpbmcgY3NyLnN0YXRlIGluIGRtYy1yZWRlc2lnbiBwYXRjaCBzZXJpZXMgbXkgc3Vn Z2VzdGlvbiB3b3VsZCBiZSB0bwo+IGNvbXBhcmUgcmVnaXN0ZXIgcmVhZCB3aXRoIGZpcnN0IGVs ZW1lbnQgb2YgcGF5bG9hZCBsaWtlIGJlbG93OgoKSXMgdGhlIHJlZGVzaWduIHNlcmllcyBsaWtl bHkgdG8gbGFuZCBzb29uPyBDdXJyZW50bHkgdGhlIGRtYyBmdyBpc24ndCBsb2FkaW5nCmF0IGFs bCBvbiBza2wgd2hpY2ggaXMgYSBzdG9wcGVyIGZvciBxdWl0ZSBhIGZldyBmZWF0dXJlcy4KCj4g aWYgKEk5MTVfUkVBRChDU1JfUFJPR1JBTSgwKSkgPT0gZG1jX3BheWxvYWRbMF0pIGFuZCB0aGVu IHNraXAgdGhlIGYvdyBsb2FkaW5nIHBhcnQuCgpJIGhhdmVuJ3QgbG9va2VkIGF0IHdoYXQgaXMg c3RvcmVkIGluIENTUl9QUk9HUkFNKDApIG9uIHNrbCBhZnRlciBib290IGJ1dCBjYW4Kd2UgcmVh bGx5IHRydXN0IHRoaXMgY2hlY2s/IElzIHRoZXJlIHJlYWxseSBubyBvdGhlciB3YXkgdG8gdmVy aWZ5IGlmIGl0J3MgdXAKYW5kIHJ1bm5pbmcgYWxyZWFkeT8gV2hhdCB3YXMgdGhlIGNvbmNsdXNp b24gZnJvbSB5b3VyIGRpc2N1c3Npb24gd2l0aCBEYW5pZWwKYWJvdXQga2VlcGluZyB0cmFjayBv ZiB0aGlzIG1hbnVhbGx5PwoKLVBhdHJpawoKPiAtQW5pbWVzaAo+IAo+IAo+ID4gIAkJcmV0dXJu Owo+ID4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+Y3NyX2xvY2spOwo+ID5AQCAtNDI4LDYgKzQy OCw4IEBAIHZvaWQgaW50ZWxfY3NyX3Vjb2RlX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiA+ICAJaWYgKCFIQVNfQ1NSKGRldikpCj4gPiAgCQlyZXR1cm47Cj4gPisJaW50ZWxfY3NyX2xv YWRfc3RhdHVzX3NldChkZXZfcHJpdiwgRldfVU5JTklUSUFMSVpFRCk7Cj4gPisKPiA+ICAJaWYg KElTX1NLWUxBS0UoZGV2KSkKPiA+ICAJCWNzci0+ZndfcGF0aCA9IEk5MTVfQ1NSX1NLTDsKPiA+ ICAJZWxzZSBpZiAoSVNfQlJPWFRPTihkZXZfcHJpdikpCj4gCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==