From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v3 1/5] xl: convert main() exit codes to
 EXIT_[SUCCESS|FAILURE]
Date: Tue, 27 Oct 2015 11:11:09 +0000
Message-ID: <20151027111109.GS18674@zion.uk.xensource.com>
References: <1445939452-8091-1-git-send-email-write.harmandeep@gmail.com>
	<1445939452-8091-2-git-send-email-write.harmandeep@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <1445939452-8091-2-git-send-email-write.harmandeep@gmail.com>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Harmandeep Kaur <write.harmandeep@gmail.com>
Cc: lars.kurth@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org

On Tue, Oct 27, 2015 at 03:20:48PM +0530, Harmandeep Kaur wrote:
[...]
>  };
>  
> +/*
> + *The xl process should always return either EXIT_SUCCESS or
> + *EXIT_FAILURE. main_* functions, implementing the various xl
> + *commands, can be treated as main() as if they are returning
> + *a process exit status and not a function return value.
> + */
> +

Missing spaces after "*". E.g.
   /*
    * The xl process ....
    * EXIT_FAILURE
    * ...
    */

With that fixed:

Acked-by: Wei Liu <wei.liu2@citrix.com>

(This means after fixing the minor problem you can put the above tag in
your commit message. If in doubt, please ask.)


>  int main_vcpulist(int argc, char **argv);
>  int main_info(int argc, char **argv);
>  int main_sharing(int argc, char **argv);
> -- 
> 1.9.1