Date: Tue, 27 Oct 2015 13:51:06 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20151027135106.623c227b.cornelia.huck@de.ibm.com>
In-Reply-To: <1445948971-3929-1-git-send-email-mst@redhat.com>
References: <1445948971-3929-1-git-send-email-mst@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fixup! virtio: introduce virtio_map
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org

On Tue, 27 Oct 2015 14:30:05 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> ---
> 
> This will fix the issue reported by Cornelia.
> 
>  hw/virtio/virtio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index be32145..ed1f274 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -449,7 +449,7 @@ int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes,
>  }
> 
>  static void virtqueue_map_iovec(struct iovec *sg, hwaddr *addr,
> -                                size_t *num_sg, size_t max_size,
> +                                unsigned int *num_sg, unsigned int max_size,
>                                  int is_write)
>  {
>      unsigned int i;

With this fixup applied, both s390 machines come up. virtio-serial and
virtio-blk with and without dataplane seem fine.

At a first glance, the code seems fine as well.