Received: from eggs.gnu.org ([2001:4830:134:3::10]:42383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr9sY-0003ch-Ve for qemu-devel@nongnu.org; Tue, 27 Oct 2015 15:25:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr9sU-0001Mg-2h for qemu-devel@nongnu.org; Tue, 27 Oct 2015 15:25:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr9sT-0001MM-UC for qemu-devel@nongnu.org; Tue, 27 Oct 2015 15:25:50 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 8B160AA8 for ; Tue, 27 Oct 2015 19:25:49 +0000 (UTC) Date: Tue, 27 Oct 2015 17:25:46 -0200 From: Eduardo Habkost Message-ID: <20151027192546.GK4180@thinpad.lan.raisama.net> References: <1445879623-8403-1-git-send-email-ehabkost@redhat.com> <20151027073038.GA3927@hawk.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151027073038.GA3927@hawk.localdomain> Subject: Re: [Qemu-devel] [PATCH] vl.c: Replace fprintf(stderr) with error_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster On Tue, Oct 27, 2015 at 08:30:38AM +0100, Andrew Jones wrote: > In addition to Markus' and Eric's comments, I think we should > > 1. make sure the first word's case is correct. Lowercase for phrases, > uppercase for sentences and proper nouns. I think I can understand this in the more obvious cases, but I don't know how I could convert the following instance: [...] > > case QEMU_OPTION_no_kvm_pit: { > > - fprintf(stderr, "Warning: KVM PIT can no longer be disabled " > > - "separately.\n"); > > + error_report("Warning: KVM PIT can no longer be disabled " > > + "separately."); > > Could change this from a sentence into a phrase. Also, we need a consistent > 'warning' prefix. Should we make a error_report_warn variant? Converting that sentence to a phrase is beyond my non-native english speaker skills. Do you have any suggestions? :) -- Eduardo